Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-forge makers does not support arch #610

Closed
3 tasks done
liudonghua123 opened this issue Oct 26, 2018 · 2 comments
Closed
3 tasks done

electron-forge makers does not support arch #610

liudonghua123 opened this issue Oct 26, 2018 · 2 comments

Comments

@liudonghua123
Copy link
Contributor

liudonghua123 commented Oct 26, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:

I tried to build https://github.com/felixrieseberg/windows95, and the content of forge.config.js#L30 is "setupExe: windows95-${package.version}-setup-${process.arch}.exe", And I run electron-forge make --arch=ia32,x64 on my Windows 10 64bit. the files generated are

.
├── ia32
│   ├── RELEASES
│   ├── windows98-1.3.0-full.nupkg
│   └── windows98-win32-1.3.0-setup-x64.exe
└── x64
    ├── RELEASES
    ├── windows98-1.3.0-full.nupkg
    └── windows98-win32-1.3.0-setup-x64.exe

The install file is the same, When I delete this line of config, the files generated are

.
├── ia32
│   ├── RELEASES
│   ├── windows98-1.3.0-full.nupkg
│   └── windows98-1.3.0 Setup.exe
└── x64
    ├── RELEASES
    ├── windows98-1.3.0-full.nupkg
    └── windows98-1.3.0 Setup.exe

It was the same too.

But in other makers like deb, rpm, zip, different arch generate different files like

├── windows98_1.3.0_amd64.deb
├── windows98_1.3.0_i386.deb
├── windows98-1.3.0.i386.rpm
├── windows98-1.3.0.x86_64.rpm
├── windows98-linux-ia32-1.3.0.zip
└── windows98-linux-x64-1.3.0.zip

So I have two ideas about this.

  1. change https://github.com/electron-userland/electron-forge/blob/master/packages/maker/squirrel/src/MakerSquirrel.ts#L33 include targetArch like https://github.com/electron-userland/electron-forge/blob/master/packages/maker/deb/src/MakerDeb.ts#L35 does.
  2. provide the correct targetArch envrionment in makers configuration.

I want to deploy the generate files to github release via travis-ci, so the same filename file will overwrite the exists one.

@liudonghua123
Copy link
Contributor Author

I write a #611 to fix this problem.

@malept malept mentioned this issue Nov 17, 2018
5 tasks
@malept
Copy link
Member

malept commented Dec 27, 2018

You can specify arch by setting the maker's config to be a function. For example: electron/fiddle#125

@malept malept closed this as completed Dec 27, 2018
dsanders11 pushed a commit that referenced this issue Jan 14, 2023
* fix: 'decompress is not a function' error with esModuleInterop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants