feat: Minor redesign, new component library #120
Conversation
| const path = require('path'); | ||
| const package = require('./package.json'); | ||
| const path = require('path') | ||
| const packackeJson = require('./package.json') |
There was a problem hiding this comment.
package is a reserved word in strict mode and I should have never used it 😢
There was a problem hiding this comment.
We use packageJSON in a bunch of places in Electron Forge. Alternatively, metadata.
| @@ -45,7 +46,7 @@ module.exports = { | |||
| loadingGif: './assets/loading.gif', | |||
| noMsi: true, | |||
| remoteReleases: '', | |||
| setupExe: `electron-fiddle-${package.version}-setup-${process.arch}.exe`, | |||
| setupExe: `electron-fiddle-${version}-setup.exe`, | |||
There was a problem hiding this comment.
Are we not going to distribute setup files for multiple Windows arches, then?
There was a problem hiding this comment.
We are, I'll just have to handle this manually for now. Is there a way to get whatever architecture forge is actually using?
I'll merge this for now, but I'd love to do something like this:
import { args } from '@electron-forge/cli'
const { arch } = args
There was a problem hiding this comment.
I think it'd have to be a postMake hook to rename the artifact with the correct arch. I'd verify with Sam but he's 🌴 😄
There was a problem hiding this comment.
I only muted electron/electron 😄 I'd go crazy if I didn't use GH at all for 5 weeks 😆
You're looking for this hack 😄 Ignore the comment, I'm probably gonna just make it official API 👍
Basically, your config property can be function instead that takes in the target arch and returns the config object
There was a problem hiding this comment.
I'll probably end up doing something similar to the fromBuildIdentifier helper --> https://v6.electronforge.io/configuration#build-identifier
This fairly big PR contains a minor redesign.
It switches Fiddle from a homegrown and modified version of Miligram to Blueprint.js. The former is great, but the latter is just much better suited to our use case – I want Fiddle to be an effective tool for people getting started or working with Electron and good UI components are an important building step. Having some experience with Blueprint, I'm really impressed with the code quality behind the library.
It also:
• Updates parcel and improves the build
• Refactors a bunch of components