Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting USE_SYSTEM_7ZA environment variable breaks the build #8151

Closed
darind opened this issue Mar 25, 2024 · 0 comments · Fixed by #8152
Closed

Setting USE_SYSTEM_7ZA environment variable breaks the build #8151

darind opened this issue Mar 25, 2024 · 0 comments · Fixed by #8152

Comments

@darind
Copy link

darind commented Mar 25, 2024

electron-builder version: 24.13.3
electron version: 27.3.1
node-js version: 20.10.0

If we set the USE_SYSTEM_7ZA=true environment variable, then the 7zip-bin package will return 7za as path to the executable: https://github.com/develar/7zip-bin/blob/master/index.js#L7.

This is used here: https://github.com/electron-userland/electron-builder/blob/master/packages/builder-util/src/7za.ts#L5.

The chmod call is failing because we do not specify the absolute path to the executable.

This is a regression from v24.6.4 where no call to chmod was made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant