Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous documentation about BitbucketOptions #7323

Closed
onucsecu2 opened this issue Dec 18, 2022 · 0 comments
Closed

Ambiguous documentation about BitbucketOptions #7323

onucsecu2 opened this issue Dec 18, 2022 · 0 comments

Comments

@onucsecu2
Copy link
Contributor

onucsecu2 commented Dec 18, 2022

  • Electron-Builder Version: 20.1.3
  • Node Version: 16.15.1
  • Electron Version: 20.3.8
  • Electron Type (current, beta, nightly):
  • Target: mac

According to the documentation, BitbucketOptions need a token key.
The description is written about the key is wrong. Because Access Token and App Password are two different things regarding Bitbucket.
It is written:

token String | “undefined” - The access token to support auto-update from private bitbucket repositories.

But it should be

token String | “undefined” - The app password to support auto-update from private bitbucket repositories.

There is a code snippet for converting an app password to a usable token.

convertAppPassword(username: string, appPassword: string) {

  const base64encodedData = Buffer.from(`${username}:${appPassword.trim()}`).toString("base64")

  return `Basic ${base64encodedData}`

}


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant