From b0e1b6f8af95bc371c0bc91df65965f3f60f3a87 Mon Sep 17 00:00:00 2001 From: Georg Vienna Date: Mon, 4 Jul 2022 05:22:34 +0200 Subject: [PATCH] fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE when specifying appPackageUrl (#6964) --- .changeset/cuddly-books-approve.md | 5 +++++ .../app-builder-lib/src/targets/nsis/WebInstallerTarget.ts | 3 +-- .../app-builder-lib/templates/nsis/include/webPackage.nsh | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) create mode 100644 .changeset/cuddly-books-approve.md diff --git a/.changeset/cuddly-books-approve.md b/.changeset/cuddly-books-approve.md new file mode 100644 index 00000000000..a41036da1d5 --- /dev/null +++ b/.changeset/cuddly-books-approve.md @@ -0,0 +1,5 @@ +--- +"app-builder-lib": patch +--- + +fix: nsis-web target set APP_PACKAGE_URL_IS_INCOMPLETE diff --git a/packages/app-builder-lib/src/targets/nsis/WebInstallerTarget.ts b/packages/app-builder-lib/src/targets/nsis/WebInstallerTarget.ts index 498f9f404b6..f8311c3f231 100644 --- a/packages/app-builder-lib/src/targets/nsis/WebInstallerTarget.ts +++ b/packages/app-builder-lib/src/targets/nsis/WebInstallerTarget.ts @@ -29,10 +29,9 @@ export class WebInstallerTarget extends NsisTarget { } appPackageUrl = computeDownloadUrl(publishConfigs[0], null, packager) - - defines.APP_PACKAGE_URL_IS_INCOMLETE = null } + defines.APP_PACKAGE_URL_IS_INCOMPLETE = null defines.APP_PACKAGE_URL = appPackageUrl } diff --git a/packages/app-builder-lib/templates/nsis/include/webPackage.nsh b/packages/app-builder-lib/templates/nsis/include/webPackage.nsh index d8df0557c98..8ec0be318a7 100644 --- a/packages/app-builder-lib/templates/nsis/include/webPackage.nsh +++ b/packages/app-builder-lib/templates/nsis/include/webPackage.nsh @@ -5,7 +5,7 @@ StrCpy $packageUrl "${APP_PACKAGE_URL}" StrCpy $packageArch "${APP_PACKAGE_URL}" - !ifdef APP_PACKAGE_URL_IS_INCOMLETE + !ifdef APP_PACKAGE_URL_IS_INCOMPLETE !ifdef APP_64_NAME !ifdef APP_32_NAME !ifdef APP_ARM64_NAME