Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using macros #63

Open
slorber opened this issue Nov 14, 2018 · 2 comments
Open

Consider using macros #63

slorber opened this issue Nov 14, 2018 · 2 comments

Comments

@slorber
Copy link

slorber commented Nov 14, 2018

Hi,

Using babel macros would be handy for this: it allows babel to generate require statements you need at transpilation time. The advantage would be to avoid running the cli everytime you want to update your story list.

Here is an example:
https://github.com/kentcdodds/import-all.macro

@karanjthakkar
Copy link

karanjthakkar commented Dec 20, 2018

@slorber iirc, using macros creates a problem that you have brought up previously elsewhere: facebook/metro#105 Has anything changed that would allow this now?

@slorber
Copy link
Author

slorber commented Dec 20, 2018

@karanjthakkar actually you are right using macros can be a problem due to metro caching. I didn't really dig more into this problem or the getCacheKey option so not sure macros are yet suitable for this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants