Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Allow Heartbeat to capture body text on error #37

Closed
dov0211 opened this issue May 22, 2019 · 9 comments · Fixed by elastic/beats#13022
Closed

[Uptime] Allow Heartbeat to capture body text on error #37

dov0211 opened this issue May 22, 2019 · 9 comments · Fixed by elastic/beats#13022
Assignees
Labels
design enhancement New feature or request :uptime

Comments

@dov0211
Copy link

dov0211 commented May 22, 2019

Allow Heartbeat to capture text on error.
Since the text might be long we should consider limit its size.

   "monitor": {
      ...
      "status": "down",
      "text_on_error": "500 Internal Server Error"
      ...
     }

@andrewvc

@andrewvc
Copy link
Contributor

PR Here: elastic/beats#13022

@andrewvc
Copy link
Contributor

@katrin-freihofner we'll need some help on the design for this one. We'll want to add this to the monitor detail pages somehow.

@andrewvc
Copy link
Contributor

@katrin-freihofner one additional thought, my initial thinking here is that we should keep it simple for v1, since we're thinking of replacing the ping list component with timelines. Fitting this data (and error data) into timelines is kind of tricky, but I don't think we need to solve that here of course.

@katrin-freihofner
Copy link
Contributor

katrin-freihofner commented Jul 25, 2019

@andrewvc I would combine it with the error column and give this one more space/width. Similar to this:

Screenshot 2019-07-25 at 10 21 03

@andrewvc
Copy link
Contributor

@katrin-freihofner to be clear, you'd literally concatenate the error + body strings if I understand. Is that right?

@katrin-freihofner
Copy link
Contributor

@andrewvc yes, that is my proposal. Having it in it's own column would only make sense if users want to sort it by error message and error type separately - but I guess sorting it by error type makes more sense, doesn't is?

@andrewvc
Copy link
Contributor

Hmmm, how would that work when the body is recorded but the response is a success. In the patch that is a possibility. Additionally, displaying a full kilobyte in that column might be a bit much.

I'm thinking a drawer makes a lot of sense here because it will handle larger content sizes really well and we could include the first N bytes of the body + the checksum (with a zoom to filter icon on the body checksum).

WDYT? Is this a misuse of drawers? I'm worried that cramming it all into one column will yield some weird pages.

@katrin-freihofner
Copy link
Contributor

@andrewvc yes, I agree it is better to move it to an expandable row.

@andrewvc andrewvc mentioned this issue Aug 8, 2019
2 tasks
@andrewvc
Copy link
Contributor

andrewvc commented Aug 8, 2019

Closing this in favor of implementation issue here: #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New feature or request :uptime
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants