Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datasource/deployments: Filter by name. #797

Merged
merged 1 commit into from
Mar 18, 2024
Merged

datasource/deployments: Filter by name. #797

merged 1 commit into from
Mar 18, 2024

Conversation

gigerdo
Copy link
Member

@gigerdo gigerdo commented Mar 14, 2024 •
edited
Loading

Description

  • Extends the ec_deployments data source with an additional filter name
  • Using this parameter will search for deployments with this exact name (uses an ES term query internally)
  • As an alternative to name_prefix that searches by a prefix.

Related Issues

#639

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@gigerdo
ec_deployments: Filter by name.
8d7fcc6 
Allows searching for a deployment by the exact name.
@gigerdo gigerdo force-pushed the deployments-filter-by-exact-name branch from 9652d19 to 8d7fcc6 Compare March 14, 2024 16:45
@gigerdo gigerdo changed the title ec_deployments: Filter by name. datasource/deployments: Filter by name. Mar 14, 2024
@gigerdo gigerdo marked this pull request as ready for review March 14, 2024 16:48
@gigerdo gigerdo requested a review from a team as a code owner March 14, 2024 16:48
@gigerdo gigerdo requested review from dimuon and tobio March 14, 2024 16:48
dimuon
dimuon approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tobio
tobio approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gigerdo gigerdo merged commit 8348ffc into elastic:master Mar 18, 2024
2 of 3 checks passed
@gigerdo gigerdo deleted the deployments-filter-by-exact-name branch March 18, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobio tobio tobio approved these changes

@dimuon dimuon dimuon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gigerdo @tobio @dimuon