Reset es password #642
Merged
Reset es password #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimuon
reviewed
May 10, 2023
| if isResetting != nil && *isResetting { | ||
| planVal := resp.AttributePlan.(types.String) | ||
| planVal.Unknown = true | ||
| resp.AttributePlan = planVal |
There was a problem hiding this comment.
Suggested change
| resp.AttributePlan = planVal | |
| resp.AttributePlan = types.String{Unknown: true} |
There was a problem hiding this comment.
Sorry, the suggestion doesn't reflect the all proposed changes. planVal can be totally removed.
There was a problem hiding this comment.
All good. Good pickup, I was testing something out here and forgot to revert it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
reset_elasticsearch_passwordattribute to the deployment resource, when true this explicitly resets the password, updating the value in state with the new credentials.Related Issues
Fixes #99
Motivation and Context
With the migration to 0.6 and higher requiring re-importing existing deployments, which in turn does not include the current elastic user, customers need a path to programatically update the credentials in TF state.
How Has This Been Tested?
Acceptance tests, manual tests.
Types of Changes
Readiness Checklist