Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fleet endpoints #640

Merged
merged 5 commits into from
May 25, 2023
Merged

Fleet endpoints #640

merged 5 commits into from
May 25, 2023

Conversation

tobio
Copy link
Member

@tobio tobio commented May 9, 2023

Description

Explicitly captures the Fleet and APM endpoints within an Integrations Server resource.

Related Issues

Fixes #605

How Has This Been Tested?

Unit, manual testing

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@tobio tobio requested a review from dimuon May 9, 2023 07:58
@tobio tobio requested review from alaudazzi and a team as code owners May 9, 2023 07:58
@tobio tobio self-assigned this May 9, 2023
@jamesagarside
Copy link

This would be a great edition. Currently we're required to bodge it

dimuon
dimuon approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tobio tobio merged commit 6294614 into elastic:master May 25, 2023
@tobio tobio deleted the fleet-endpoints branch May 25, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimuon dimuon dimuon approved these changes

@alaudazzi alaudazzi Awaiting requested review from alaudazzi

Assignees

@tobio tobio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fleet_https_endpoint and ec module v0.6.0
3 participants
@tobio @jamesagarside @dimuon