Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data sources for private link connection information #533

Merged
merged 5 commits into from
Sep 15, 2022

Conversation

tobio
Copy link
Member

@tobio tobio commented Sep 12, 2022

Description

Adds three data sources to lookup Private Link/PSC connection information directly from the Terraform provider. Currently this data is sourced from an embedded JSON file, we're looking at incorporating this into the ESS API to simplify updating config.

Related Issues

Fixes #514

How Has This Been Tested?

Manually
Unit tests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@tobio tobio requested review from alaudazzi, nrichers and a team as code owners September 12, 2022 13:20
@tobio tobio force-pushed the privatelink-datasource branch 2 times, most recently from 9aba50d to 47e9918 Compare September 14, 2022 10:20
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobio tobio force-pushed the privatelink-datasource branch from d245d76 to dc1fadf Compare September 14, 2022 22:10
@tobio tobio merged commit 246c504 into elastic:master Sep 15, 2022
@tobio tobio deleted the privatelink-datasource branch September 15, 2022 01:11
dimuon pushed a commit to dimuon/terraform-provider-ec that referenced this pull request Feb 2, 2023
* AWS Private Link data source

* GCP PSC data source

* Azure Private Link data source

* Docs

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data resource to lookup privatelink information.
2 participants