Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ref_id output to data.ec_deployments #379

Closed
Crazybus opened this issue Sep 13, 2021 · 2 comments · Fixed by #380
Closed

Add ref_id output to data.ec_deployments #379

Crazybus opened this issue Sep 13, 2021 · 2 comments · Fixed by #380
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Crazybus
Copy link
Contributor

Overview

Add ref_id to data.ec_deployments. It is currently only available in data.ec_deployment: https://registry.terraform.io/providers/elastic/ec/latest/docs/data-sources/ec_deployment#elasticsearch.#.ref_id

Possible Implementation

Testing

Context

When adding remote clusters from data.ec_deployments it isn't possible to add clusters which don't have the current default ref_id of main-elasticsearch. Leaving it blanks results in the error message:

deployments.deployment_remote_resource_not_found: Invalid Remote Clusters Configuration. The following resource could not be found:(deployment [removed] - ref_id [main-elasticsearch])

An example of it being used with data.ec_deployment can be seen here:
https://registry.terraform.io/providers/elastic/ec/latest/docs/resources/ec_deployment#with-cross-cluster-search-settings

Your Environment

@Crazybus Crazybus added enhancement New feature or request Team:Delivery labels Sep 13, 2021
@marclop marclop added this to the v0.3.0 milestone Sep 13, 2021
@marclop marclop self-assigned this Sep 13, 2021
@marclop
Copy link
Contributor

marclop commented Sep 13, 2021

@Crazybus the example uses the ec_deployment resource, not any of the data resources. I'll work on adding this to the data.ec_deployments so it's available.

@gtback
Copy link
Member

gtback commented Sep 14, 2021

I think this got closed accidentally by a comment that was referring to a workaround for this issue.

@gtback gtback reopened this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants