Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec_deployment: Add support for deployment aliases #298

Merged
merged 4 commits into from
May 6, 2021

Conversation

marclop
Copy link
Contributor

@marclop marclop commented Apr 15, 2021

Description

Adds support for deployment aliases on both the ec_deployment resource
and ec_deployment datasource.

Related Issues

Closes #287

How Has This Been Tested?

Manual, unit and acceptance tested.

Types of Changes

  • New feature (non-breaking change which adds functionality)

@marclop marclop added enhancement New feature or request Team:Delivery labels Apr 15, 2021
@marclop marclop self-assigned this Apr 15, 2021
@marclop marclop requested review from alaudazzi, nrichers and a team as code owners April 15, 2021 06:46
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the .md files

Copy link
Contributor

@karencfv karencfv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@marclop
Copy link
Contributor Author

marclop commented May 4, 2021

TestAccDeployment_basic_config seems to return with a non-empty plan on step 2/3:

12:11:27  === CONT  TestAccDeployment_basic_config
12:11:27      deployment_basic_test.go:95: Step 2/3 error: After applying this test step, the plan was not empty.
12:11:27          stdout:
12:11:27          
12:11:27          
12:11:27          Terraform used the selected providers to generate the following execution
12:11:27          plan. Resource actions are indicated with the following symbols:
12:11:27            ~ update in-place
12:11:27          
12:11:27          Terraform will perform the following actions:
12:11:27          
12:11:27            # ec_deployment.basic will be updated in-place
12:11:27            ~ resource "ec_deployment" "basic" {
12:11:27                ~ alias                  = "terraform-acc-tnvcsx8mmv" -> "basic"
12:11:27                  id                     = "36f2ce73ef9c96b8f5c943a451098043"
12:11:27                  name                   = "terraform_acc_tnvcsx8mmv"
12:11:27                  tags                   = {}
12:11:27                  # (6 unchanged attributes hidden)
12:11:27          
12:11:27          
12:11:27          
12:11:27          
12:11:27                  # (4 unchanged blocks hidden)
12:11:27              }
12:11:27          
12:11:27          Plan: 0 to add, 1 to change, 0 to destroy.

I'll take a look.

marclop added 2 commits May 5, 2021 10:55
Adds support for deployment aliases on both the `ec_deployment` resource
and `ec_deployment` datasource.

Signed-off-by: Marc Lopez <marc5.12@outlook.com>
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
@marclop marclop force-pushed the f/support-deployment-aliases branch from 45ed7f4 to b5520f4 Compare May 5, 2021 05:55
marclop added 2 commits May 5, 2021 12:26
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
@marclop
Copy link
Contributor Author

marclop commented May 5, 2021

Tests look alright, I think we can merge this. @karencfv

@marclop marclop merged commit 2daa9af into elastic:master May 6, 2021
@marclop marclop deleted the f/support-deployment-aliases branch May 6, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ec_deployment: support deployment aliases
3 participants