Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec_deployment: Fix where datasource was adding unused topology elements #242

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

karencfv
Copy link
Contributor

Description

This PR is a follow up to the bug discovered in #241

The deployment read API returns all possible topology elements
even if the size is set to 0. This means that the ec_deployment datasource
will return more topology elements than what is set in the ec_deployment
resource. This patch makes sure only the topology elements used in the
deployment are returned.

Motivation and Context

Fix teh bugs and make the tests pass!

How Has This Been Tested?

Manually and acceptance tests

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@karencfv karencfv added the bug Something isn't working label Feb 17, 2021
@karencfv karencfv requested a review from a team as a code owner February 17, 2021 06:50
@karencfv karencfv self-assigned this Feb 17, 2021
@karencfv
Copy link
Contributor Author

Relevant test passing:

Screen Shot 2021-02-18 at 12 50 44 PM

Copy link
Contributor

@marclop marclop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marclop marclop merged commit ddf92b7 into elastic:master Feb 18, 2021
@karencfv karencfv deleted the deployment-datasource-topology-fix branch February 18, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants