Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec_deployments: Filter by deployment tags #182

Closed
karencfv opened this issue Nov 12, 2020 · 4 comments · Fixed by #244 or #248
Closed

ec_deployments: Filter by deployment tags #182

karencfv opened this issue Nov 12, 2020 · 4 comments · Fixed by #244 or #248
Assignees
@neiljbrookes
Labels
enhancement New feature or request
Milestone
v0.1.0

Comments

@karencfv
Copy link
Contributor

Description

There is a feature in MS48 which adds support to tag deployments.
The ec_deployments datasource should be able to filter deployments
by tags as well :)
@karencfv karencfv added the enhancement New feature or request label Nov 12, 2020
@karencfv karencfv added this to the v0.2.0 milestone Nov 12, 2020
@marclop marclop changed the title ec_deployments: FIlter by deployment tags ec_deployments: Filter by deployment tags Nov 30, 2020
@marclop marclop modified the milestones: v0.2.0, v0.1.0 Dec 18, 2020
@wandergeek
Copy link
Collaborator

Yes please! <3

This was referenced Feb 18, 2021
Closed
Merged
@neiljbrookes
Copy link
Contributor

@karencfv I still need to add "tags" to the filters for the ec_deployments (plural) datasource. The previous PR (#244) just added them to the ec_deployment (singular) datasource !

@neiljbrookes neiljbrookes reopened this Feb 25, 2021
@neiljbrookes neiljbrookes mentioned this issue Feb 25, 2021
Merged
10 tasks
@karencfv
Copy link
Contributor Author

karencfv commented Mar 1, 2021

😄 @neiljbrookes

Looks like this issue was automatically closed by GH because of this comment in the other PR's description:
Screen Shot 2021-03-01 at 1 14 30 PM

We should use Related: next time if we don't want to close the issue on merge.

Also, do you mind assigning this PR to yourself if you're going to work on it? This guarantees that no one else grabs it :)

@neiljbrookes neiljbrookes self-assigned this Mar 1, 2021
@neiljbrookes
Copy link
Contributor

@karencfv Excuse my poor GitHub ettiqutte !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neiljbrookes neiljbrookes

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.1.0
4 participants
@wandergeek @neiljbrookes @marclop @karencfv