Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] 7.14.0 Release Notes #811

Merged
merged 30 commits into from
Aug 2, 2021
Merged

[DOCS] 7.14.0 Release Notes #811

merged 30 commits into from
Aug 2, 2021

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Jul 15, 2021

Addresses #792.

Preview here.

@nastasha-solomon
Copy link
Contributor Author

nastasha-solomon commented Jul 26, 2021

@jmikell821 I've removed the following PRs that are not Security PRs but were pulled in by the release notes tool:

  • Adds support for fingerprint processor (#100541).
  • Remove the external "Launch App Search" button (#100815).
  • Updates APM index pattern (#104344).
  • Adds media_type to set processor (#101035).
  • Adds extract_device_type to user agent processor (#100986).
  • Adds support for IP type in convert processor (#100531).
  • Heatmap / Swim lane integration (#97978).
  • Updates help text for common repository settings (#97652).
  • Collects all documents that fail to transform before stopping the migration (#96986).
  • Provides guidance of "Custom" allocation behavior in ILM (#96111).
  • Fixes remote clusters details flyout for long strings (#105592).
  • Fixes some hardcoded translations on Dashboard & Discover (#105555).
  • Fixes of the ja-JP.json not found error (#105023).
  • Remove default value for error_distance param (#102222).
  • Fixes default paramenter for ignore_missing in csv processor (#100316).
  • Fixes assignment v comparison and null type check in metrics detail page (#95102).

@jmikell821 jmikell821 requested review from joepeeples, a team and jmikell821 July 29, 2021 19:20
Copy link
Contributor

@dplumlee dplumlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on the bugs section, i didn't work too much on the features this release

@cnasikas
Copy link
Member

Hi @nastasha-solomon!

I am not familiar with the release notes 🙂 so sorry if I am mistaken. I have some questions:

  1. Why the Swimlane connector is on the Bug & Enhancements category? Is it not consider a feature?
  2. Why Cases privileges (RBAC) are not part of the list?

@nastasha-solomon
Copy link
Contributor Author

Hey @cnasikas, not a problem, and thanks for reviewing these! The Swimlane PR that was flagged for release notes had the release_note:enhancement label, hence its current placement in the 7.14 draft. I can move it to the features section if that's a more appropriate place for it to go though.

To address your second question, our release notes tool didn't pull in any PRs for the RBAC for Cases feature. I did some quick digging to see where that PR might be and found elastic/kibana#95058. If this is the PR that should be release-noted for 7.14, it might've gotten overlooked by our tool because--although it has the appropriate team labels--the release notes label (release_note:plugin_api_changes) falls outside of the scope of release notes labels our tool looks for. AFAIK, our release notes tool only pulls in PRs that have specific Security team labels and release note labels for bugs, features, enhancements, deprecations, and breaking changes.

@jonathan-buttner
Copy link
Contributor

Ah thanks for the heads up about the labels @nastasha-solomon

@cnasikas
Copy link
Member

Thanks @nastasha-solomon for explaining the release note labels. It is difficult for me to understand which labels should I use every time.

About the Swimlane connector, I think is more appropriate to be on the Feature section as it is a new feature.

You are right about the RBAC. This is the right PR and we should put another release label also. I think RBAC should also be in the feature section because the user can create a role and set specific privileges (all/write/none) for Cases. It is a new capability that was not possible prior to 7.14. What do you think?

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small line-edits, looks good!

docs/release-notes.asciidoc Outdated Show resolved Hide resolved
docs/release-notes.asciidoc Outdated Show resolved Hide resolved
docs/release-notes.asciidoc Outdated Show resolved Hide resolved
docs/release-notes.asciidoc Show resolved Hide resolved
docs/release-notes.asciidoc Outdated Show resolved Hide resolved
@peluja1012
Copy link
Contributor

Hi @nastasha-solomon, could we please add a "Known Issue" for this bug. We could say something like:

When upgrading from 7.8 to 7.14, rule execution and activation/deactivation of rules could fail (elastic/kibana#106233). To work around this issue you can use the PATCH rule API to update each rule that presents this problem. The payload of the PATCH call should set the author field to [] as follows. After the author field is populated the rule will start to work as expected.

PATCH <kibana host>:<port>/api/detection_engine/rules
{
  "id": <id-value-of-rule>",
  "author": []
}

Copy link
Contributor

@peluja1012 peluja1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for including the last minute "known issue"!

@nastasha-solomon nastasha-solomon merged commit 2487908 into master Aug 2, 2021
@nastasha-solomon nastasha-solomon deleted the issue-792-7.14.0-rn branch August 2, 2021 22:27
nastasha-solomon added a commit to nastasha-solomon/security-docs that referenced this pull request Aug 2, 2021
* First draft.

* Added features and enhancements.

* Removed duplicates.

* Saving changes.

* Saving updates.

* Saving changes.

* Saving updates.

* Saving changes.

* Fixing broken link and adding more changes.

* Saving updates.

* Saving changes.

* Adding two known issues.

* Changes to case PRs.

* Added Joe's comments.

* Fixed typo.

* Saving updates.

* New styling for PATCH API.

* Added Joe

* Fixed punctuation errors.
nastasha-solomon added a commit to nastasha-solomon/security-docs that referenced this pull request Aug 2, 2021
* First draft.

* Added features and enhancements.

* Removed duplicates.

* Saving changes.

* Saving updates.

* Saving changes.

* Saving updates.

* Saving changes.

* Fixing broken link and adding more changes.

* Saving updates.

* Saving changes.

* Adding two known issues.

* Changes to case PRs.

* Added Joe's comments.

* Fixed typo.

* Saving updates.

* New styling for PATCH API.

* Added Joe

* Fixed punctuation errors.
nastasha-solomon added a commit that referenced this pull request Aug 2, 2021
* First draft.

* Added features and enhancements.

* Removed duplicates.

* Saving changes.

* Saving updates.

* Saving changes.

* Saving updates.

* Saving changes.

* Fixing broken link and adding more changes.

* Saving updates.

* Saving changes.

* Adding two known issues.

* Changes to case PRs.

* Added Joe's comments.

* Fixed typo.

* Saving updates.

* New styling for PATCH API.

* Added Joe

* Fixed punctuation errors.
nastasha-solomon added a commit that referenced this pull request Aug 2, 2021
* First draft.

* Added features and enhancements.

* Removed duplicates.

* Saving changes.

* Saving updates.

* Saving changes.

* Saving updates.

* Saving changes.

* Fixing broken link and adding more changes.

* Saving updates.

* Saving changes.

* Adding two known issues.

* Changes to case PRs.

* Added Joe's comments.

* Fixed typo.

* Saving updates.

* New styling for PATCH API.

* Added Joe

* Fixed punctuation errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants