Update tracker params #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yansavitski
force-pushed
the
#4405-update-tracker
branch
from
bb9e862 to
7c6c4c8
Compare
joemcelroy
reviewed
May 2, 2023
joemcelroy
reviewed
May 2, 2023
| items: [], | ||
| total_results: event.totalResults | ||
| }, | ||
| search_application: "search-ui" |
There was a problem hiding this comment.
exclude search_application from the event. This is reserved for the name of the search application, not the client name. This can added later on once we clarify the status of search_application
joemcelroy
reviewed
May 2, 2023
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "jsx": "react", | |||
There was a problem hiding this comment.
do you know what triggered this? AFAIK, we dont and shouldn't have any JSX in this connector
There was a problem hiding this comment.
Accidentally added it
joemcelroy
reviewed
May 2, 2023
yansavitski
force-pushed
the
#4405-update-tracker
branch
from
75ea130 to
726ab7a
Compare
yansavitski
force-pushed
the
#4405-update-tracker
branch
from
5c9d95b to
855ce9a
Compare
joemcelroy
reviewed
May 4, 2023
yansavitski
force-pushed
the
#4405-update-tracker
branch
from
41fa2fd to
c185c90
Compare
joemcelroy
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Search UI tracker to use the new tracker methods.
TODO: Add document index, results items