Support multiple sort options #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonStoltz
suggested changes
Oct 26, 2021
packages/search-ui-app-search-connector/src/__tests__/requestAdapters.test.js
Outdated
Show resolved
Hide resolved
packages/react-search-ui/src/containers/__tests__/Sorting.test.js
Outdated
Show resolved
Hide resolved
packages/react-search-ui/src/containers/__tests__/Sorting.test.js
Outdated
Show resolved
Hide resolved
packages/react-search-ui/src/containers/__tests__/Sorting.test.js
Outdated
Show resolved
Hide resolved
packages/react-search-ui/src/containers/__tests__/Sorting.test.js
Outdated
Show resolved
Hide resolved
JasonStoltz
reviewed
Nov 3, 2021
…dapters.test.js Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
|
Hey, how are we getting on with the requested changes? |
|
I was waiting on a response on two comments, but they're not critical, so I may just merge this and address separately. |
That would be awesome, thanks for spending time on this! |
|
@JasonStoltz will address comments today :) |
Thank @ckeboss, not me! |
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
JasonStoltz
approved these changes
Nov 15, 2021
|
@martynball @ckeboss Published in 1.8.0 |
|
@ckeboss Thanks for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes as requested by @JasonStoltz #586