Removed 'swiftype_' headers #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonStoltz
force-pushed
the
remove-swiftype-headers
branch
from
0c90fcf to
2a05baf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the 'swiftype_' prefixed headers on API calls for the App Search and Site Search connectors.
These were originally introduced when App Search and Site Search were purely SaaS products, for our own analytical purpose. These are no longer used or needed by us (Elastic).
Since this causes complications in the build as seen in #539, I'd rather just remove them entirely.
Since these headers were for internal use, I don't consider this a breaking change.
List of changes
Removed
x-swiftype-integrationandx-swiftype-integration-versionheaders.Associated Github Issues
Fixes #539
Alternative to #572