-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix boolean facet check status #491
Conversation
Make sure that checkbox shows checked/unchecked depending on value of `isSelected` in case filter value is set via function call rather than via clicking the checkbox.
💚 CLA has been signed |
I'll review this today, please sign the CLA. |
CI is botched right now, don't worry about the failure. |
This is great and I'd love to merge this in and publish it, I just need 2 things:
Thanks! |
I will take a look at the test. |
Cool, it's super easy to do. |
Thanks so much for this contribution. It is now available in 1.4.0-rc.3 |
#482 Description
Make sure that checkbox shows checked/unchecked depending on value of
isSelected
in case filter value is set via function call rather than via clicking the checkbox.Associated Github Issues
#490