Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boolean facet check status #491

Merged
merged 3 commits into from
May 11, 2020
Merged

Conversation

jasontk19
Copy link
Contributor

#482 Description
Make sure that checkbox shows checked/unchecked depending on value of isSelected in case filter value is set via function call rather than via clicking the checkbox.

Associated Github Issues

#490

Make sure that checkbox shows checked/unchecked depending on value of `isSelected` in case filter value is set via function call rather than via clicking the checkbox.
@cla-checker-service
Copy link

cla-checker-service bot commented May 6, 2020

💚 CLA has been signed

@JasonStoltz
Copy link
Member

I'll review this today, please sign the CLA.

@JasonStoltz
Copy link
Member

CI is botched right now, don't worry about the failure.

@JasonStoltz
Copy link
Member

This is great and I'd love to merge this in and publish it, I just need 2 things:

  1. I need you to sign the CLA. Are you able to do this?

  2. The snapshot test for BooleanFacet is broken. Please run the following command to fix it, and commit the result.

cd packages/react-search-ui-views
npx jest -u

Thanks!

@jasontk19
Copy link
Contributor Author

jasontk19 commented May 8, 2020

@JasonStoltz I signed the CLA but not sure what next steps are to get this to be recognized by the CLA checker? Looks like it's all set now.

I will take a look at the test.

@JasonStoltz
Copy link
Member

JasonStoltz commented May 11, 2020

Cool, it's super easy to do. I'll submit a PR to your branch, if you just merge it we should be good. I pushed changes up to your branch.

@JasonStoltz JasonStoltz added this to the 1.4 milestone May 11, 2020
@JasonStoltz JasonStoltz merged commit d4e77db into elastic:master May 11, 2020
@JasonStoltz
Copy link
Member

Thanks so much for this contribution. It is now available in 1.4.0-rc.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants