Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection behind a proxy fails. has_internet_connection() returns False #245

Closed
Erni opened this issue Mar 2, 2017 · 4 comments
Closed
Labels
bug Something's wrong
Milestone

Comments

@Erni
Copy link

Erni commented Mar 2, 2017

I´ve been trying to use Rally from behind a proxy in a clean installation but it doesn´t work because it "thinks" there is no internet connection.
Even if Rally gets the proxy url when the http_proxy environment variable is available, the function has_internet_connection() in esrally/utils/net.py does not check this. It tries to open a socket to www.github.com without considering the proxy, thus failing and returning False. Then Rally works in offline mode, which is not what it should.

@danielmitterdorfer
Copy link
Member

Thanks for the report. That's a good point. The connection check should also go through the proxy if there is one.

@danielmitterdorfer danielmitterdorfer added the bug Something's wrong label Mar 2, 2017
@danielmitterdorfer danielmitterdorfer added this to the 0.5.2 milestone Mar 2, 2017
@Erni
Copy link
Author

Erni commented Mar 2, 2017

Great. Thanks for quick response and fix :)

@danielmitterdorfer
Copy link
Member

@Erni I've just released Rally 0.5.2 (see also https://discuss.elastic.co/t/rally-0-5-2-released/77300) so you might want to upgrade.

@Erni
Copy link
Author

Erni commented Mar 3, 2017

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something's wrong
Projects
None yet
Development

No branches or pull requests

2 participants