Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scroll support in search operation #1215

Open
DJRickyB opened this issue Mar 18, 2021 · 0 comments
Open

Remove scroll support in search operation #1215

DJRickyB opened this issue Mar 18, 2021 · 0 comments
Assignees
@DJRickyB @michaelbaamonde
Labels
breaking Non-backwards compatible change cleanup Linter changes, reformatting, removal of unused code etc. good first issue Small, contained changes that are good for newcomers help wanted We'd be happy about a community contribution
Milestone
Backlog

Comments

@DJRickyB
Copy link
Contributor

As of #1190, scroll-search is its own operation, and as such we should remove scroll support (aka the usage of the "pages" parameter) for search operations.
@DJRickyB DJRickyB added breaking Non-backwards compatible change cleanup Linter changes, reformatting, removal of unused code etc. good first issue Small, contained changes that are good for newcomers labels Mar 18, 2021
@DJRickyB DJRickyB added this to the Backlog milestone Mar 18, 2021
@DJRickyB DJRickyB self-assigned this Mar 18, 2021
@DJRickyB DJRickyB mentioned this issue Mar 18, 2021
Merged
@michaelbaamonde michaelbaamonde self-assigned this Oct 20, 2021
This was referenced Oct 20, 2021
Open
Merged
This was referenced Nov 23, 2021
Closed
Closed
@pquentin pquentin added the help wanted We'd be happy about a community contribution label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DJRickyB DJRickyB

@michaelbaamonde michaelbaamonde

Labels
breaking Non-backwards compatible change cleanup Linter changes, reformatting, removal of unused code etc. good first issue Small, contained changes that are good for newcomers help wanted We'd be happy about a community contribution
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@pquentin @DJRickyB @michaelbaamonde