-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add category-names to packages in search response / Add package-ids to category list in categories response #722
Comments
@joshdover this came up as a requirement for the unified integrations view in 7.16. Is this the right approach and is it realistic to get in 7.16? It might be good to check with the ecosystem team because I know they have limited capacity. If not, a workaround could be duplicating and hard-coding this data in Kibana. The disadvantage is that we'd have to maintain/sync this information in two places instead of one until this is available. |
Hi @thomasneirynck , I think that the reasonable option would be
@ruflin Do you remember why this property is missing? Is it only because of minimizing the response body?
I guess that we need to build the official roadmap for the ecosystem team, so cc @akshay-saraswat @jlind23 . I think we should be safe to deliver this in 7.16. |
thx @mtojek , adding it to |
@mtojek sounds great indeed, we will review during our meeting for the 7.16. 👍🏼 |
Let's first finalize #703 , then we can switch to this issue. |
EPR service does not expose an API to determine which categories a package belongs to, or vice versa, which packages belong to a list of categories.
e.g.
https://epr-snapshot.elastic.co/search
is missing acategories
-property for each packagee.g.
https://epr-snapshot.elastic.co/categories
is missing package-ids for each categoryThe absence of this link is a challenge when trying to build a facetted-browser that combines packages from multiple sources and has some deduping behavior going on based on package-overlap. Without knowing which epr-package belongs to which categroy (or vice versa), total category-counts cannot be calculated for all categories. For more context cf elastic/kibana#93084.
e.g. in this screen shot: facet-counts need to be based on packages of both EPR and other sources. These counts cannot be just additive, because sometimes EPR-packages will be replaced by multiple other packages (e.g. one EPR-package corresponding to 18 integrations, might be replaced by only 2 beats modules).
The work-around would be to send a search-request for each category (
search?category=foobar
). This introduces a significant performance hit and adds more code-cruft to clients. fwiw - already kibana needs to work-around this limitation by having to re-request all the packages each time a category is selected (Even though Kibana loads all packages by default first).Ideally, this can be added to the policy-level.
https://epr-snapshot.elastic.co/categories?include_policy_templates=true
will provides the relevant counts we want a user to see.The text was updated successfully, but these errors were encountered: