Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve package version conflicts when served from multiple paths #545

Closed
mtojek opened this issue Jun 24, 2020 · 2 comments
Closed

Resolve package version conflicts when served from multiple paths #545

mtojek opened this issue Jun 24, 2020 · 2 comments

Comments

@mtojek
Copy link
Contributor

mtojek commented Jun 24, 2020

The EPR supports multiple paths for packages. It may happen that two package, tagged with the same version, but with different content (e.g. integrations developer modified one of them to check a bugfix).

The goal of this task is to plan what is the expected behavior for EPR, e.g. warn/ignore package conflicts or first found served.

Then, implement it.

@ruflin
Copy link
Contributor

ruflin commented Jun 24, 2020

With elastic/package-storage#86 in mind, my proposal is that we go with first found, first served. Lets assume package foo:2.1.3 exists in production and snapshot. The one in production should be served as it was released and the one in snapshot should have a higher version number.

If we want to go one step further, we are going through all packages on startup for validation. There we could log a notice if we find the same version twice.

@ruflin
Copy link
Contributor

ruflin commented Aug 24, 2020

@mtojek Closing this as I think you implemented this.

@ruflin ruflin closed this as completed Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants