-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Add EUIDataGrid to surrounding documents #99447
Conversation
…ts-migration # Conflicts: # src/plugins/discover/public/application/angular/context/query_parameters/actions.test.ts # src/plugins/discover/public/application/components/context_error_message/context_error_message.test.tsx # src/plugins/discover/public/application/components/context_error_message/context_error_message.tsx
src/plugins/discover/public/application/components/context_app/context_app_legacy.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/context_app/context_app_legacy.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that it already works, first look, note that you need to disable sorting, since there is just one type of sorting in Context, that the user shouldn't be able to change
@elasticmachine merge upstream |
merge conflict between base and head |
…ange sorting, highlight anchor doc, rename legacy variables
columns, | ||
rows: allRowsLoaded && rows, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elasticmachine merge upstream |
Thanks for taking this on @dmitriynj b) Add a button that lets the user go straight to the page where the document is in. Think of it like when you're in a calendar app and you quickly want to go back to 'Today'. Something like this: |
@elasticmachine merge upstream |
This comment has been minimized.
This comment has been minimized.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
src/plugins/discover/public/application/components/discover_grid/discover_grid.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/context_app/context_app_legacy.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/context_app/context_app_legacy.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/discover_grid/discover_grid.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/helpers/use_data_grid_columns.ts
Show resolved
Hide resolved
...ns/discover/public/application/components/discover_grid/discover_grid_document_selection.tsx
Show resolved
Hide resolved
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, tested locally in Safari, Chrome, Firefox, MacOS, works as expected, great work! 👍
ah, one last thing , I think the title of this PR could be
since it doesn't change the default (currently), but adds it as additional doc table |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/management/index_management/indices·js.apis management index management indices list should list all the indices with the expected properties and data enrichersStandard Out
Stack Trace
Metrics [docs]Module Count
Async chunks
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @dmitriynj |
* [Discover] migrate remaining context files from js to ts * [Discover] get rid of any types * [Discover] replace constants with enums, update imports * [Discover] use unknown instead of any, correct types * [Discover] skip any type for tests * [Discover] add euiDataGrid view * [Discover] add support dataGrid columns, provide ability to do not change sorting, highlight anchor doc, rename legacy variables * [Discover] update context_legacy test and types * [Discover] update unit tests, add context header * [Discover] update unit and functional tests * [Discover] remove docTable from context test which uses new data grid * [Discover] update EsHitRecord type, use it for context app. add no pagination support * [Discover] resolve type error in test * [Discover] add disabling control columns option, change loading feedback * [Discover] clean up, update functional tests * [Discover] remove invalid translations * [Discover] support both no results found and loading feedback * [Discover] provide loading status for discover * [Discover] fix functional test * [Discover] add useDataGridColumns test, update by comments * [Discover] fix types Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
…101063) * [Discover] Add EUIDataGrid to surrounding documents (#99447) * [Discover] migrate remaining context files from js to ts * [Discover] get rid of any types * [Discover] replace constants with enums, update imports * [Discover] use unknown instead of any, correct types * [Discover] skip any type for tests * [Discover] add euiDataGrid view * [Discover] add support dataGrid columns, provide ability to do not change sorting, highlight anchor doc, rename legacy variables * [Discover] update context_legacy test and types * [Discover] update unit tests, add context header * [Discover] update unit and functional tests * [Discover] remove docTable from context test which uses new data grid * [Discover] update EsHitRecord type, use it for context app. add no pagination support * [Discover] resolve type error in test * [Discover] add disabling control columns option, change loading feedback * [Discover] clean up, update functional tests * [Discover] remove invalid translations * [Discover] support both no results found and loading feedback * [Discover] provide loading status for discover * [Discover] fix functional test * [Discover] add useDataGridColumns test, update by comments * [Discover] fix types Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * [Discover] fix data grid row header in firefox Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Closes #97126
Checklist
Delete any items that are not applicable to this PR.