Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Transaction duration histogram buckets without samples are clickable #98540

Merged
merged 4 commits into from
Apr 29, 2021
Merged

[APM] Transaction duration histogram buckets without samples are clickable #98540

merged 4 commits into from
Apr 29, 2021

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Apr 27, 2021 •
edited
Loading

closes #94684

Screen Shot 2021-04-28 at 09 48 05

@cauemarcondes cauemarcondes requested a review from a team as a code owner April 27, 2021 19:06
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Apr 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist
Copy link
Contributor

@cauemarcondes Thanks for adding the message. I should have provided guidance earlier, but can we make it so the message is displayed below the series label and value, similar to have what we show in the Instances distribution chart;

Screenshot 2021-04-28 at 11 29 01

So instead of the "click to filter by instance" we'd write the "No samples available" perhaps with an iInCircle icon instead of the filter icon.

formgeist
formgeist approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messaging is good - but left a small note about aligning with how we display small messages in the chart tooltips, perhaps we can make it consistent here as well.

@cauemarcondes cauemarcondes requested a review from a team April 28, 2021 16:55
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1587 1588 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.2MB 4.2MB +2.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes added auto-backport Deprecated - use backport:version if exact versions are needed v7.14.0 labels Apr 29, 2021
@cauemarcondes cauemarcondes merged commit d111c27 into elastic:master Apr 29, 2021
@cauemarcondes cauemarcondes deleted the apm-distribution-chart branch April 29, 2021 20:57
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 29, 2021
@cauemarcondes @kibanamachine
[APM] Transaction duration histogram buckets without samples are clic…
8413771 
…kable (elastic#98540)

* adding no samples label on distribution chart

* adding custom tooltip

* addressing PR comments
@kibanamachine kibanamachine mentioned this pull request Apr 29, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 29, 2021
@cauemarcondes @kibanamachine
[APM] Transaction duration histogram buckets without samples are clic…
5a56afb 
…kable (elastic#98540)

* adding no samples label on distribution chart

* adding custom tooltip

* addressing PR comments
@kibanamachine kibanamachine mentioned this pull request Apr 29, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 29, 2021
@kibanamachine @cauemarcondes
[APM] Transaction duration histogram buckets without samples are clic…
88ca0e0 
…kable (#98540) (#98839)

* adding no samples label on distribution chart

* adding custom tooltip

* addressing PR comments

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Apr 29, 2021
@kibanamachine @cauemarcondes
[APM] Transaction duration histogram buckets without samples are clic…
b95ae64 
…kable (#98540) (#98840)

* adding no samples label on distribution chart

* adding custom tooltip

* addressing PR comments

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
madirey pushed a commit to madirey/kibana that referenced this pull request May 11, 2021
@cauemarcondes @madirey
[APM] Transaction duration histogram buckets without samples are clic…
ba3243f 
…kable (elastic#98540)

* adding no samples label on distribution chart

* adding custom tooltip

* addressing PR comments
@smith
Copy link
Contributor

smith commented Jul 16, 2021

Tests OK. Tooltips without samples are not clickable (though it would be nice if we could make it cursor: default and not cursor: pointer.)

@smith smith added the apm:test-plan-done Pull request that was successfully tested during the test plan label Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

@formgeist formgeist formgeist approved these changes

@dgieselaar dgieselaar Awaiting requested review from dgieselaar

Assignees
No one assigned
Labels
apm:test-plan-7.14.0 apm:test-plan-done Pull request that was successfully tested during the test plan auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:APM All issues that need APM UI Team support v7.13.0 v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Transaction duration histogram buckets without samples are clickable
7 participants
@cauemarcondes @elasticmachine @formgeist @kibanamachine @smith @ogupte @sorenlouv