[ML] Refactor imports using 'elasticsearch' to '@elastic/elasticsearch'. Extend 'isPopulatedOjbect()'. #95651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
:ml
v7.13.0
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
darnautov
reviewed
Mar 30, 2021
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @walterra |
walterra
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 1, 2021
…h'. Extend 'isPopulatedOjbect()'. (elastic#95651) - Gets rid of imports from 'elasticsearch' and replaces them with '@elastic/elasticsearch'. - Extends isPopulatedObject() to allow an optional array of attributes to check if they exist. Allows us to get rid of the manual and inconsistent usages of hasOwnProperty().
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Apr 1, 2021
…h'. Extend 'isPopulatedOjbect()'. (elastic#95651) - Gets rid of imports from 'elasticsearch' and replaces them with '@elastic/elasticsearch'. - Extends isPopulatedObject() to allow an optional array of attributes to check if they exist. Allows us to get rid of the manual and inconsistent usages of hasOwnProperty().
walterra
added a commit
that referenced
this pull request
Apr 1, 2021
…csearch'. Extend 'isPopulatedOjbect()'. (#95651) (#96058) * [ML] Refactor imports using 'elasticsearch' to '@elastic/elasticsearch'. Extend 'isPopulatedOjbect()'. (#95651) - Gets rid of imports from 'elasticsearch' and replaces them with '@elastic/elasticsearch'. - Extends isPopulatedObject() to allow an optional array of attributes to check if they exist. Allows us to get rid of the manual and inconsistent usages of hasOwnProperty(). * [ML] Fix import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
'elasticsearch'and replaces them with'@elastic/elasticsearch'.isPopulatedObject()to allow an optional array of attributes to check if they exist. Allows us to get rid of the manual and inconsistend usages ofhasOwnProperty().Checklist