[ALERTING][CONNECTOR] Swimlane #95109

XavierM · 2021-03-22T21:18:24Z

Summary

Adding swimlane as connector inside of selection of kibana's connectors

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…-connector

YulNaumenko

Overall code looks good. I've tried to test how it works and have a couple of comments:

When opened create connector I was not able to get docs how to Provide a Swimlane API Token - I assume that the docs will come in the next PR?
When I've entered the available fields from the step 1 I clicked Save, but didn't get any validation feedback that the step 2 for mapping the fields is not completed. I think it should be more user friendly if we have the validation message in addition to image with steps flow.

afharo

Schema changes LGTM.

FYI: @elastic/infra-telemetry

stephmilovic · 2021-04-29T20:59:00Z

@elasticmachine merge upstream

kibanamachine · 2021-04-29T20:59:01Z

user doesn't have permission to update head repository

XavierM · 2021-04-29T21:00:47Z

@elasticmachine merge upstream

kibanamachine · 2021-04-29T21:00:49Z

user doesn't have permission to update head repository

…-connector

kibanamachine · 2021-04-29T21:23:02Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: b76f426
Storybooks Preview
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/swimlane.swimlane connector validation connector validation succeeds when connector config is valid

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 7

  Object {
+   "config": Object {
      "errors": Object {
-     "apiToken": Array [],
        "apiUrl": Array [],
        "appId": Array [],
        "mappings": Array [],
+     },
+   },
+   "secrets": Object {
+     "errors": Object {
+       "apiToken": Array [],
+     },
    },
  }
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/swimlane/swimlane.test.tsx:50:64)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/swimlane.swimlane connector validation connector validation fails when connector config is not valid

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 7

  Object {
+   "config": Object {
      "errors": Object {
-     "apiToken": Array [],
        "apiUrl": Array [],
        "appId": Array [],
        "mappings": Array [
          "Field mappings are required.",
        ],
+     },
+   },
+   "secrets": Object {
+     "errors": Object {
+       "apiToken": Array [],
+     },
    },
  }
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types/swimlane/swimlane.test.tsx:86:64)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Kibana Pipeline / general / X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/basic/tests/actions/builtin_action_types/swimlane·ts.alerting api integration basic license Actions swimlane action should return 403 when creating a swimlane action

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: alerting api integration basic license
[00:00:00]           └-> "before all" hook in "alerting api integration basic license"
[00:00:00]           └-: Actions
[00:00:00]             └-> "before all" hook in "Actions"
[00:00:01]             └-: swimlane action
[00:00:01]               └-> "before all" hook for "should return 403 when creating a swimlane action"
[00:00:01]               └-> should return 403 when creating a swimlane action
[00:00:01]                 └-> "before each" hook: global before each for "should return 403 when creating a swimlane action"
[00:00:01]                 └- ✖ fail: alerting api integration basic license Actions swimlane action should return 403 when creating a swimlane action
[00:00:01]                 │      Error: expected 403 "Forbidden", got 400 "Bad Request"
[00:00:01]                 │       at Test._assertStatus (/dev/shm/workspace/parallel/16/kibana/node_modules/supertest/lib/test.js:268:12)
[00:00:01]                 │       at Test._assertFunction (/dev/shm/workspace/parallel/16/kibana/node_modules/supertest/lib/test.js:283:11)
[00:00:01]                 │       at Test.assert (/dev/shm/workspace/parallel/16/kibana/node_modules/supertest/lib/test.js:173:18)
[00:00:01]                 │       at assert (/dev/shm/workspace/parallel/16/kibana/node_modules/supertest/lib/test.js:131:12)
[00:00:01]                 │       at /dev/shm/workspace/parallel/16/kibana/node_modules/supertest/lib/test.js:128:5
[00:00:01]                 │       at Test.Request.callback (/dev/shm/workspace/parallel/16/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:718:3)
[00:00:01]                 │       at /dev/shm/workspace/parallel/16/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:906:18
[00:00:01]                 │       at IncomingMessage.<anonymous> (/dev/shm/workspace/parallel/16/kibana/node_modules/supertest/node_modules/superagent/lib/node/parsers/json.js:19:7)
[00:00:01]                 │       at endReadableNT (internal/streams/readable.js:1327:12)
[00:00:01]                 │       at processTicksAndRejections (internal/process/task_queues.js:80:21)
[00:00:01]                 │ 
[00:00:01]                 │

Stack Trace

Error: expected 403 "Forbidden", got 400 "Bad Request"
    at Test._assertStatus (/dev/shm/workspace/parallel/16/kibana/node_modules/supertest/lib/test.js:268:12)
    at Test._assertFunction (/dev/shm/workspace/parallel/16/kibana/node_modules/supertest/lib/test.js:283:11)
    at Test.assert (/dev/shm/workspace/parallel/16/kibana/node_modules/supertest/lib/test.js:173:18)
    at assert (/dev/shm/workspace/parallel/16/kibana/node_modules/supertest/lib/test.js:131:12)
    at /dev/shm/workspace/parallel/16/kibana/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/dev/shm/workspace/parallel/16/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:718:3)
    at /dev/shm/workspace/parallel/16/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:906:18
    at IncomingMessage.<anonymous> (/dev/shm/workspace/parallel/16/kibana/node_modules/supertest/node_modules/superagent/lib/node/parsers/json.js:19:7)
    at endReadableNT (internal/streams/readable.js:1327:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)

and 2 more failures, only showing the first 3.

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`triggersActionsUi`	365	375	+10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	1.5MB	1.5MB	+37.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	160.0KB	160.0KB	+12.0B
`triggersActionsUi`	106.1KB	117.9KB	+11.8KB
total			+11.8KB

Unknown metric groups

async chunk count

id	before	after	diff
`triggersActionsUi`	41	44	+3

History

💔 Build #114429 failed 3bb04dc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stephmilovic · 2021-05-13T19:07:34Z

@elasticmachine merge upstream

kibanamachine · 2021-05-13T19:07:35Z

user doesn't have permission to update head repository

joshswimlane and others added 3 commits March 22, 2021 13:04

Adding swimlane connector

85fe84e

Merge branch 'master' of github.com:elastic/kibana into field_mapping…

cf2eb78

…-connector

clean up + rm rejectUnauthorized

3bb04dc

XavierM requested review from a team as code owners March 22, 2021 21:18

YulNaumenko reviewed Mar 23, 2021

View reviewed changes

afharo approved these changes Mar 23, 2021

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into field_mapping…

b76f426

…-connector

stephmilovic mentioned this pull request May 13, 2021

[Security Solution] [Cases] Swimlane Connector for Cases #100086

Merged

6 tasks

XavierM closed this Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ALERTING][CONNECTOR] Swimlane #95109

[ALERTING][CONNECTOR] Swimlane #95109

XavierM commented Mar 22, 2021

YulNaumenko left a comment

afharo left a comment

stephmilovic commented Apr 29, 2021

kibanamachine commented Apr 29, 2021

XavierM commented Apr 29, 2021

kibanamachine commented Apr 29, 2021

kibanamachine commented Apr 29, 2021 •

edited

Loading

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

async chunk count

stephmilovic commented May 13, 2021

kibanamachine commented May 13, 2021

[ALERTING][CONNECTOR] Swimlane #95109

[ALERTING][CONNECTOR] Swimlane #95109

Conversation

XavierM commented Mar 22, 2021

Summary

Checklist

YulNaumenko left a comment

Choose a reason for hiding this comment

afharo left a comment

Choose a reason for hiding this comment

stephmilovic commented Apr 29, 2021

kibanamachine commented Apr 29, 2021

XavierM commented Apr 29, 2021

kibanamachine commented Apr 29, 2021

kibanamachine commented Apr 29, 2021 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

History

stephmilovic commented May 13, 2021

kibanamachine commented May 13, 2021

kibanamachine commented Apr 29, 2021 •

edited

Loading