[ML] Functional tests - fix calendar "apply to all jobs" service method #83071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheyos
added
:ml
test_ui_functional
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
|
Checking test stability in a cloud flaky test runner job ... no failure in 40 runs ✔️ |
qn895
approved these changes
Nov 10, 2020
|
LGTM |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Nov 10, 2020
…od (elastic#83071) This PR fixes the calendar service method assertApplyToAllJobsSwitchCheckState by adding a missing await.
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Nov 10, 2020
…od (elastic#83071) This PR fixes the calendar service method assertApplyToAllJobsSwitchCheckState by adding a missing await.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the calendar service method
assertApplyToAllJobsSwitchCheckStateby adding a missingawait.Details
This caused a rare (~ 1 out of 30) test failure, especially on cloud, when the switch was clicked too early and due to the missing
awaittheretryintoggleApplyToAllJobsSwitchhasn't been triggered correctly.I've reproduce this issue on master in a cloud flaky test runner job.