Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Remove background from lens embeddable #83061

Merged
merged 3 commits into from
Nov 12, 2020
Merged

[Lens] Remove background from lens embeddable #83061

merged 3 commits into from
Nov 12, 2020

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Nov 10, 2020 •
edited
Loading

Summary

Fixes #82293
I based my solution on TSVB. In TSVB a user has the option to modify the background color. If the color is not defined, property backgroundColor stays undefined: (src/plugins/vis_type_timeseries/public/application/visualizations/views/timeseries/index.js):

 theme={[
          hasBarChart
            ? {}
            : {
                crosshair: {
                  band: {
                    fill: '#F00',
                  },
                },
              },
          {
            background: {
              color: backgroundColor,
            },
          },
        ]}

I also simplified labels styling logic a little.

  • tested in canvas & dashboard in dark and light mode

@mbondyra mbondyra added 7.11.0 Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 labels Nov 10, 2020
@mbondyra mbondyra marked this pull request as ready for review November 10, 2020 15:00
@mbondyra mbondyra requested a review from a team November 10, 2020 15:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 910.3KB 911.3KB +1.0KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jen-huang jen-huang added v7.11.0 and removed 7.11.0 labels Nov 10, 2020
flash1293
flash1293 approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM, no background for all lens visualization types

@mbondyra mbondyra merged commit 268bd09 into elastic:master Nov 12, 2020
@mbondyra mbondyra deleted the lens/remove_bg_from_canvas branch November 12, 2020 08:09
@mbondyra mbondyra mentioned this pull request Nov 12, 2020
Merged
mbondyra added a commit to mbondyra/kibana that referenced this pull request Nov 12, 2020
@mbondyra
[Lens] Remove background from lens embeddable (elastic#83061)
968f563
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 12, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master' into alerts/stack-aler…
90bcf6d 
…ts-public

* upstream/master: (57 commits)
  Remove unused asciidoc file (elastic#83228)
  [Lens] Remove background from lens embeddable (elastic#83061)
  [Discover] Unskip flaky tests based on discover fixture index pattern (elastic#82991)
  Removing unnecessary trailing slash in CODEOWNERS
  Trying to fix CODEOWNERS again, where was a non-existent team prior (elastic#83236)
  Trying to fix CODEOWERS, missing a starting slash (elastic#83233)
  skip flaky suite (elastic#83231)
  Add enzyme rerender test helper (elastic#83208)
  Move Elasticsearch type definitions out of APM (elastic#83081)
  [ts/checkTsProjects] produce a more useful error message (elastic#83209)
  [kbnClient] retry updating config if necessary (elastic#83205)
  I accidentally removed this line in a recent PR (elastic#83201)
  Don't make the caller do work the function can do (elastic#83180)
  [App Search] Update EngineRouter & EngineNav to use EngineLogic (elastic#83138)
  [Workplace Search] Add routes for Sources (elastic#83125)
  Update logstash pipeline management to use system index APIs (elastic#80405)
  [ML] Replace EuiBasicTable with EuiInMemoryTable (elastic#83057)
  [Metrics UI] Add basic interaction and shell for node details overlay (elastic#82013)
  [App Search] Added the log retention confirmation modal to the Settings page (elastic#83009)
  [docs] Fix create map title in import geospatial page (elastic#83172)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 12, 2020
@gmmorris
Merge remote-tracking branch 'origin/alerts/stack-alerts-public' into…
34b2c71 
… alerts/action-groups-as-conditions

* origin/alerts/stack-alerts-public: (91 commits)
  removed import from plugin code as it causes FTR to fail
  [Advanced Settings] Introducing telemetry (elastic#82860)
  [alerts] add executionStatus to event log doc for action execute (elastic#82401)
  Add additional sources routes (elastic#83227)
  [ML] Persisted URL state for the "Anomaly detection jobs" page (elastic#83149)
  [Logs UI] Add pagination to the log stream shared component (elastic#81193)
  [Index Management] Add an index template link to data stream details (elastic#82592)
  Add maps_oss folder to code_owners (elastic#83204)
  fix truncation issue (elastic#83000)
  [Ingest Manger] Move asset getters out of registry (elastic#83214)
  make defaulted field non maybe
  Remove unused asciidoc file (elastic#83228)
  [Lens] Remove background from lens embeddable (elastic#83061)
  [Discover] Unskip flaky tests based on discover fixture index pattern (elastic#82991)
  Removing unnecessary trailing slash in CODEOWNERS
  Trying to fix CODEOWNERS again, where was a non-existent team prior (elastic#83236)
  Trying to fix CODEOWERS, missing a starting slash (elastic#83233)
  skip flaky suite (elastic#83231)
  Add enzyme rerender test helper (elastic#83208)
  Move Elasticsearch type definitions out of APM (elastic#83081)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 16, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@wylieconlon wylieconlon mentioned this pull request Nov 18, 2020
Closed
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 20, 2020
mbondyra added a commit that referenced this pull request Nov 20, 2020
@mbondyra @kibanamachine
[Lens] Remove background from lens embeddable (#83061) (#83251)
5e7e303 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@dej611 dej611 mentioned this pull request Nov 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Embeddable includes White Background When Added to Canvas Workpad
5 participants
@mbondyra @elasticmachine @kibanamachine @flash1293 @jen-huang