From 05da04a73880cf76d8e4e03298c418c13eda4e5d Mon Sep 17 00:00:00 2001 From: Mike Cote Date: Tue, 27 Oct 2020 16:07:54 -0400 Subject: [PATCH 01/18] Initial attempt at adding descriptions to alert types --- .../alerting/register_apm_alerts.ts | 25 +++++++++++++++++++ .../infra/public/alerting/inventory/index.ts | 3 +++ .../log_threshold/log_threshold_alert_type.ts | 3 +++ .../public/alerting/metric_threshold/index.ts | 3 +++ .../cpu_usage_alert/cpu_usage_alert.tsx | 1 + .../public/alerts/disk_usage_alert/index.tsx | 1 + .../alerts/legacy_alert/legacy_alert.tsx | 1 + .../alerts/memory_usage_alert/index.tsx | 1 + .../missing_monitoring_data_alert.tsx | 1 + .../monitoring/server/alerts/base_alert.ts | 1 + .../server/alerts/cluster_health_alert.ts | 3 +++ .../server/alerts/cpu_usage_alert.ts | 3 +++ .../server/alerts/disk_usage_alert.ts | 7 ++++++ .../elasticsearch_version_mismatch_alert.ts | 6 +++++ .../alerts/kibana_version_mismatch_alert.ts | 3 +++ .../server/alerts/license_expiration_alert.ts | 3 +++ .../alerts/logstash_version_mismatch_alert.ts | 6 +++++ .../server/alerts/memory_usage_alert.ts | 7 ++++++ .../alerts/missing_monitoring_data_alert.ts | 3 +++ .../server/alerts/nodes_changed_alert.ts | 3 +++ .../geo_threshold/index.ts | 3 +++ .../builtin_alert_types/threshold/index.ts | 8 +++++- .../sections/alert_form/alert_add.test.tsx | 1 + .../sections/alert_form/alert_edit.test.tsx | 1 + .../sections/alert_form/alert_form.test.tsx | 4 +++ .../components/alerts_list.test.tsx | 1 + .../public/application/type_registry.test.ts | 1 + .../triggers_actions_ui/public/types.ts | 1 + x-pack/plugins/uptime/common/translations.ts | 3 +++ .../lib/alert_types/duration_anomaly.tsx | 3 ++- .../public/lib/alert_types/monitor_status.tsx | 3 ++- .../uptime/public/lib/alert_types/tls.tsx | 3 ++- .../public/lib/alert_types/translations.ts | 6 +++++ .../fixtures/plugins/alerts/public/plugin.ts | 2 ++ 34 files changed, 120 insertions(+), 4 deletions(-) diff --git a/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts b/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts index 7995b1d381700..63d43ea2ebdd9 100644 --- a/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts +++ b/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts @@ -17,6 +17,10 @@ export function registerApmAlerts( name: i18n.translate('xpack.apm.alertTypes.errorCount', { defaultMessage: 'Error count threshold', }), + description: i18n.translate('xpack.apm.alertTypes.errorCount.description', { + defaultMessage: + 'Alert when the number of errors in a service exceeds a defined threshold.', + }), iconClass: 'bell', alertParamsExpression: lazy(() => import('./ErrorCountAlertTrigger')), validate: () => ({ @@ -41,6 +45,13 @@ export function registerApmAlerts( name: i18n.translate('xpack.apm.alertTypes.transactionDuration', { defaultMessage: 'Transaction duration threshold', }), + description: i18n.translate( + 'xpack.apm.alertTypes.transactionDuration.description', + { + defaultMessage: + 'Alert when the duration of a specific transaction type in a service exceeds a defined threshold.', + } + ), iconClass: 'bell', alertParamsExpression: lazy( () => import('./TransactionDurationAlertTrigger') @@ -68,6 +79,13 @@ export function registerApmAlerts( name: i18n.translate('xpack.apm.alertTypes.transactionErrorRate', { defaultMessage: 'Transaction error rate threshold', }), + description: i18n.translate( + 'xpack.apm.alertTypes.transactionErrorRate.description', + { + defaultMessage: + 'Alert when the rate of a specific transaction error in a service exceeds a defined threshold.', + } + ), iconClass: 'bell', alertParamsExpression: lazy( () => import('./TransactionErrorRateAlertTrigger') @@ -95,6 +113,13 @@ export function registerApmAlerts( name: i18n.translate('xpack.apm.alertTypes.transactionDurationAnomaly', { defaultMessage: 'Transaction duration anomaly', }), + description: i18n.translate( + 'xpack.apm.alertTypes.transactionDurationAnomaly.description', + { + defaultMessage: + 'Alert when the duration of a specific transaction is considered anomalous.', + } + ), iconClass: 'bell', alertParamsExpression: lazy( () => import('./TransactionDurationAnomalyAlertTrigger') diff --git a/x-pack/plugins/infra/public/alerting/inventory/index.ts b/x-pack/plugins/infra/public/alerting/inventory/index.ts index b5f6e17cc2a13..b49465db05135 100644 --- a/x-pack/plugins/infra/public/alerting/inventory/index.ts +++ b/x-pack/plugins/infra/public/alerting/inventory/index.ts @@ -17,6 +17,9 @@ export function createInventoryMetricAlertType(): AlertTypeModel { name: i18n.translate('xpack.infra.metrics.inventory.alertFlyout.alertName', { defaultMessage: 'Inventory', }), + description: i18n.translate('xpack.infra.metrics.inventory.alertFlyout.alertDescription', { + defaultMessage: 'Alert when the inventory exceeds a defined threshold.', + }), iconClass: 'bell', alertParamsExpression: React.lazy(() => import('./components/expression')), validate: validateMetricThreshold, diff --git a/x-pack/plugins/infra/public/alerting/log_threshold/log_threshold_alert_type.ts b/x-pack/plugins/infra/public/alerting/log_threshold/log_threshold_alert_type.ts index 29a58fc95f2be..8af6a9128fc75 100644 --- a/x-pack/plugins/infra/public/alerting/log_threshold/log_threshold_alert_type.ts +++ b/x-pack/plugins/infra/public/alerting/log_threshold/log_threshold_alert_type.ts @@ -15,6 +15,9 @@ export function getAlertType(): AlertTypeModel { name: i18n.translate('xpack.infra.logs.alertFlyout.alertName', { defaultMessage: 'Log threshold', }), + description: i18n.translate('xpack.infra.logs.alertFlyout.alertDescription', { + defaultMessage: 'Alert when the threshold of a logs aggregation has exceeded.', + }), iconClass: 'bell', alertParamsExpression: React.lazy(() => import('./components/expression_editor/editor')), validate: validateExpression, diff --git a/x-pack/plugins/infra/public/alerting/metric_threshold/index.ts b/x-pack/plugins/infra/public/alerting/metric_threshold/index.ts index 6a999a86c99d1..bf105402089e3 100644 --- a/x-pack/plugins/infra/public/alerting/metric_threshold/index.ts +++ b/x-pack/plugins/infra/public/alerting/metric_threshold/index.ts @@ -17,6 +17,9 @@ export function createMetricThresholdAlertType(): AlertTypeModel { name: i18n.translate('xpack.infra.metrics.alertFlyout.alertName', { defaultMessage: 'Metric threshold', }), + description: i18n.translate('xpack.infra.metrics.alertFlyout.alertDescription', { + defaultMessage: 'Alert when the threshold of a metrics aggregation has exceeded.', + }), iconClass: 'bell', alertParamsExpression: React.lazy(() => import('./components/expression')), validate: validateMetricThreshold, diff --git a/x-pack/plugins/monitoring/public/alerts/cpu_usage_alert/cpu_usage_alert.tsx b/x-pack/plugins/monitoring/public/alerts/cpu_usage_alert/cpu_usage_alert.tsx index fb4ecacf57fd6..6323ba3977a27 100644 --- a/x-pack/plugins/monitoring/public/alerts/cpu_usage_alert/cpu_usage_alert.tsx +++ b/x-pack/plugins/monitoring/public/alerts/cpu_usage_alert/cpu_usage_alert.tsx @@ -17,6 +17,7 @@ export function createCpuUsageAlertType(): AlertTypeModel { return { id: ALERT_CPU_USAGE, name: alert.label, + description: alert.description, iconClass: 'bell', alertParamsExpression: (props: Props) => ( diff --git a/x-pack/plugins/monitoring/public/alerts/disk_usage_alert/index.tsx b/x-pack/plugins/monitoring/public/alerts/disk_usage_alert/index.tsx index c2abb35612b38..2a9447664f086 100644 --- a/x-pack/plugins/monitoring/public/alerts/disk_usage_alert/index.tsx +++ b/x-pack/plugins/monitoring/public/alerts/disk_usage_alert/index.tsx @@ -18,6 +18,7 @@ export function createDiskUsageAlertType(): AlertTypeModel { return { id: DiskUsageAlert.TYPE, name: DiskUsageAlert.LABEL, + description: DiskUsageAlert.DESCRIPTION, iconClass: 'bell', alertParamsExpression: (props: Props) => ( diff --git a/x-pack/plugins/monitoring/public/alerts/legacy_alert/legacy_alert.tsx b/x-pack/plugins/monitoring/public/alerts/legacy_alert/legacy_alert.tsx index f6223d41ab30e..1fd94aa772c62 100644 --- a/x-pack/plugins/monitoring/public/alerts/legacy_alert/legacy_alert.tsx +++ b/x-pack/plugins/monitoring/public/alerts/legacy_alert/legacy_alert.tsx @@ -19,6 +19,7 @@ export function createLegacyAlertTypes(): AlertTypeModel[] { return { id: legacyAlert, name: alert.label, + description: alert.description, iconClass: 'bell', alertParamsExpression: (props: any) => ( diff --git a/x-pack/plugins/monitoring/public/alerts/memory_usage_alert/index.tsx b/x-pack/plugins/monitoring/public/alerts/memory_usage_alert/index.tsx index dd60967a3458b..ea8a6c50356f0 100644 --- a/x-pack/plugins/monitoring/public/alerts/memory_usage_alert/index.tsx +++ b/x-pack/plugins/monitoring/public/alerts/memory_usage_alert/index.tsx @@ -18,6 +18,7 @@ export function createMemoryUsageAlertType(): AlertTypeModel { return { id: MemoryUsageAlert.TYPE, name: MemoryUsageAlert.LABEL, + description: MemoryUsageAlert.DESCRIPTION, iconClass: 'bell', alertParamsExpression: (props: Props) => ( diff --git a/x-pack/plugins/monitoring/public/alerts/missing_monitoring_data_alert/missing_monitoring_data_alert.tsx b/x-pack/plugins/monitoring/public/alerts/missing_monitoring_data_alert/missing_monitoring_data_alert.tsx index bcea98592adb2..e2ef7488f276d 100644 --- a/x-pack/plugins/monitoring/public/alerts/missing_monitoring_data_alert/missing_monitoring_data_alert.tsx +++ b/x-pack/plugins/monitoring/public/alerts/missing_monitoring_data_alert/missing_monitoring_data_alert.tsx @@ -17,6 +17,7 @@ export function createMissingMonitoringDataAlertType(): AlertTypeModel { return { id: ALERT_MISSING_MONITORING_DATA, name: alert.label, + description: alert.description, iconClass: 'bell', alertParamsExpression: (props: any) => ( diff --git a/x-pack/plugins/monitoring/server/alerts/base_alert.ts b/x-pack/plugins/monitoring/server/alerts/base_alert.ts index c92291cf72093..a6d91e635419e 100644 --- a/x-pack/plugins/monitoring/server/alerts/base_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/base_alert.ts @@ -43,6 +43,7 @@ import { appendMetricbeatIndex } from '../lib/alerts/append_mb_index'; export class BaseAlert { public type!: string; public label!: string; + public description!: string; public defaultThrottle: string = '1d'; public defaultInterval: string = '1m'; public rawAlert: Alert | undefined; diff --git a/x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts b/x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts index 427dd2f86de00..42f8fbb6d0e25 100644 --- a/x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts @@ -42,6 +42,9 @@ export class ClusterHealthAlert extends BaseAlert { public label = i18n.translate('xpack.monitoring.alerts.clusterHealth.label', { defaultMessage: 'Cluster health', }); + public description = i18n.translate('xpack.monitoring.alerts.clusterHealth.label', { + defaultMessage: 'Alert when the health of the cluster changes.', + }); public isLegacy = true; protected actionVariables = [ diff --git a/x-pack/plugins/monitoring/server/alerts/cpu_usage_alert.ts b/x-pack/plugins/monitoring/server/alerts/cpu_usage_alert.ts index 09133dadca162..540afb8e9c578 100644 --- a/x-pack/plugins/monitoring/server/alerts/cpu_usage_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/cpu_usage_alert.ts @@ -61,6 +61,9 @@ export class CpuUsageAlert extends BaseAlert { public label = i18n.translate('xpack.monitoring.alerts.cpuUsage.label', { defaultMessage: 'CPU Usage', }); + public description = i18n.translate('xpack.monitoring.alerts.cpuUsage.description', { + defaultMessage: 'Alert when a node runs a consistently high CPU load.', + }); protected defaultParams: CpuUsageParams = { threshold: DEFAULT_THRESHOLD, diff --git a/x-pack/plugins/monitoring/server/alerts/disk_usage_alert.ts b/x-pack/plugins/monitoring/server/alerts/disk_usage_alert.ts index 34c640de79625..0c5b0b05f192c 100644 --- a/x-pack/plugins/monitoring/server/alerts/disk_usage_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/disk_usage_alert.ts @@ -50,8 +50,15 @@ export class DiskUsageAlert extends BaseAlert { public static readonly LABEL = i18n.translate('xpack.monitoring.alerts.diskUsage.label', { defaultMessage: 'Disk Usage', }); + public static readonly DESCRIPTION = i18n.translate( + 'xpack.monitoring.alerts.diskUsage.description', + { + defaultMessage: 'Alert when a node runs a consistently high disk usage.', + } + ); public type = DiskUsageAlert.TYPE; public label = DiskUsageAlert.LABEL; + public description = DiskUsageAlert.DESCRIPTION; protected defaultParams = { threshold: 80, diff --git a/x-pack/plugins/monitoring/server/alerts/elasticsearch_version_mismatch_alert.ts b/x-pack/plugins/monitoring/server/alerts/elasticsearch_version_mismatch_alert.ts index f26b21f0c64c5..f5abfbf6b650b 100644 --- a/x-pack/plugins/monitoring/server/alerts/elasticsearch_version_mismatch_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/elasticsearch_version_mismatch_alert.ts @@ -29,6 +29,12 @@ export class ElasticsearchVersionMismatchAlert extends BaseAlert { public label = i18n.translate('xpack.monitoring.alerts.elasticsearchVersionMismatch.label', { defaultMessage: 'Elasticsearch version mismatch', }); + public description = i18n.translate( + 'xpack.monitoring.alerts.elasticsearchVersionMismatch.label', + { + defaultMessage: 'Alert when there is a version mismatch in Elasticsearch.', + } + ); public isLegacy = true; protected actionVariables = [ diff --git a/x-pack/plugins/monitoring/server/alerts/kibana_version_mismatch_alert.ts b/x-pack/plugins/monitoring/server/alerts/kibana_version_mismatch_alert.ts index 316f305603964..1aacd768188b0 100644 --- a/x-pack/plugins/monitoring/server/alerts/kibana_version_mismatch_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/kibana_version_mismatch_alert.ts @@ -29,6 +29,9 @@ export class KibanaVersionMismatchAlert extends BaseAlert { public label = i18n.translate('xpack.monitoring.alerts.kibanaVersionMismatch.label', { defaultMessage: 'Kibana version mismatch', }); + public description = i18n.translate('xpack.monitoring.alerts.kibanaVersionMismatch.description', { + defaultMessage: 'Alert when there is a version mismatch in Kibana.', + }); public isLegacy = true; protected actionVariables = [ diff --git a/x-pack/plugins/monitoring/server/alerts/license_expiration_alert.ts b/x-pack/plugins/monitoring/server/alerts/license_expiration_alert.ts index f1412ff0fc91a..8f95c896d10a8 100644 --- a/x-pack/plugins/monitoring/server/alerts/license_expiration_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/license_expiration_alert.ts @@ -37,6 +37,9 @@ export class LicenseExpirationAlert extends BaseAlert { public label = i18n.translate('xpack.monitoring.alerts.licenseExpiration.label', { defaultMessage: 'License expiration', }); + public description = i18n.translate('xpack.monitoring.alerts.licenseExpiration.description', { + defaultMessage: 'Alert when the license is about to expire.', + }); public isLegacy = true; protected actionVariables = [ { diff --git a/x-pack/plugins/monitoring/server/alerts/logstash_version_mismatch_alert.ts b/x-pack/plugins/monitoring/server/alerts/logstash_version_mismatch_alert.ts index 37515e32e591a..afcb7ca459eb5 100644 --- a/x-pack/plugins/monitoring/server/alerts/logstash_version_mismatch_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/logstash_version_mismatch_alert.ts @@ -29,6 +29,12 @@ export class LogstashVersionMismatchAlert extends BaseAlert { public label = i18n.translate('xpack.monitoring.alerts.logstashVersionMismatch.label', { defaultMessage: 'Logstash version mismatch', }); + public description = i18n.translate( + 'xpack.monitoring.alerts.logstashVersionMismatch.description', + { + defaultMessage: 'Alert when there is a version mismatch in Logstash.', + } + ); public isLegacy = true; protected actionVariables = [ diff --git a/x-pack/plugins/monitoring/server/alerts/memory_usage_alert.ts b/x-pack/plugins/monitoring/server/alerts/memory_usage_alert.ts index 8dc707afab1e1..2a5a016f68d14 100644 --- a/x-pack/plugins/monitoring/server/alerts/memory_usage_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/memory_usage_alert.ts @@ -51,8 +51,15 @@ export class MemoryUsageAlert extends BaseAlert { public static readonly LABEL = i18n.translate('xpack.monitoring.alerts.memoryUsage.label', { defaultMessage: 'Memory Usage (JVM)', }); + public static readonly DESCRIPTION = i18n.translate( + 'xpack.monitoring.alerts.memoryUsage.description', + { + defaultMessage: 'Alert when a node is reporting high memory usage.', + } + ); public type = MemoryUsageAlert.TYPE; public label = MemoryUsageAlert.LABEL; + public description = MemoryUsageAlert.DESCRIPTION; protected defaultParams = { threshold: 85, diff --git a/x-pack/plugins/monitoring/server/alerts/missing_monitoring_data_alert.ts b/x-pack/plugins/monitoring/server/alerts/missing_monitoring_data_alert.ts index 5b4542a4439ca..5779f83ac1956 100644 --- a/x-pack/plugins/monitoring/server/alerts/missing_monitoring_data_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/missing_monitoring_data_alert.ts @@ -83,6 +83,9 @@ export class MissingMonitoringDataAlert extends BaseAlert { public label = i18n.translate('xpack.monitoring.alerts.missingData.label', { defaultMessage: 'Missing monitoring data', }); + public description = i18n.translate('xpack.monitoring.alerts.missingData.description', { + defaultMessage: 'Alert when monitoring data is missing.', + }); protected defaultParams: MissingDataParams = { duration: DEFAULT_DURATION, diff --git a/x-pack/plugins/monitoring/server/alerts/nodes_changed_alert.ts b/x-pack/plugins/monitoring/server/alerts/nodes_changed_alert.ts index e03e6ea53ab4e..048cec5ed52f7 100644 --- a/x-pack/plugins/monitoring/server/alerts/nodes_changed_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/nodes_changed_alert.ts @@ -30,6 +30,9 @@ export class NodesChangedAlert extends BaseAlert { public label = i18n.translate('xpack.monitoring.alerts.nodesChanged.label', { defaultMessage: 'Nodes changed', }); + public description = i18n.translate('xpack.monitoring.alerts.nodesChanged.description', { + defaultMessage: 'Alert when cluster nodes change.', + }); public isLegacy = true; protected actionVariables = [ diff --git a/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/geo_threshold/index.ts b/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/geo_threshold/index.ts index 2a421a4825e61..c72ab788258fd 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/geo_threshold/index.ts +++ b/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/geo_threshold/index.ts @@ -16,6 +16,9 @@ export function getAlertType(): AlertTypeModel import('./query_builder')), validate: validateExpression, diff --git a/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/index.ts b/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/index.ts index d7ce73ce0c7d9..0160ecd94ca04 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/index.ts +++ b/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/index.ts @@ -4,6 +4,7 @@ * you may not use this file except in compliance with the Elastic License. */ import { lazy } from 'react'; +import { i18n } from '@kbn/i18n'; import { AlertTypeModel } from '../../../../types'; import { validateExpression } from './validation'; @@ -13,7 +14,12 @@ import { AlertsContextValue } from '../../../context/alerts_context'; export function getAlertType(): AlertTypeModel { return { id: '.index-threshold', - name: 'Index threshold', + name: i18n.translate('xpack.triggersActionsUI.indexThresholdAlert.nameText', { + defaultMessage: 'Index threshold', + }), + description: i18n.translate('xpack.triggersActionsUI.indexThresholdAlert.descriptionText', { + defaultMessage: 'Alert when the threshold from an aggregated query is met', + }), iconClass: 'alert', alertParamsExpression: lazy(() => import('./expression')), validate: validateExpression, diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_add.test.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_add.test.tsx index 8ac80c4ad2880..f22d31233486b 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_add.test.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_add.test.tsx @@ -98,6 +98,7 @@ describe('alert_add', () => { id: 'my-alert-type', iconClass: 'test', name: 'test-alert', + description: 'test', validate: (): ValidationResult => { return { errors: {} }; }, diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_edit.test.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_edit.test.tsx index 24eb7aabb9549..08c927f468203 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_edit.test.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_edit.test.tsx @@ -51,6 +51,7 @@ describe('alert_edit', () => { id: 'my-alert-type', iconClass: 'test', name: 'test-alert', + description: 'test', validate: (): ValidationResult => { return { errors: {} }; }, diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.test.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.test.tsx index 6091519f5851e..01b3d6513a2cb 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.test.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.test.tsx @@ -31,6 +31,7 @@ describe('alert_form', () => { id: 'my-alert-type', iconClass: 'test', name: 'test-alert', + description: 'test', validate: (): ValidationResult => { return { errors: {} }; }, @@ -57,6 +58,7 @@ describe('alert_form', () => { id: 'non-edit-alert-type', iconClass: 'test', name: 'non edit alert', + description: 'test', validate: (): ValidationResult => { return { errors: {} }; }, @@ -241,6 +243,7 @@ describe('alert_form', () => { id: 'same-consumer-producer-alert-type', iconClass: 'test', name: 'test-alert', + description: 'test', validate: (): ValidationResult => { return { errors: {} }; }, @@ -251,6 +254,7 @@ describe('alert_form', () => { id: 'other-consumer-producer-alert-type', iconClass: 'test', name: 'test-alert', + description: 'test', validate: (): ValidationResult => { return { errors: {} }; }, diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_list/components/alerts_list.test.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_list/components/alerts_list.test.tsx index 86b9afd9565f8..388be32efa670 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_list/components/alerts_list.test.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/alerts_list/components/alerts_list.test.tsx @@ -41,6 +41,7 @@ const alertTypeRegistry = alertTypeRegistryMock.create(); const alertType = { id: 'test_alert_type', name: 'some alert type', + description: 'test', iconClass: 'test', validate: (): ValidationResult => { return { errors: {} }; diff --git a/x-pack/plugins/triggers_actions_ui/public/application/type_registry.test.ts b/x-pack/plugins/triggers_actions_ui/public/application/type_registry.test.ts index 10195e9256110..311f366df74e0 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/type_registry.test.ts +++ b/x-pack/plugins/triggers_actions_ui/public/application/type_registry.test.ts @@ -15,6 +15,7 @@ const getTestAlertType = (id?: string, name?: string, iconClass?: string) => { return { id: id || 'test-alet-type', name: name || 'Test alert type', + description: 'Test description', iconClass: iconClass || 'icon', validate: (): ValidationResult => { return { errors: {} }; diff --git a/x-pack/plugins/triggers_actions_ui/public/types.ts b/x-pack/plugins/triggers_actions_ui/public/types.ts index 148facdee248d..f8da38316625e 100644 --- a/x-pack/plugins/triggers_actions_ui/public/types.ts +++ b/x-pack/plugins/triggers_actions_ui/public/types.ts @@ -171,6 +171,7 @@ export interface AlertTypeParamsExpressionProps< export interface AlertTypeModel { id: string; name: string | JSX.Element; + description: string; iconClass: string; validate: (alertParams: AlertParamsType) => ValidationResult; alertParamsExpression: diff --git a/x-pack/plugins/uptime/common/translations.ts b/x-pack/plugins/uptime/common/translations.ts index a4a20a1445f57..12a7388c5487d 100644 --- a/x-pack/plugins/uptime/common/translations.ts +++ b/x-pack/plugins/uptime/common/translations.ts @@ -32,4 +32,7 @@ export const MonitorStatusTranslations = { name: i18n.translate('xpack.uptime.alerts.monitorStatus.clientName', { defaultMessage: 'Uptime monitor status', }), + description: i18n.translate('xpack.uptime.alerts.monitorStatus.clientName', { + defaultMessage: 'Alert when the status of an Uptime monitor is down.', + }), }; diff --git a/x-pack/plugins/uptime/public/lib/alert_types/duration_anomaly.tsx b/x-pack/plugins/uptime/public/lib/alert_types/duration_anomaly.tsx index c277e87c1ed74..7510bf805a78a 100644 --- a/x-pack/plugins/uptime/public/lib/alert_types/duration_anomaly.tsx +++ b/x-pack/plugins/uptime/public/lib/alert_types/duration_anomaly.tsx @@ -10,7 +10,7 @@ import { CLIENT_ALERT_TYPES } from '../../../common/constants/alerts'; import { DurationAnomalyTranslations } from './translations'; import { AlertTypeInitializer } from '.'; -const { name, defaultActionMessage } = DurationAnomalyTranslations; +const { name, defaultActionMessage, description } = DurationAnomalyTranslations; const DurationAnomalyAlert = React.lazy(() => import('./lazy_wrapper/duration_anomaly')); export const initDurationAnomalyAlertType: AlertTypeInitializer = ({ @@ -23,6 +23,7 @@ export const initDurationAnomalyAlertType: AlertTypeInitializer = ({ ), name, + description, validate: () => ({ errors: {} }), defaultActionMessage, requiresAppContext: true, diff --git a/x-pack/plugins/uptime/public/lib/alert_types/monitor_status.tsx b/x-pack/plugins/uptime/public/lib/alert_types/monitor_status.tsx index 935fded19b9ef..4e3d9a3c6e0ac 100644 --- a/x-pack/plugins/uptime/public/lib/alert_types/monitor_status.tsx +++ b/x-pack/plugins/uptime/public/lib/alert_types/monitor_status.tsx @@ -12,7 +12,7 @@ import { AlertTypeInitializer } from '.'; import { CLIENT_ALERT_TYPES } from '../../../common/constants/alerts'; import { MonitorStatusTranslations } from '../../../common/translations'; -const { defaultActionMessage } = MonitorStatusTranslations; +const { defaultActionMessage, description } = MonitorStatusTranslations; const MonitorStatusAlert = React.lazy(() => import('./lazy_wrapper/monitor_status')); @@ -29,6 +29,7 @@ export const initMonitorStatusAlertType: AlertTypeInitializer = ({ defaultMessage="Uptime monitor status" /> ), + description, iconClass: 'uptimeApp', alertParamsExpression: (params: any) => ( diff --git a/x-pack/plugins/uptime/public/lib/alert_types/tls.tsx b/x-pack/plugins/uptime/public/lib/alert_types/tls.tsx index 9019fc216192c..41ff08b0da97c 100644 --- a/x-pack/plugins/uptime/public/lib/alert_types/tls.tsx +++ b/x-pack/plugins/uptime/public/lib/alert_types/tls.tsx @@ -10,7 +10,7 @@ import { CLIENT_ALERT_TYPES } from '../../../common/constants/alerts'; import { TlsTranslations } from './translations'; import { AlertTypeInitializer } from '.'; -const { name, defaultActionMessage } = TlsTranslations; +const { name, defaultActionMessage, description } = TlsTranslations; const TLSAlert = React.lazy(() => import('./lazy_wrapper/tls_alert')); export const initTlsAlertType: AlertTypeInitializer = ({ core, plugins }): AlertTypeModel => ({ id: CLIENT_ALERT_TYPES.TLS, @@ -19,6 +19,7 @@ export const initTlsAlertType: AlertTypeInitializer = ({ core, plugins }): Alert ), name, + description, validate: () => ({ errors: {} }), defaultActionMessage, requiresAppContext: false, diff --git a/x-pack/plugins/uptime/public/lib/alert_types/translations.ts b/x-pack/plugins/uptime/public/lib/alert_types/translations.ts index 99edfb3b53037..227749da15e50 100644 --- a/x-pack/plugins/uptime/public/lib/alert_types/translations.ts +++ b/x-pack/plugins/uptime/public/lib/alert_types/translations.ts @@ -35,6 +35,9 @@ Aging Certificates: {agingCommonNameAndDate} name: i18n.translate('xpack.uptime.alerts.tls.clientName', { defaultMessage: 'Uptime TLS', }), + description: i18n.translate('xpack.uptime.alerts.tls.clientName', { + defaultMessage: 'Alert when the TLS certificate of an Uptime monitor is about to expire.', + }), }; export const DurationAnomalyTranslations = { @@ -55,4 +58,7 @@ Response times as high as {slowestAnomalyResponse} have been detected from locat name: i18n.translate('xpack.uptime.alerts.durationAnomaly.clientName', { defaultMessage: 'Uptime Duration Anomaly', }), + description: i18n.translate('xpack.uptime.alerts.durationAnomaly.description', { + defaultMessage: 'Alert when the uptime duration is considered anomalous.', + }), }; diff --git a/x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/public/plugin.ts b/x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/public/plugin.ts index e149fad5e9063..c738ce0697f75 100644 --- a/x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/public/plugin.ts +++ b/x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/public/plugin.ts @@ -29,6 +29,7 @@ export class AlertingFixturePlugin implements Plugin React.createElement('div', null, 'Test Always Firing'), validate: () => { @@ -40,6 +41,7 @@ export class AlertingFixturePlugin implements Plugin React.createElement('div', null, 'Test Noop'), validate: () => { From 61d5aa317eb6d8ccd0c8bd715bd97e260052d77f Mon Sep 17 00:00:00 2001 From: Mike Cote Date: Wed, 28 Oct 2020 08:21:50 -0400 Subject: [PATCH 02/18] Fix typecheck failures --- .../alerting_example/public/alert_types/always_firing.tsx | 1 + x-pack/examples/alerting_example/public/alert_types/astros.tsx | 1 + 2 files changed, 2 insertions(+) diff --git a/x-pack/examples/alerting_example/public/alert_types/always_firing.tsx b/x-pack/examples/alerting_example/public/alert_types/always_firing.tsx index 839669bda1098..9c420f4425d04 100644 --- a/x-pack/examples/alerting_example/public/alert_types/always_firing.tsx +++ b/x-pack/examples/alerting_example/public/alert_types/always_firing.tsx @@ -20,6 +20,7 @@ export function getAlertType(): AlertTypeModel { return { id: 'example.always-firing', name: 'Always Fires', + description: 'Alert when called', iconClass: 'bolt', alertParamsExpression: AlwaysFiringExpression, validate: (alertParams: AlwaysFiringParamsProps['alertParams']) => { diff --git a/x-pack/examples/alerting_example/public/alert_types/astros.tsx b/x-pack/examples/alerting_example/public/alert_types/astros.tsx index 4f894cfe231c9..343f6b10ef85b 100644 --- a/x-pack/examples/alerting_example/public/alert_types/astros.tsx +++ b/x-pack/examples/alerting_example/public/alert_types/astros.tsx @@ -45,6 +45,7 @@ export function getAlertType(): AlertTypeModel { return { id: 'example.people-in-space', name: 'People Are In Space Right Now', + description: 'Alert when people are in space right now', iconClass: 'globe', alertParamsExpression: PeopleinSpaceExpression, validate: (alertParams: PeopleinSpaceParamsProps['alertParams']) => { From cf14a664bcca252767ee90f5917d506d09f1ee69 Mon Sep 17 00:00:00 2001 From: Mike Cote Date: Wed, 28 Oct 2020 08:22:33 -0400 Subject: [PATCH 03/18] Fix i18n check --- x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts | 2 +- .../server/alerts/elasticsearch_version_mismatch_alert.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts b/x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts index 42f8fbb6d0e25..7dc071be0ec16 100644 --- a/x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts @@ -42,7 +42,7 @@ export class ClusterHealthAlert extends BaseAlert { public label = i18n.translate('xpack.monitoring.alerts.clusterHealth.label', { defaultMessage: 'Cluster health', }); - public description = i18n.translate('xpack.monitoring.alerts.clusterHealth.label', { + public description = i18n.translate('xpack.monitoring.alerts.clusterHealth.description', { defaultMessage: 'Alert when the health of the cluster changes.', }); public isLegacy = true; diff --git a/x-pack/plugins/monitoring/server/alerts/elasticsearch_version_mismatch_alert.ts b/x-pack/plugins/monitoring/server/alerts/elasticsearch_version_mismatch_alert.ts index f5abfbf6b650b..526e3a285b2f8 100644 --- a/x-pack/plugins/monitoring/server/alerts/elasticsearch_version_mismatch_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/elasticsearch_version_mismatch_alert.ts @@ -30,7 +30,7 @@ export class ElasticsearchVersionMismatchAlert extends BaseAlert { defaultMessage: 'Elasticsearch version mismatch', }); public description = i18n.translate( - 'xpack.monitoring.alerts.elasticsearchVersionMismatch.label', + 'xpack.monitoring.alerts.elasticsearchVersionMismatch.description', { defaultMessage: 'Alert when there is a version mismatch in Elasticsearch.', } From 0b1f29edfc8652f2d4c1231de785b4fb27975ff1 Mon Sep 17 00:00:00 2001 From: Mike Cote Date: Wed, 28 Oct 2020 08:23:15 -0400 Subject: [PATCH 04/18] Fix failing jest test --- .../public/lib/alert_types/__tests__/monitor_status.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/x-pack/plugins/uptime/public/lib/alert_types/__tests__/monitor_status.test.ts b/x-pack/plugins/uptime/public/lib/alert_types/__tests__/monitor_status.test.ts index 0ee78f5e4d81a..f9114b19b60b9 100644 --- a/x-pack/plugins/uptime/public/lib/alert_types/__tests__/monitor_status.test.ts +++ b/x-pack/plugins/uptime/public/lib/alert_types/__tests__/monitor_status.test.ts @@ -203,6 +203,7 @@ describe('monitor status alert type', () => { Object { "alertParamsExpression": [Function], "defaultActionMessage": "Monitor {{state.monitorName}} with url {{{state.monitorUrl}}} is {{state.statusMessage}} from {{state.observerLocation}}. The latest error message is {{{state.latestErrorMessage}}}", + "description": "Alert when the status of an Uptime monitor is down.", "iconClass": "uptimeApp", "id": "xpack.uptime.alerts.monitorStatus", "name": Date: Wed, 28 Oct 2020 08:51:18 -0400 Subject: [PATCH 05/18] Fix i18n check again --- x-pack/plugins/uptime/common/translations.ts | 2 +- x-pack/plugins/uptime/public/lib/alert_types/translations.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/uptime/common/translations.ts b/x-pack/plugins/uptime/common/translations.ts index 12a7388c5487d..4334cf8acc5c1 100644 --- a/x-pack/plugins/uptime/common/translations.ts +++ b/x-pack/plugins/uptime/common/translations.ts @@ -32,7 +32,7 @@ export const MonitorStatusTranslations = { name: i18n.translate('xpack.uptime.alerts.monitorStatus.clientName', { defaultMessage: 'Uptime monitor status', }), - description: i18n.translate('xpack.uptime.alerts.monitorStatus.clientName', { + description: i18n.translate('xpack.uptime.alerts.monitorStatus.description', { defaultMessage: 'Alert when the status of an Uptime monitor is down.', }), }; diff --git a/x-pack/plugins/uptime/public/lib/alert_types/translations.ts b/x-pack/plugins/uptime/public/lib/alert_types/translations.ts index 227749da15e50..43bf0b4cdfbcb 100644 --- a/x-pack/plugins/uptime/public/lib/alert_types/translations.ts +++ b/x-pack/plugins/uptime/public/lib/alert_types/translations.ts @@ -35,7 +35,7 @@ Aging Certificates: {agingCommonNameAndDate} name: i18n.translate('xpack.uptime.alerts.tls.clientName', { defaultMessage: 'Uptime TLS', }), - description: i18n.translate('xpack.uptime.alerts.tls.clientName', { + description: i18n.translate('xpack.uptime.alerts.tls.description', { defaultMessage: 'Alert when the TLS certificate of an Uptime monitor is about to expire.', }), }; From 3c83b6220d193172f6c571f8ef11c101cbbc1905 Mon Sep 17 00:00:00 2001 From: Mike Cote Date: Thu, 29 Oct 2020 09:56:18 -0400 Subject: [PATCH 06/18] Apply changes for Uptime --- x-pack/plugins/uptime/common/translations.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/x-pack/plugins/uptime/common/translations.ts b/x-pack/plugins/uptime/common/translations.ts index 4334cf8acc5c1..230b313c240f1 100644 --- a/x-pack/plugins/uptime/common/translations.ts +++ b/x-pack/plugins/uptime/common/translations.ts @@ -33,6 +33,7 @@ export const MonitorStatusTranslations = { defaultMessage: 'Uptime monitor status', }), description: i18n.translate('xpack.uptime.alerts.monitorStatus.description', { - defaultMessage: 'Alert when the status of an Uptime monitor is down.', + defaultMessage: + 'Alert when your synthetic monitor is down or its availability breaches an availability threshold.', }), }; From b8c735b7abae087882654e11fa2523d5ee1857bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mike=20C=C3=B4t=C3=A9?= Date: Thu, 29 Oct 2020 09:57:41 -0400 Subject: [PATCH 07/18] Update x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Casper Hübertz --- .../apm/public/components/alerting/register_apm_alerts.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts b/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts index 63d43ea2ebdd9..354d5d3fa1478 100644 --- a/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts +++ b/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts @@ -83,7 +83,7 @@ export function registerApmAlerts( 'xpack.apm.alertTypes.transactionErrorRate.description', { defaultMessage: - 'Alert when the rate of a specific transaction error in a service exceeds a defined threshold.', + 'Alert when the rate of transaction errors in a service exceeds a defined threshold.', } ), iconClass: 'bell', From c78c093c285dba6ea828c41cded5f223a03d77ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mike=20C=C3=B4t=C3=A9?= Date: Thu, 29 Oct 2020 09:57:50 -0400 Subject: [PATCH 08/18] Update x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Casper Hübertz --- .../apm/public/components/alerting/register_apm_alerts.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts b/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts index 354d5d3fa1478..0eeb31927b2f5 100644 --- a/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts +++ b/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts @@ -117,7 +117,7 @@ export function registerApmAlerts( 'xpack.apm.alertTypes.transactionDurationAnomaly.description', { defaultMessage: - 'Alert when the duration of a specific transaction is considered anomalous.', + 'Alert when the overall transaction duration of a service is considered anomalous.', } ), iconClass: 'bell', From f989489e810d64c4da11830e0742bfe8efa70e7f Mon Sep 17 00:00:00 2001 From: Mike Cote Date: Thu, 29 Oct 2020 10:21:13 -0400 Subject: [PATCH 09/18] Fix jest test --- .../public/lib/alert_types/__tests__/monitor_status.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/uptime/public/lib/alert_types/__tests__/monitor_status.test.ts b/x-pack/plugins/uptime/public/lib/alert_types/__tests__/monitor_status.test.ts index f9114b19b60b9..1f36165e76ead 100644 --- a/x-pack/plugins/uptime/public/lib/alert_types/__tests__/monitor_status.test.ts +++ b/x-pack/plugins/uptime/public/lib/alert_types/__tests__/monitor_status.test.ts @@ -203,7 +203,7 @@ describe('monitor status alert type', () => { Object { "alertParamsExpression": [Function], "defaultActionMessage": "Monitor {{state.monitorName}} with url {{{state.monitorUrl}}} is {{state.statusMessage}} from {{state.observerLocation}}. The latest error message is {{{state.latestErrorMessage}}}", - "description": "Alert when the status of an Uptime monitor is down.", + "description": "Alert when your synthetic monitor is down or its availability breaches an availability threshold.", "iconClass": "uptimeApp", "id": "xpack.uptime.alerts.monitorStatus", "name": Date: Thu, 29 Oct 2020 10:49:42 -0400 Subject: [PATCH 10/18] Update geo threshold description --- .../components/builtin_alert_types/geo_threshold/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/geo_threshold/index.ts b/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/geo_threshold/index.ts index c72ab788258fd..9f33e2c2495c5 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/geo_threshold/index.ts +++ b/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/geo_threshold/index.ts @@ -17,7 +17,7 @@ export function getAlertType(): AlertTypeModel import('./query_builder')), From 097383511c88d9bb835943b4d072d21c586a93fe Mon Sep 17 00:00:00 2001 From: Mike Cote Date: Mon, 2 Nov 2020 08:19:54 -0500 Subject: [PATCH 11/18] Update description of some alert types based on feedback from Gail --- .../log_threshold/log_threshold_alert_type.ts | 2 +- .../public/alerting/metric_threshold/index.ts | 2 +- x-pack/plugins/monitoring/common/constants.ts | 16 ++++++++-------- .../builtin_alert_types/threshold/index.ts | 2 +- .../public/lib/alert_types/translations.ts | 2 +- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/x-pack/plugins/infra/public/alerting/log_threshold/log_threshold_alert_type.ts b/x-pack/plugins/infra/public/alerting/log_threshold/log_threshold_alert_type.ts index 8af6a9128fc75..2e4cb2a53b6b5 100644 --- a/x-pack/plugins/infra/public/alerting/log_threshold/log_threshold_alert_type.ts +++ b/x-pack/plugins/infra/public/alerting/log_threshold/log_threshold_alert_type.ts @@ -16,7 +16,7 @@ export function getAlertType(): AlertTypeModel { defaultMessage: 'Log threshold', }), description: i18n.translate('xpack.infra.logs.alertFlyout.alertDescription', { - defaultMessage: 'Alert when the threshold of a logs aggregation has exceeded.', + defaultMessage: 'Alert when the log aggregation exceeds the threshold.', }), iconClass: 'bell', alertParamsExpression: React.lazy(() => import('./components/expression_editor/editor')), diff --git a/x-pack/plugins/infra/public/alerting/metric_threshold/index.ts b/x-pack/plugins/infra/public/alerting/metric_threshold/index.ts index bf105402089e3..a48837792a3cc 100644 --- a/x-pack/plugins/infra/public/alerting/metric_threshold/index.ts +++ b/x-pack/plugins/infra/public/alerting/metric_threshold/index.ts @@ -18,7 +18,7 @@ export function createMetricThresholdAlertType(): AlertTypeModel { defaultMessage: 'Metric threshold', }), description: i18n.translate('xpack.infra.metrics.alertFlyout.alertDescription', { - defaultMessage: 'Alert when the threshold of a metrics aggregation has exceeded.', + defaultMessage: 'Alert when the metrics aggregation exceeds the threshold.', }), iconClass: 'bell', alertParamsExpression: React.lazy(() => import('./components/expression')), diff --git a/x-pack/plugins/monitoring/common/constants.ts b/x-pack/plugins/monitoring/common/constants.ts index 5fb9cbea51a5e..16a4efb60ae04 100644 --- a/x-pack/plugins/monitoring/common/constants.ts +++ b/x-pack/plugins/monitoring/common/constants.ts @@ -271,7 +271,7 @@ export const LEGACY_ALERT_DETAILS = { description: i18n.translate( 'xpack.monitoring.alerts.elasticsearchVersionMismatch.description', { - defaultMessage: 'Alert when there is a version mismatch in Elasticsearch.', + defaultMessage: 'Alert when the cluster has mutliple versions of Elasticsearch.', } ), }, @@ -280,7 +280,7 @@ export const LEGACY_ALERT_DETAILS = { defaultMessage: 'Kibana version mismatch', }), description: i18n.translate('xpack.monitoring.alerts.kibanaVersionMismatch.description', { - defaultMessage: 'Alert when there is a version mismatch in Kibana.', + defaultMessage: 'Alert when the cluser has multiple versions of Kibana.', }), }, [ALERT_LICENSE_EXPIRATION]: { @@ -288,7 +288,7 @@ export const LEGACY_ALERT_DETAILS = { defaultMessage: 'License expiration', }), description: i18n.translate('xpack.monitoring.alerts.licenseExpiration.description', { - defaultMessage: 'Alert when the license is about to expire.', + defaultMessage: 'Alert when the cluster license is about to expire.', }), }, [ALERT_LOGSTASH_VERSION_MISMATCH]: { @@ -296,7 +296,7 @@ export const LEGACY_ALERT_DETAILS = { defaultMessage: 'Logstash version mismatch', }), description: i18n.translate('xpack.monitoring.alerts.logstashVersionMismatch.description', { - defaultMessage: 'Alert when there is a version mismatch in Logstash.', + defaultMessage: 'Alert when the cluster has mutliple versions of Logstash.', }) }, [ALERT_NODES_CHANGED]: { @@ -304,7 +304,7 @@ export const LEGACY_ALERT_DETAILS = { defaultMessage: 'Nodes changed', }), description: i18n.translate('xpack.monitoring.alerts.nodesChanged.description', { - defaultMessage: 'Alert when cluster nodes change.', + defaultMessage: 'Alert when adding, removing, or restarting a node.', }), }, }; @@ -318,7 +318,7 @@ export const ALERT_DETAILS = { defaultMessage: 'CPU Usage', }), description: i18n.translate('xpack.monitoring.alerts.cpuUsage.description', { - defaultMessage: 'Alert when a node runs a consistently high CPU load.', + defaultMessage: 'Alert when the CPU load for a node is consistently high.', }), paramDetails: { threshold: { @@ -354,7 +354,7 @@ export const ALERT_DETAILS = { defaultMessage: 'Disk Usage', }), description: i18n.translate('xpack.monitoring.alerts.diskUsage.description', { - defaultMessage: 'Alert when a node runs a consistently high disk usage.', + defaultMessage: 'Alert when the disk usage for a node is consistently high.', }), }, [ALERT_MEMORY_USAGE]: { @@ -376,7 +376,7 @@ export const ALERT_DETAILS = { defaultMessage: 'Memory Usage (JVM)', }), description: i18n.translate('xpack.monitoring.alerts.memoryUsage.description', { - defaultMessage: 'Alert when a node is reporting high memory usage.', + defaultMessage: 'Alert when a node reports high memory usage.', }), }, [ALERT_MISSING_MONITORING_DATA]: { diff --git a/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/index.ts b/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/index.ts index 0160ecd94ca04..61141e6e28609 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/index.ts +++ b/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_alert_types/threshold/index.ts @@ -18,7 +18,7 @@ export function getAlertType(): AlertTypeModel import('./expression')), diff --git a/x-pack/plugins/uptime/public/lib/alert_types/translations.ts b/x-pack/plugins/uptime/public/lib/alert_types/translations.ts index 43bf0b4cdfbcb..590af758d87cd 100644 --- a/x-pack/plugins/uptime/public/lib/alert_types/translations.ts +++ b/x-pack/plugins/uptime/public/lib/alert_types/translations.ts @@ -59,6 +59,6 @@ Response times as high as {slowestAnomalyResponse} have been detected from locat defaultMessage: 'Uptime Duration Anomaly', }), description: i18n.translate('xpack.uptime.alerts.durationAnomaly.description', { - defaultMessage: 'Alert when the uptime duration is considered anomalous.', + defaultMessage: 'Alert when the Uptime monitor duration is anaomalous.', }), }; From 0fcc567a83f18f26413cb4cc84b537965922f696 Mon Sep 17 00:00:00 2001 From: Mike Cote Date: Mon, 2 Nov 2020 08:23:17 -0500 Subject: [PATCH 12/18] Update description of some alert types based on feedback from Gail --- x-pack/plugins/monitoring/common/constants.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/monitoring/common/constants.ts b/x-pack/plugins/monitoring/common/constants.ts index 16a4efb60ae04..10f99b088b52f 100644 --- a/x-pack/plugins/monitoring/common/constants.ts +++ b/x-pack/plugins/monitoring/common/constants.ts @@ -422,7 +422,7 @@ export const ALERT_DETAILS = { values: { type: 'search' }, }), description: i18n.translate('xpack.monitoring.alerts.threadPoolRejections.description', { - defaultMessage: 'Alert when the search rejection count exceeds the threshold.', + defaultMessage: 'Alert when the count of search rejections exceeds the threshold.', }), }, [ALERT_THREAD_POOL_WRITE_REJECTIONS]: { @@ -446,7 +446,7 @@ export const ALERT_DETAILS = { values: { type: 'write' }, }), description: i18n.translate('xpack.monitoring.alerts.threadPoolRejections.label', { - defaultMessage: 'Alert when the write rejection count exceeds the threshold.', + defaultMessage: 'Alert when the count of write rejections exceeds the threshold.', }), }, }; From a16191b0e98c72a3f1ff462a0c1af691861cf883 Mon Sep 17 00:00:00 2001 From: Mike Cote Date: Mon, 2 Nov 2020 08:42:48 -0500 Subject: [PATCH 13/18] Fix i18n --- x-pack/plugins/monitoring/common/constants.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/monitoring/common/constants.ts b/x-pack/plugins/monitoring/common/constants.ts index 10f99b088b52f..52da21d0ea4db 100644 --- a/x-pack/plugins/monitoring/common/constants.ts +++ b/x-pack/plugins/monitoring/common/constants.ts @@ -445,7 +445,7 @@ export const ALERT_DETAILS = { defaultMessage: 'Thread pool {type} rejections', values: { type: 'write' }, }), - description: i18n.translate('xpack.monitoring.alerts.threadPoolRejections.label', { + description: i18n.translate('xpack.monitoring.alerts.threadPoolRejections.description', { defaultMessage: 'Alert when the count of write rejections exceeds the threshold.', }), }, From e502129d3a35acd6fd2c738625bdbbe8cfc41df0 Mon Sep 17 00:00:00 2001 From: Mike Cote Date: Mon, 2 Nov 2020 09:15:20 -0500 Subject: [PATCH 14/18] Fix i18n --- x-pack/plugins/monitoring/common/constants.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/monitoring/common/constants.ts b/x-pack/plugins/monitoring/common/constants.ts index 52da21d0ea4db..6e258db24fdcc 100644 --- a/x-pack/plugins/monitoring/common/constants.ts +++ b/x-pack/plugins/monitoring/common/constants.ts @@ -421,7 +421,7 @@ export const ALERT_DETAILS = { defaultMessage: 'Thread pool {type} rejections', values: { type: 'search' }, }), - description: i18n.translate('xpack.monitoring.alerts.threadPoolRejections.description', { + description: i18n.translate('xpack.monitoring.alerts.searchThreadPoolRejections.description', { defaultMessage: 'Alert when the count of search rejections exceeds the threshold.', }), }, @@ -445,7 +445,7 @@ export const ALERT_DETAILS = { defaultMessage: 'Thread pool {type} rejections', values: { type: 'write' }, }), - description: i18n.translate('xpack.monitoring.alerts.threadPoolRejections.description', { + description: i18n.translate('xpack.monitoring.alerts.writeThreadPoolRejections.description', { defaultMessage: 'Alert when the count of write rejections exceeds the threshold.', }), }, From a7cd7423204c9ba5f42662e69de5e4f8b51c7c6e Mon Sep 17 00:00:00 2001 From: Mike Cote Date: Mon, 2 Nov 2020 10:06:39 -0500 Subject: [PATCH 15/18] Fix ESLint --- x-pack/plugins/monitoring/common/constants.ts | 2 +- x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts | 2 +- x-pack/plugins/monitoring/server/alerts/cpu_usage_alert.ts | 2 +- x-pack/plugins/monitoring/server/alerts/disk_usage_alert.ts | 2 +- .../server/alerts/elasticsearch_version_mismatch_alert.ts | 2 +- .../monitoring/server/alerts/kibana_version_mismatch_alert.ts | 2 +- .../monitoring/server/alerts/license_expiration_alert.ts | 2 +- .../monitoring/server/alerts/logstash_version_mismatch_alert.ts | 2 +- x-pack/plugins/monitoring/server/alerts/memory_usage_alert.ts | 2 +- .../monitoring/server/alerts/missing_monitoring_data_alert.ts | 2 +- x-pack/plugins/monitoring/server/alerts/nodes_changed_alert.ts | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) diff --git a/x-pack/plugins/monitoring/common/constants.ts b/x-pack/plugins/monitoring/common/constants.ts index 6e258db24fdcc..192f67f9a848e 100644 --- a/x-pack/plugins/monitoring/common/constants.ts +++ b/x-pack/plugins/monitoring/common/constants.ts @@ -297,7 +297,7 @@ export const LEGACY_ALERT_DETAILS = { }), description: i18n.translate('xpack.monitoring.alerts.logstashVersionMismatch.description', { defaultMessage: 'Alert when the cluster has mutliple versions of Logstash.', - }) + }), }, [ALERT_NODES_CHANGED]: { label: i18n.translate('xpack.monitoring.alerts.nodesChanged.label', { diff --git a/x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts b/x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts index fa2e88e550296..8166b1b7f6079 100644 --- a/x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/cluster_health_alert.ts @@ -40,7 +40,7 @@ const WATCH_NAME = 'elasticsearch_cluster_status'; export class ClusterHealthAlert extends BaseAlert { public type = ALERT_CLUSTER_HEALTH; public label = LEGACY_ALERT_DETAILS[ALERT_CLUSTER_HEALTH].label; - public description = LEGACY_ALERT_DETAILS[ALERT_CLUSTER_HEALTH].description; + public description = LEGACY_ALERT_DETAILS[ALERT_CLUSTER_HEALTH].description; public isLegacy = true; protected actionVariables = [ diff --git a/x-pack/plugins/monitoring/server/alerts/cpu_usage_alert.ts b/x-pack/plugins/monitoring/server/alerts/cpu_usage_alert.ts index a4039bcc20b47..e12660ce20035 100644 --- a/x-pack/plugins/monitoring/server/alerts/cpu_usage_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/cpu_usage_alert.ts @@ -42,7 +42,7 @@ interface CpuUsageParams { export class CpuUsageAlert extends BaseAlert { public type = ALERT_CPU_USAGE; public label = ALERT_DETAILS[ALERT_CPU_USAGE].label; - public description = ALERT_DETAILS[ALERT_CPU_USAGE].description; + public description = ALERT_DETAILS[ALERT_CPU_USAGE].description; protected defaultParams: CpuUsageParams = { threshold: 85, diff --git a/x-pack/plugins/monitoring/server/alerts/disk_usage_alert.ts b/x-pack/plugins/monitoring/server/alerts/disk_usage_alert.ts index 363119993104b..658eb708acb91 100644 --- a/x-pack/plugins/monitoring/server/alerts/disk_usage_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/disk_usage_alert.ts @@ -34,7 +34,7 @@ import { appendMetricbeatIndex } from '../lib/alerts/append_mb_index'; export class DiskUsageAlert extends BaseAlert { public type = ALERT_DISK_USAGE; public label = ALERT_DETAILS[ALERT_DISK_USAGE].label; - public description = ALERT_DETAILS[ALERT_DISK_USAGE].description; + public description = ALERT_DETAILS[ALERT_DISK_USAGE].description; protected defaultParams = { threshold: 80, diff --git a/x-pack/plugins/monitoring/server/alerts/elasticsearch_version_mismatch_alert.ts b/x-pack/plugins/monitoring/server/alerts/elasticsearch_version_mismatch_alert.ts index a66db99c8c8dc..05498469b0c58 100644 --- a/x-pack/plugins/monitoring/server/alerts/elasticsearch_version_mismatch_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/elasticsearch_version_mismatch_alert.ts @@ -31,7 +31,7 @@ const WATCH_NAME = 'elasticsearch_version_mismatch'; export class ElasticsearchVersionMismatchAlert extends BaseAlert { public type = ALERT_ELASTICSEARCH_VERSION_MISMATCH; public label = LEGACY_ALERT_DETAILS[ALERT_ELASTICSEARCH_VERSION_MISMATCH].label; - public description = LEGACY_ALERT_DETAILS[ALERT_ELASTICSEARCH_VERSION_MISMATCH].description; + public description = LEGACY_ALERT_DETAILS[ALERT_ELASTICSEARCH_VERSION_MISMATCH].description; public isLegacy = true; protected actionVariables = [ diff --git a/x-pack/plugins/monitoring/server/alerts/kibana_version_mismatch_alert.ts b/x-pack/plugins/monitoring/server/alerts/kibana_version_mismatch_alert.ts index f3488c350ca49..984ee1fb396be 100644 --- a/x-pack/plugins/monitoring/server/alerts/kibana_version_mismatch_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/kibana_version_mismatch_alert.ts @@ -31,7 +31,7 @@ const WATCH_NAME = 'kibana_version_mismatch'; export class KibanaVersionMismatchAlert extends BaseAlert { public type = ALERT_KIBANA_VERSION_MISMATCH; public label = LEGACY_ALERT_DETAILS[ALERT_KIBANA_VERSION_MISMATCH].label; - public description = LEGACY_ALERT_DETAILS[ALERT_KIBANA_VERSION_MISMATCH].description; + public description = LEGACY_ALERT_DETAILS[ALERT_KIBANA_VERSION_MISMATCH].description; public isLegacy = true; protected actionVariables = [ diff --git a/x-pack/plugins/monitoring/server/alerts/license_expiration_alert.ts b/x-pack/plugins/monitoring/server/alerts/license_expiration_alert.ts index 59b3c239d75d6..00846e9cf7599 100644 --- a/x-pack/plugins/monitoring/server/alerts/license_expiration_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/license_expiration_alert.ts @@ -36,7 +36,7 @@ const WATCH_NAME = 'xpack_license_expiration'; export class LicenseExpirationAlert extends BaseAlert { public type = ALERT_LICENSE_EXPIRATION; public label = LEGACY_ALERT_DETAILS[ALERT_LICENSE_EXPIRATION].label; - public description = LEGACY_ALERT_DETAILS[ALERT_LICENSE_EXPIRATION].description; + public description = LEGACY_ALERT_DETAILS[ALERT_LICENSE_EXPIRATION].description; public isLegacy = true; protected actionVariables = [ { diff --git a/x-pack/plugins/monitoring/server/alerts/logstash_version_mismatch_alert.ts b/x-pack/plugins/monitoring/server/alerts/logstash_version_mismatch_alert.ts index ce76aa77f19d8..61967b2f6559a 100644 --- a/x-pack/plugins/monitoring/server/alerts/logstash_version_mismatch_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/logstash_version_mismatch_alert.ts @@ -31,7 +31,7 @@ const WATCH_NAME = 'logstash_version_mismatch'; export class LogstashVersionMismatchAlert extends BaseAlert { public type = ALERT_LOGSTASH_VERSION_MISMATCH; public label = LEGACY_ALERT_DETAILS[ALERT_LOGSTASH_VERSION_MISMATCH].label; - public description = LEGACY_ALERT_DETAILS[ALERT_LOGSTASH_VERSION_MISMATCH].description; + public description = LEGACY_ALERT_DETAILS[ALERT_LOGSTASH_VERSION_MISMATCH].description; public isLegacy = true; protected actionVariables = [ diff --git a/x-pack/plugins/monitoring/server/alerts/memory_usage_alert.ts b/x-pack/plugins/monitoring/server/alerts/memory_usage_alert.ts index c7cd93f12f1b0..1564b9727c64b 100644 --- a/x-pack/plugins/monitoring/server/alerts/memory_usage_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/memory_usage_alert.ts @@ -35,7 +35,7 @@ import { parseDuration } from '../../../alerts/common/parse_duration'; export class MemoryUsageAlert extends BaseAlert { public type = ALERT_MEMORY_USAGE; public label = ALERT_DETAILS[ALERT_MEMORY_USAGE].label; - public description = ALERT_DETAILS[ALERT_MEMORY_USAGE].description; + public description = ALERT_DETAILS[ALERT_MEMORY_USAGE].description; protected defaultParams = { threshold: 85, diff --git a/x-pack/plugins/monitoring/server/alerts/missing_monitoring_data_alert.ts b/x-pack/plugins/monitoring/server/alerts/missing_monitoring_data_alert.ts index c22fdb9687ad4..4001c6b9b3ed2 100644 --- a/x-pack/plugins/monitoring/server/alerts/missing_monitoring_data_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/missing_monitoring_data_alert.ts @@ -64,7 +64,7 @@ export class MissingMonitoringDataAlert extends BaseAlert { public type = ALERT_MISSING_MONITORING_DATA; public label = ALERT_DETAILS[ALERT_MISSING_MONITORING_DATA].label; - public description = ALERT_DETAILS[ALERT_MISSING_MONITORING_DATA].description; + public description = ALERT_DETAILS[ALERT_MISSING_MONITORING_DATA].description; protected defaultParams: MissingDataParams = { duration: DEFAULT_DURATION, diff --git a/x-pack/plugins/monitoring/server/alerts/nodes_changed_alert.ts b/x-pack/plugins/monitoring/server/alerts/nodes_changed_alert.ts index 0255323b762f2..e86998d27238b 100644 --- a/x-pack/plugins/monitoring/server/alerts/nodes_changed_alert.ts +++ b/x-pack/plugins/monitoring/server/alerts/nodes_changed_alert.ts @@ -28,7 +28,7 @@ const WATCH_NAME = 'elasticsearch_nodes'; export class NodesChangedAlert extends BaseAlert { public type = ALERT_NODES_CHANGED; public label = LEGACY_ALERT_DETAILS[ALERT_NODES_CHANGED].label; - public description = LEGACY_ALERT_DETAILS[ALERT_NODES_CHANGED].description; + public description = LEGACY_ALERT_DETAILS[ALERT_NODES_CHANGED].description; public isLegacy = true; protected actionVariables = [ From dd76573a5a88d9ea0a8edab78ffd591a8da1030c Mon Sep 17 00:00:00 2001 From: Mike Cote Date: Mon, 2 Nov 2020 14:53:17 -0500 Subject: [PATCH 16/18] Update some copy --- x-pack/plugins/monitoring/common/constants.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/monitoring/common/constants.ts b/x-pack/plugins/monitoring/common/constants.ts index 192f67f9a848e..2bf6b03cd1eae 100644 --- a/x-pack/plugins/monitoring/common/constants.ts +++ b/x-pack/plugins/monitoring/common/constants.ts @@ -422,7 +422,8 @@ export const ALERT_DETAILS = { values: { type: 'search' }, }), description: i18n.translate('xpack.monitoring.alerts.searchThreadPoolRejections.description', { - defaultMessage: 'Alert when the count of search rejections exceeds the threshold.', + defaultMessage: + 'Alert when the number of rejections in the search thread pool exceeds the threshold.', }), }, [ALERT_THREAD_POOL_WRITE_REJECTIONS]: { @@ -446,7 +447,8 @@ export const ALERT_DETAILS = { values: { type: 'write' }, }), description: i18n.translate('xpack.monitoring.alerts.writeThreadPoolRejections.description', { - defaultMessage: 'Alert when the count of write rejections exceeds the threshold.', + defaultMessage: + 'Alert when the number of rejections in the write thread pool exceeds the threshold.', }), }, }; From 0b13c81aa988af535b96810333963691e9a4f851 Mon Sep 17 00:00:00 2001 From: Mike Cote Date: Mon, 2 Nov 2020 19:20:34 -0500 Subject: [PATCH 17/18] Update uptime alert description --- x-pack/plugins/uptime/common/translations.ts | 3 +-- .../public/lib/alert_types/__tests__/monitor_status.test.ts | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/x-pack/plugins/uptime/common/translations.ts b/x-pack/plugins/uptime/common/translations.ts index 230b313c240f1..b85688fda859a 100644 --- a/x-pack/plugins/uptime/common/translations.ts +++ b/x-pack/plugins/uptime/common/translations.ts @@ -33,7 +33,6 @@ export const MonitorStatusTranslations = { defaultMessage: 'Uptime monitor status', }), description: i18n.translate('xpack.uptime.alerts.monitorStatus.description', { - defaultMessage: - 'Alert when your synthetic monitor is down or its availability breaches an availability threshold.', + defaultMessage: 'Alert when a monitor is down or an availability threshold is breached.', }), }; diff --git a/x-pack/plugins/uptime/public/lib/alert_types/__tests__/monitor_status.test.ts b/x-pack/plugins/uptime/public/lib/alert_types/__tests__/monitor_status.test.ts index 1f36165e76ead..5106fcbc97bcd 100644 --- a/x-pack/plugins/uptime/public/lib/alert_types/__tests__/monitor_status.test.ts +++ b/x-pack/plugins/uptime/public/lib/alert_types/__tests__/monitor_status.test.ts @@ -203,7 +203,7 @@ describe('monitor status alert type', () => { Object { "alertParamsExpression": [Function], "defaultActionMessage": "Monitor {{state.monitorName}} with url {{{state.monitorUrl}}} is {{state.statusMessage}} from {{state.observerLocation}}. The latest error message is {{{state.latestErrorMessage}}}", - "description": "Alert when your synthetic monitor is down or its availability breaches an availability threshold.", + "description": "Alert when a monitor is down or an availability threshold is breached.", "iconClass": "uptimeApp", "id": "xpack.uptime.alerts.monitorStatus", "name": Date: Tue, 3 Nov 2020 10:18:27 -0500 Subject: [PATCH 18/18] Fix typos --- x-pack/plugins/monitoring/common/constants.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/monitoring/common/constants.ts b/x-pack/plugins/monitoring/common/constants.ts index 2bf6b03cd1eae..8d1ffc89f5dd6 100644 --- a/x-pack/plugins/monitoring/common/constants.ts +++ b/x-pack/plugins/monitoring/common/constants.ts @@ -271,7 +271,7 @@ export const LEGACY_ALERT_DETAILS = { description: i18n.translate( 'xpack.monitoring.alerts.elasticsearchVersionMismatch.description', { - defaultMessage: 'Alert when the cluster has mutliple versions of Elasticsearch.', + defaultMessage: 'Alert when the cluster has multiple versions of Elasticsearch.', } ), }, @@ -296,7 +296,7 @@ export const LEGACY_ALERT_DETAILS = { defaultMessage: 'Logstash version mismatch', }), description: i18n.translate('xpack.monitoring.alerts.logstashVersionMismatch.description', { - defaultMessage: 'Alert when the cluster has mutliple versions of Logstash.', + defaultMessage: 'Alert when the cluster has multiple versions of Logstash.', }), }, [ALERT_NODES_CHANGED]: {