SOM: fix inspect action when having a basePath #80950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Feature:Saved Objects
release_note:skip
|
Pinging @elastic/kibana-platform (Team:Platform) |
mshustov
approved these changes
Oct 19, 2020
|
|
||
| const spaceId = 'space_1'; | ||
|
|
||
| describe('TOTO spaces integration', () => { |
There was a problem hiding this comment.
This is my hidden keyword for --grep since my kid typed it one year ago 😄
x-pack/test/functional/apps/saved_objects_management/spaces_integration.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional/apps/saved_objects_management/spaces_integration.ts
Outdated
Show resolved
Hide resolved
mshustov
reviewed
Oct 19, 2020
| "mappings": { | ||
| "dynamic": "strict", | ||
| "properties": { | ||
| "apm-telemetry": { |
There was a problem hiding this comment.
yea... and it is actually necessary, removing it show errors in the FTR server logs sometimes...
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Oct 19, 2020
* SOM: fix inspect action when having a basePath * remove explicit login * remvoe useless object from dump * review comments
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Oct 19, 2020
* SOM: fix inspect action when having a basePath * remove explicit login * remvoe useless object from dump * review comments
pgayvallet
added a commit
that referenced
this pull request
Oct 19, 2020
pgayvallet
added a commit
that referenced
this pull request
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #80827
Correctly append basePath when resolving an object's
inspecturl.Checklist