[Monitoring] Fix UX around an unavailable remote cluster #79202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
release_note:fix
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
igoristic
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
@chrisronline Looking good 👍
Was wondering if we should also backport this to 7.9.3?
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
This was referenced Oct 8, 2020
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 8, 2020
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline
added a commit
that referenced
this pull request
Oct 8, 2020
chrisronline
added a commit
that referenced
this pull request
Oct 8, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 12, 2020
* master: (23 commits) Table visualization renderer (elastic#79455) Migrate Jest JUnit reporter to TS (elastic#79919) store sorted bundleRefExportIds (elastic#80011) update chromedriver dependency to 86.0.0 (elastic#79972) [Security Solution][Case] Fix bug when changing connectors (elastic#80002) [kbn/std] add observable helpers to aid with rxjs 7 upgrade (elastic#79752) [Security Solution][Resolver] Pill numbers in compact notation (elastic#80038) [Logs UI] Sync logs timerange with wider Kibana (elastic#79444) [DOCS] Adds quick start (elastic#78822) [Ingest Manager]Fix ingest manager UI renaming (elastic#80036) [Monitoring] Fixed internal monitoring check (elastic#79241) [Security Solution][Exception Modal] Removes list operators in exception modal for EQL rules (elastic#79871) Update development documentation about REST API best practices (elastic#80009) [Monitoring] Improve indices loading against larger metricbeat-* indices (elastic#79190) [CI] Move kibana build dir outside of repo for functional tests (elastic#80018) [kbn/optimizer] bump low or add missing limits when updating automatically (elastic#80013) [Enterprise Search] Added a Credentials page to App Search (elastic#79749) [DOCS] Canvas refresh for 7.10 (elastic#80017) [TSVB] Add ignore global filters to series options (elastic#79337) Remove this check (elastic#79202) ...
chrisronline
added a commit
that referenced
this pull request
Oct 15, 2020
2 tasks
2 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57596
Okay so I'm exactly sure what's going on. We previously had an issue where any configured remote clusters that were not unavailable would bring down the Stack Monitoring UI.
In #44800, we addressed this and added a check to let the user know they need to resolve this downed clusters, or remove them from their remote cluster list.
However, we should be able to handle showing the other clusters that are available, so while investigating this fix, it seemed that we didn't even need this check in the first place. I'm not sure if something changed on the Elasticsearch side, but it appears that the queries don't fail when a remote cluster is down anymore.