[Canvas] Add NP routing for custom elements #52561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poffdeluxe
added
review
Team:Presentation
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
crob611
reviewed
Dec 10, 2019
There was a problem hiding this comment.
I'm seeing an issue where when you Delete a custom element, it is not waiting until the delete finishes to refetch them, so it appears the delete does not happen, even though it does.
I don't know what on this PR would be causing this, but it doesn't appear to be happening on master
x-pack/plugins/canvas/server/routes/custom_elements/get.test.ts
Outdated
Show resolved
Hide resolved
poffdeluxe
force-pushed
the
new-platform-routing-custom-elements
branch
from
0b42650
to
80b4b6a
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
poffdeluxe
added a commit
to poffdeluxe/kibana
that referenced
this pull request
Dec 11, 2019
* [Canvas] Add NP routing for custom elements * Remove unused type * Cleanup * Adding await to delete * Cleanup
poffdeluxe
added a commit
that referenced
this pull request
Dec 11, 2019
timductive
pushed a commit
to timductive/kibana
that referenced
this pull request
Dec 16, 2019
* [Canvas] Add NP routing for custom elements * Remove unused type * Cleanup * Adding await to delete * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds on the work done here: #51116
Moves custom element API routes to the new platform
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)For maintainers