Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mapping editor] Fix client integration tests #52124

Merged
merged 1 commit into from
Dec 4, 2019
Merged

[Mapping editor] Fix client integration tests #52124

merged 1 commit into from
Dec 4, 2019

Conversation

alisonelizabeth
Copy link
Contributor

This PR fixes the existing client integration tests in index_management (tests are no longer skipped after #51145 was merged). I will add additional tests related to the mapping editor in a subsequent PR. This is just to get the build passing again.

@alisonelizabeth alisonelizabeth added non-issue Indicates to automation that a pull request should not appear in the release notes Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes labels Dec 3, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

cjcenizal
cjcenizal approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@alisonelizabeth alisonelizabeth merged commit 6994087 into elastic:feature/mappings-editor Dec 4, 2019
@alisonelizabeth alisonelizabeth deleted the mappings-editor/tests branch December 4, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
Feature:Index Management Index and index templates UI non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alisonelizabeth @elasticmachine @cjcenizal