Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move errors and validate index pattern ⇒ NP #51805

Merged
merged 5 commits into from
Nov 27, 2019
Merged

Move errors and validate index pattern ⇒ NP #51805

merged 5 commits into from
Nov 27, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Nov 27, 2019 •
edited
Loading

Summary

Extracted from #51199 to simplify the PR moving the indexPattern service to NP.

Dev Docs on #43438

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom requested a review from a team as a code owner November 27, 2019 11:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom added v7.6.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 27, 2019
@lizozom lizozom self-assigned this Nov 27, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom lizozom added the review label Nov 27, 2019
@lizozom lizozom changed the title Move errors and validate index pattern to NP Move errors and validate index pattern ⇒ NP Nov 27, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom lizozom requested review from lukeelmers and removed request for lukeelmers November 27, 2019 15:27
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

lukeelmers
lukeelmers approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only. We should add dev docs to this issue since we are deleting a few things.

@lizozom lizozom added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. and removed release_note:skip Skip the PR/issue when compiling release notes labels Nov 27, 2019
@lizozom lizozom merged commit 7a09409 into elastic:master Nov 27, 2019
lizozom pushed a commit to lizozom/kibana that referenced this pull request Nov 27, 2019
Move errors and validate index pattern ⇒ NP (elastic#51805)
5107588 
* Move errors and validate index pattern to NP

* removed unused mock

* remvoed irrelevant mock

* Removed unneeded mocks

* fix test
@lizozom lizozom mentioned this pull request Nov 27, 2019
Merged
lizozom pushed a commit that referenced this pull request Nov 27, 2019
Move errors and validate index pattern ⇒ NP (#51805) (#51831)
03d08c3 
* Move errors and validate index pattern to NP

* removed unused mock

* remvoed irrelevant mock

* Removed unneeded mocks

* fix test
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 27, 2019
@jloleysens
Merge remote-tracking branch 'upstream/7.x' into backport/7.x/pr-50163
bc6197f 
* upstream/7.x:
  Fix infinite redirect loop when multiple cookies are sent (elastic#50452) (elastic#51821)
  [Console] Proxy fallback (elastic#50185) (elastic#51814)
  Added endgame-* index and new heading 3 Elastic Endpoint SMP. (elastic#51071) (elastic#51828)
  [Maps] Added options to disable zoom, hide tool tips, widgets/overlays in embeddable maps (elastic#50663) (elastic#51811)
  Move errors and validate index pattern ⇒ NP (elastic#51805) (elastic#51831)
  [SIEM][Detection Engine] Adds ecs threat properties to rules (elastic#51782) (elastic#51827)
  [Lens] Remove client-side reference to server source code (elastic#51763) (elastic#51825)
  fixes drag and drop in tests (elastic#51806) (elastic#51813)
  [Uptime] Redesign/44541  new monitor list expanded row (elastic#46567) (elastic#51809)
  [7.x] [Telemetry] collector set to np (elastic#51618) (elastic#51787)
  [Uptime] added test for chart wrapper (elastic#50399) (elastic#51808)
  Expressions service fixes: better error and loading states handling (elastic#51183) (elastic#51800)
  Query String(Bar) Input - cleanup (elastic#51598) (elastic#51804)
  [ML] Adjust and re-enable categorization advanced wizard test (elastic#51005) (elastic#51017)
  fixes url state tests (elastic#51746) (elastic#51798)
  fixes browser field tests (elastic#51738) (elastic#51799)
  [Task Manager] Tests for the ability to run tasks of varying durations in parallel (elastic#51572) (elastic#51701)
  [ML] Fix anomaly detection test suite (elastic#51712) (elastic#51795)
  [SIEM] Fix Timeline drag and drop behavior (elastic#51558) (elastic#51793)
mbondyra added a commit to mbondyra/kibana that referenced this pull request Nov 28, 2019
@mbondyra
Merge branch 'IS-46410_remove-@kbn/ui-framework' of github.com:mbondy…
4b0ac16 
…ra/kibana into IS-46410_remove-@kbn/ui-framework

* 'IS-46410_remove-@kbn/ui-framework' of github.com:mbondyra/kibana: (49 commits)
  [ML] Re-activate after method in transform test (elastic#51815)
  [SIEM] [Detection Engine] Add edit on rule creation (elastic#51670)
  De-angularize visLegend (elastic#50613)
  [SIEM][Detection Engine] Change security model to use SIEM permissions
  [Monitoring] Sass cleanup (elastic#51100)
  Move errors and validate index pattern ⇒ NP (elastic#51805)
  fixes pagination tests (elastic#51822)
  Split legacy plugin discovery, expose SavedObjects scopedClient, wrappers, repository (elastic#48882)
  [SIEM][Detection Engine] Adds ecs threat properties to rules (elastic#51782)
  [Lens] Remove client-side reference to server source code (elastic#51763)
  Fix infinite redirect loop when multiple cookies are sent (elastic#50452)
  fixes drag and drop in tests (elastic#51806)
  [Console] Proxy fallback (elastic#50185)
  Query String(Bar) Input - cleanup (elastic#51598)
  shim visualizations plugin (elastic#50624)
  Expressions service fixes: better error and loading states handling (elastic#51183)
  fixes url state tests (elastic#51746)
  fixes browser field tests (elastic#51738)
  [ML] Fix anomaly detection test suite (elastic#51712)
  [SIEM] Fix Timeline drag and drop behavior (elastic#51558)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 28, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into np-migration/…
65e74cf 
…license-management

* 'master' of github.com:elastic/kibana: (48 commits)
  Enable alerting and actions plugin by default (elastic#51254)
  Fix error returned when creating an alert with ES security disabled (elastic#51639)
  [Discover] Improve Percy functional tests (elastic#51699)
  fixes timeline data providers tests (elastic#51862)
  [Dependencies]: upgrade react to latest v16.12.0 (elastic#51145)
  Allow routes to define some payload config values (elastic#50783)
  Move saved queries service + language switcher ⇒ NP (elastic#51812)
  [ML] Re-activate after method in transform test (elastic#51815)
  [SIEM] [Detection Engine] Add edit on rule creation (elastic#51670)
  De-angularize visLegend (elastic#50613)
  [SIEM][Detection Engine] Change security model to use SIEM permissions
  [Monitoring] Sass cleanup (elastic#51100)
  Move errors and validate index pattern ⇒ NP (elastic#51805)
  fixes pagination tests (elastic#51822)
  Split legacy plugin discovery, expose SavedObjects scopedClient, wrappers, repository (elastic#48882)
  [SIEM][Detection Engine] Adds ecs threat properties to rules (elastic#51782)
  [Lens] Remove client-side reference to server source code (elastic#51763)
  Fix infinite redirect loop when multiple cookies are sent (elastic#50452)
  fixes drag and drop in tests (elastic#51806)
  [Console] Proxy fallback (elastic#50185)
  ...
timductive pushed a commit to timductive/kibana that referenced this pull request Dec 16, 2019
@timductive
Move errors and validate index pattern ⇒ NP (elastic#51805)
ee85b2f 
* Move errors and validate index pattern to NP

* removed unused mock

* remvoed irrelevant mock

* Removed unneeded mocks

* fix test
@lizozom lizozom added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. labels Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

@gospodarsky gospodarsky Awaiting requested review from gospodarsky

Assignees

@lizozom lizozom

Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes review v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizozom @elasticmachine @lukeelmers