[ML] Fixes series color in data visualizer metric distribution chart #44499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
:ml
v8.0.0
release_note:skip
peteharverson
requested review from
walterra,
alvarezmelissa87 and
jgowdyelastic
|
Pinging @elastic/ml-ui |
💚 Build Succeeded |
peteharverson
force-pushed
the
ml-dataviz-chart-colors
branch
from
9ede992
to
3496d43
Compare
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Sep 2, 2019
This was referenced Sep 2, 2019
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Sep 2, 2019
peteharverson
added a commit
that referenced
this pull request
Sep 2, 2019
peteharverson
added a commit
that referenced
this pull request
Sep 2, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the color of the metric distribution chart area series in the index based data visualizer, which had been incorrectly showing up as red since the version of Elastic charts was bumped to 8.0.0+, following the conversion of the data visualizer to React in #42685.
Also simplifies the way the color of the series of the two charts in the data visualizer is set, using a global theme since each chart only has one series.
Checklist
For maintainers