Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Clarify labels of log rate section #44108

Merged
merged 2 commits into from
Aug 28, 2019
Merged

[Logs UI] Clarify labels of log rate section #44108

merged 2 commits into from
Aug 28, 2019

Conversation

weltenwort
Copy link
Member

@weltenwort weltenwort commented Aug 27, 2019 •
edited
Loading

Summary

This clarifies a section title and view switcher labels on the log analysis tab. It also fixes the unit on the y axis label:

grafik

closes #44084

Checklist

@weltenwort weltenwort added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Aug 27, 2019
@weltenwort weltenwort self-assigned this Aug 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

@weltenwort weltenwort force-pushed the logs-ui-clarify-log-rate-labels branch from ed307d7 to a5d592b Compare August 27, 2019 15:23
@weltenwort weltenwort changed the title [Logs UI] Clarify labels of log rate section and view switcher [Logs UI] Clarify labels of log rate section Aug 27, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@weltenwort weltenwort marked this pull request as ready for review August 27, 2019 17:21
@weltenwort weltenwort requested a review from a team as a code owner August 27, 2019 17:21
Kerry350
Kerry350 approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@weltenwort weltenwort merged commit 22e781a into elastic:master Aug 28, 2019
@weltenwort weltenwort deleted the logs-ui-clarify-log-rate-labels branch August 28, 2019 09:19
@weltenwort weltenwort mentioned this pull request Aug 28, 2019
Merged
weltenwort added a commit to weltenwort/kibana that referenced this pull request Aug 28, 2019
@weltenwort
[Logs UI] Clarify labels of log rate section (elastic#44108)
2274188 
This clarifies a section title and view switcher labels on the log analysis tab. It also fixes the unit on the y axis label.
Kerry350 pushed a commit to weltenwort/kibana that referenced this pull request Aug 28, 2019
@weltenwort @Kerry350
[Logs UI] Clarify labels of log rate section (elastic#44108)
eef7919 
This clarifies a section title and view switcher labels on the log analysis tab. It also fixes the unit on the y axis label.
Kerry350 pushed a commit that referenced this pull request Aug 28, 2019
@weltenwort @Kerry350
[Logs UI] Clarify labels of log rate section (#44108) (#44228)
68f175b 
This clarifies a section title and view switcher labels on the log analysis tab. It also fixes the unit on the y axis label.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerry350 Kerry350 Kerry350 approved these changes

Assignees

@weltenwort weltenwort

Labels
Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes review Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs UI] Clarify log rate anomaly chart labels
3 participants
@weltenwort @elasticmachine @Kerry350