[Stack Monitoring] Update APM metric titles #44091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/stack-monitoring |
💚 Build Succeeded |
simitt
approved these changes
Aug 27, 2019
x-pack/legacy/plugins/monitoring/server/lib/metrics/__test__/__snapshots__/metrics.test.js.snap
Outdated
Show resolved
Hide resolved
7 tasks
💚 Build Succeeded |
cachedout
added a commit
to cachedout/kibana
that referenced
this pull request
Aug 28, 2019
* Update APM metric titles * Change to Request Count Intake API
cachedout
added a commit
that referenced
this pull request
Aug 28, 2019
|
@cachedout @chrisronline @simitt can you please add a release_note label to this PR? |
|
@rayafratkina Apologies. Label added. :) |
friol
pushed a commit
to friol/kibana
that referenced
this pull request
Aug 29, 2019
* Update APM metric titles * Change to Request Count Intake API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update just the the titles of the graphs. Refs #44001 and #43998
After a discussion in #43998 we decided just to update the titles for 7.4 and to postpone additional work for a later time.
To test this PR, verify that the following graph titles exist on the Overview and Instance pages for APM server monitoring:
Response Count Intake API
Response Errors Intake API
Requests Intake API
Ensure you do not see metrics titled as any of the following:
Response Count
Response Errors
Requests
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11This was checked for keyboard-only and screenreader accessibilityFor maintainers