Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable alerting and actions plugin by default #44083

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

mikecote
Copy link
Contributor

I have noticed that Alerting and Actions show up under feature controls in the UI (when creating a role then assigning space privileges). This is caused by the security PR registering features in order to test different scenarios (#41389). We'll disable the plugins by default until the UI is ready.

Screenshot of what shows up in the assign spaces privileges UI without this change:
Screen Shot 2019-08-26 at 4 32 53 PM

In order to have this working by default again in a development environment. Create a kibana.dev.yml file under /config and add the following two lines:

xpack.actions.enabled: true
xpack.alerting.enabled: true

@mikecote mikecote requested review from pmuellr, bmcconaghy and a team August 27, 2019 12:40
@mikecote mikecote self-assigned this Aug 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikecote mikecote merged commit b680912 into elastic:master Aug 27, 2019
mikecote added a commit to mikecote/kibana that referenced this pull request Aug 27, 2019
* Disable alerting and actions plugin by default

* Fix test failures
mikecote added a commit that referenced this pull request Aug 27, 2019
* Disable alerting and actions plugin by default

* Fix test failures
simianhacker pushed a commit to simianhacker/kibana that referenced this pull request Aug 27, 2019
* Disable alerting and actions plugin by default

* Fix test failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants