Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/default enable csv dashboard #44048

Merged
merged 13 commits into from
Aug 27, 2019
Merged

Feature/default enable csv dashboard #44048

merged 13 commits into from
Aug 27, 2019

Conversation

joelgriffith
Copy link
Contributor

@joelgriffith joelgriffith commented Aug 26, 2019

By default, we were forcing users not to have access to downloading CSV's of saved-search results in their dashboards. This was by design, so we could test it "in the wild" before revealing it to a larger user base.

Release Note:
You can now export your saved search visualizations directly to a CSV through the panel action "Export to CSV." This makes it even easier to export your results without having to find them in the Discover app in Kibana. If you want to disable this feature, simply set xpack.reporting.csv.enablePanelActionDownload: false in your Kibana's config file.

download-csv

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I reviewed the code change

I'd like to get release notes typed into the description before it's merged. This merits some nice writeup since it's a big, often-requested feature

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. ++ on release notes.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joelgriffith joelgriffith merged commit 2e279aa into elastic:master Aug 27, 2019
simianhacker pushed a commit to simianhacker/kibana that referenced this pull request Aug 27, 2019
* Enable panel-action downloads by default

* Updating snapshots
joelgriffith pushed a commit that referenced this pull request Aug 27, 2019
* Enable panel-action downloads by default

* Updating snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:enhancement v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants