Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] update monitor list configs for mobile view #43218

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Aug 13, 2019

Summary

Issue: #40579

Improve monitor list view for mobile and as well as align it with EUI implementation and guidelines

before this PR it looked like this
image
after PR it will be like this
image

Checklist

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@shahzad31 shahzad31 force-pushed the fix/issue-40579-inconsistent-use-of-expandable-row-component branch from 6675b36 to e3991a7 Compare August 14, 2019 10:19
@shahzad31 shahzad31 marked this pull request as ready for review August 14, 2019 10:27
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@justinkambic
Copy link
Contributor

Tested locally, repro'd the issue and confirmed the patch has the expected UI changes:

master

Screen Shot 2019-08-14 at 4 17 46 PM

this branch

Screen Shot 2019-08-14 at 4 17 46 PM

Screen Shot 2019-08-14 at 4 27 56 PM

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahzad31 shahzad31 merged commit dbb140d into elastic:master Aug 15, 2019
@shahzad31 shahzad31 deleted the fix/issue-40579-inconsistent-use-of-expandable-row-component branch August 15, 2019 09:36
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 15, 2019
…p-metrics-selectall

* 'master' of github.com:elastic/kibana: (50 commits)
  [Uptime] update monitor list configs for mobile view (elastic#43218)
  [APM] Local UI filters (elastic#41588)
  [Code] Upgrade ctags langserver (elastic#43252)
  [Code] show multiple definition results in panel (elastic#43249)
  Adds Metric Type to full screen launch tracking (elastic#42692)
  [Canvas] Convert Autocomplete to Typescript (elastic#42502)
  [telemetry] add spacesEnabled config back to xpack_main (elastic#43312)
  [ML] Adds DF Transform Analytics list to Kibana management (elastic#43151)
  Add TLS client authentication support. (elastic#43090)
  [csp] Telemetry for csp configuration (elastic#43223)
  [SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (elastic#42804)
  docs: add tip on agent config in a dt (elastic#43301)
  [ML] Adding bucket span estimator to new wizards (elastic#43288)
  disable flaky tests (elastic#43017)
  Fix percy target branch for PRs (elastic#43160)
  [ML] Adding post create job options (elastic#43205)
  Restore discover histogram selection triggering fetch (elastic#43097)
  Per panel time range (elastic#43153)
  [Infra UI] Add APM to Metadata Endpoint (elastic#42197)
  Sentence case copy changes (elastic#43215)
  ...
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Aug 15, 2019
* update monitor list configs for mobile view

* [uptime] update unit test snapshot
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Sep 5, 2019
* update monitor list configs for mobile view

* [uptime] update unit test snapshot
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Sep 5, 2019
* update monitor list configs for mobile view

* [uptime] update unit test snapshot
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Sep 10, 2019
* update monitor list configs for mobile view

* [uptime] update unit test snapshot
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Sep 10, 2019
* update monitor list configs for mobile view

* [uptime] update unit test snapshot
shahzad31 added a commit that referenced this pull request Sep 11, 2019
* update monitor list configs for mobile view

* [uptime] update unit test snapshot
shahzad31 added a commit that referenced this pull request Sep 12, 2019
* update monitor list configs for mobile view

* [uptime] update unit test snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants