Restore discover histogram selection triggering fetch #43097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
Feature:Discover
|
Pinging @elastic/kibana-app |
💚 Build Succeeded |
kertal
commented
Aug 12, 2019
| @@ -157,9 +159,9 @@ export default function ({ getService, getPageObjects }) { | |||
| await PageObjects.visualize.waitForVisualization(); | |||
|
|
|||
| const newDurationHours = await PageObjects.timePicker.getTimeDurationInHours(); | |||
| if (newDurationHours < 1 || newDurationHours >= 5) { | |||
| throw new Error(`expected new duration of ${newDurationHours} hours to be between 1 and 5 hours`); | |||
| } | |||
There was a problem hiding this comment.
dear @ryankeairns, just wanted to know if there's a reason to check a newDurationHours value to be lower then 1 or greater than 5 to fail. Rounding the value always returned 3 so far (tested locally + Jenkins )
💚 Build Succeeded |
TinaHeiligers
approved these changes
Aug 13, 2019
There was a problem hiding this comment.
I tested the changes in Chrome Version 76.0.3809.100 (Official Build) (64-bit), Safari Version 12.1.2 (14607.3.9) and Firefox 68.0.1 (64-bit) and the search request is issued when selecting on the histogram.
Without the fix, the selection does not trigger a fetch request.
Code LGTM.
…tore-discover-histogram-brush-trigger-refresh
💚 Build Succeeded |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Aug 14, 2019
* Listen to timefilter fetch event to start fetching * Improve functional test to catch error
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Aug 14, 2019
* Listen to timefilter fetch event to start fetching * Improve functional test to catch error
kertal
added a commit
that referenced
this pull request
Aug 14, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 15, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (50 commits) [Uptime] update monitor list configs for mobile view (elastic#43218) [APM] Local UI filters (elastic#41588) [Code] Upgrade ctags langserver (elastic#43252) [Code] show multiple definition results in panel (elastic#43249) Adds Metric Type to full screen launch tracking (elastic#42692) [Canvas] Convert Autocomplete to Typescript (elastic#42502) [telemetry] add spacesEnabled config back to xpack_main (elastic#43312) [ML] Adds DF Transform Analytics list to Kibana management (elastic#43151) Add TLS client authentication support. (elastic#43090) [csp] Telemetry for csp configuration (elastic#43223) [SIEM] Run Cypress Tests Against Elastic Cloud & Cypress Command Line / Reporting (elastic#42804) docs: add tip on agent config in a dt (elastic#43301) [ML] Adding bucket span estimator to new wizards (elastic#43288) disable flaky tests (elastic#43017) Fix percy target branch for PRs (elastic#43160) [ML] Adding post create job options (elastic#43205) Restore discover histogram selection triggering fetch (elastic#43097) Per panel time range (elastic#43153) [Infra UI] Add APM to Metadata Endpoint (elastic#42197) Sentence case copy changes (elastic#43215) ...
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Aug 15, 2019
* Listen to timefilter fetch event to start fetching * Improve functional test to catch error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When selecting a period in the discover histogram, no fetch was triggered, no new data was requested. The user had to submit the form manually. Fixes #42583
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately