From 2309bafeef588d50a58b5a4ef36d70896d27f384 Mon Sep 17 00:00:00 2001 From: Dave Snider Date: Wed, 7 Aug 2019 11:38:55 -0700 Subject: [PATCH 1/7] eui 13.3.0 --- package.json | 2 +- .../instruction_set.test.js.snap | 6 - .../saved_objects_installer.test.js.snap | 190 +++++++++--------- .../plugins/kbn_tp_run_pipeline/package.json | 2 +- .../kbn_tp_custom_visualizations/package.json | 2 +- .../kbn_tp_embeddable_explorer/package.json | 2 +- .../kbn_tp_sample_panel_action/package.json | 2 +- .../kbn_tp_visualize_embedding/package.json | 2 +- .../ServiceOverview.test.tsx.snap | 2 + x-pack/package.json | 2 +- yarn.lock | 8 +- 11 files changed, 108 insertions(+), 112 deletions(-) diff --git a/package.json b/package.json index 02f476a62810c6..739dcaa2d4914f 100644 --- a/package.json +++ b/package.json @@ -106,7 +106,7 @@ "@babel/register": "7.4.4", "@elastic/charts": "^7.2.1", "@elastic/datemath": "5.0.2", - "@elastic/eui": "13.1.1", + "@elastic/eui": "13.3.0", "@elastic/filesaver": "1.1.2", "@elastic/good": "8.1.1-kibana2", "@elastic/numeral": "2.3.3", diff --git a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/instruction_set.test.js.snap b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/instruction_set.test.js.snap index 9b50b31448ecc1..6004cde57773bd 100644 --- a/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/instruction_set.test.js.snap +++ b/src/legacy/core_plugins/kibana/public/home/components/tutorial/__snapshots__/instruction_set.test.js.snap @@ -49,7 +49,6 @@ exports[`render 1`] = ` /> - - + - - Incomplete Step - -   - - - -
- - -

+ + + - Load Kibana objects -

- +

+ Load Kibana objects +

+ +
@@ -427,8 +428,6 @@ exports[`bulkCreate should display success message when bulkCreate is successful } > - - - - Step - -   - - - -
- - - - - - - - - -
- - -

+ + + + + + +

+ + + - Load Kibana objects -

- +

+ Load Kibana objects +

+ +
@@ -658,8 +660,6 @@ exports[`bulkCreate should display success message when bulkCreate is successful exports[`renders 1`] = ` Date: Wed, 7 Aug 2019 12:28:02 -0400 Subject: [PATCH 2/7] add i18n tokens for date picker and update button --- src/core/public/i18n/i18n_service.tsx | 44 ++++++++++++++++++++++++++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/src/core/public/i18n/i18n_service.tsx b/src/core/public/i18n/i18n_service.tsx index 78411a7a418d79..dea6960b87a1ec 100644 --- a/src/core/public/i18n/i18n_service.tsx +++ b/src/core/public/i18n/i18n_service.tsx @@ -50,7 +50,7 @@ export class I18nService { defaultMessage: 'Select this row', description: 'ARIA and displayed label on a checkbox to select a single table row', }), - 'euiBasicTable.tableDescription': ({ itemCount }: EuiValues) => + '˜': ({ itemCount }: EuiValues) => i18n.translate('core.euiBasicTable.tableDescription', { defaultMessage: 'Below is a table of {itemCount} items.', values: { itemCount }, @@ -285,6 +285,13 @@ export class I18nService { description: 'Used as the title attribute on an image or svg icon to indicate a given process step is complete', }), + 'euiSuperDatePicker.showDatesButtonLabel': i18n.translate( + 'core.euiSuperDatePicker.showDatesButtonLabel', + { + defaultMessage: 'Show dates', + description: 'Displayed in a button that shows date picker', + } + ), 'euiSuperSelect.screenReaderAnnouncement': ({ optionsCount }: EuiValues) => i18n.translate('core.euiSuperSelect.screenReaderAnnouncement', { defaultMessage: @@ -296,6 +303,41 @@ export class I18nService { defaultMessage: 'Select an option: {selectedValue}, is selected', values: { selectedValue }, }), + 'euiSuperUpdateButton.cannotUpdateTooltip': i18n.translate( + 'core.euiSuperUpdateButton.cannotUpdateTooltip', + { + defaultMessage: 'Cannot update', + description: "Displayed in a tooltip when updates can't happen", + } + ), + 'euiSuperUpdateButton.clickToApplyTooltip': i18n.translate( + 'core.euiSuperUpdateButton.clickToApplyTooltip', + { + defaultMessage: 'Click to apply', + description: "Displayed in a tooltip when there are changes that haven't been applied", + } + ), + 'euiSuperUpdateButton.refreshButtonLabel': i18n.translate( + 'core.euiSuperUpdateButton.refreshButtonLabel', + { + defaultMessage: 'Refresh', + description: 'Displayed in a button that refreshes based on date picked', + } + ), + 'euiSuperUpdateButton.updatingButtonLabel': i18n.translate( + 'core.euiSuperUpdateButton.updatingButtonLabel', + { + defaultMessage: 'Updating', + description: 'Displayed in a button that refreshes when updates are happening', + } + ), + 'euiSuperUpdateButton.updateButtonLabel': i18n.translate( + 'core.euiSuperUpdateButton.updateButtonLabel', + { + defaultMessage: 'Uodate', + description: 'Displayed in a button that updates based on date picked', + } + ), 'euiTablePagination.rowsPerPage': i18n.translate('core.euiTablePagination.rowsPerPage', { defaultMessage: 'Rows per page', description: 'Displayed in a button that toggles a table pagination menu', From 5e325b93197f42257ac7105dffd019d28a2bc3eb Mon Sep 17 00:00:00 2001 From: Bill McConaghy Date: Wed, 7 Aug 2019 16:03:33 -0400 Subject: [PATCH 3/7] fixing jest test for i18n_service --- .../public/i18n/__snapshots__/i18n_service.test.tsx.snap | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/core/public/i18n/__snapshots__/i18n_service.test.tsx.snap b/src/core/public/i18n/__snapshots__/i18n_service.test.tsx.snap index 0910635924ea26..728260f41c86b2 100644 --- a/src/core/public/i18n/__snapshots__/i18n_service.test.tsx.snap +++ b/src/core/public/i18n/__snapshots__/i18n_service.test.tsx.snap @@ -8,7 +8,6 @@ exports[`#start() returns \`Context\` component 1`] = ` "mapping": Object { "euiBasicTable.selectAllRows": "Select all rows", "euiBasicTable.selectThisRow": "Select this row", - "euiBasicTable.tableDescription": [Function], "euiBottomBar.screenReaderAnnouncement": "There is a new menu opening with page level controls at the end of the document.", "euiCardSelect.select": "Select", "euiCardSelect.selected": "Selected", @@ -54,14 +53,21 @@ exports[`#start() returns \`Context\` component 1`] = ` "euiStepNumber.hasErrors": "has errors", "euiStepNumber.hasWarnings": "has warnings", "euiStepNumber.isComplete": "complete", + "euiSuperDatePicker.showDatesButtonLabel": "Show dates", "euiSuperSelect.screenReaderAnnouncement": [Function], "euiSuperSelectControl.selectAnOption": [Function], + "euiSuperUpdateButton.cannotUpdateTooltip": "Cannot update", + "euiSuperUpdateButton.clickToApplyTooltip": "Click to apply", + "euiSuperUpdateButton.refreshButtonLabel": "Refresh", + "euiSuperUpdateButton.updateButtonLabel": "Uodate", + "euiSuperUpdateButton.updatingButtonLabel": "Updating", "euiTablePagination.rowsPerPage": "Rows per page", "euiTablePagination.rowsPerPageOption": [Function], "euiTableSortMobile.sorting": "Sorting", "euiToast.dismissToast": "Dismiss toast", "euiToast.newNotification": "A new notification appears", "euiToast.notification": "Notification", + "˜": [Function], }, } } From d25d689ebc319a60f4921a3c54e4684a0da5f2fa Mon Sep 17 00:00:00 2001 From: Bill McConaghy Date: Thu, 8 Aug 2019 09:20:11 -0400 Subject: [PATCH 4/7] fixing typo --- src/core/public/i18n/i18n_service.tsx | 44 +-------------------------- 1 file changed, 1 insertion(+), 43 deletions(-) diff --git a/src/core/public/i18n/i18n_service.tsx b/src/core/public/i18n/i18n_service.tsx index dea6960b87a1ec..78411a7a418d79 100644 --- a/src/core/public/i18n/i18n_service.tsx +++ b/src/core/public/i18n/i18n_service.tsx @@ -50,7 +50,7 @@ export class I18nService { defaultMessage: 'Select this row', description: 'ARIA and displayed label on a checkbox to select a single table row', }), - '˜': ({ itemCount }: EuiValues) => + 'euiBasicTable.tableDescription': ({ itemCount }: EuiValues) => i18n.translate('core.euiBasicTable.tableDescription', { defaultMessage: 'Below is a table of {itemCount} items.', values: { itemCount }, @@ -285,13 +285,6 @@ export class I18nService { description: 'Used as the title attribute on an image or svg icon to indicate a given process step is complete', }), - 'euiSuperDatePicker.showDatesButtonLabel': i18n.translate( - 'core.euiSuperDatePicker.showDatesButtonLabel', - { - defaultMessage: 'Show dates', - description: 'Displayed in a button that shows date picker', - } - ), 'euiSuperSelect.screenReaderAnnouncement': ({ optionsCount }: EuiValues) => i18n.translate('core.euiSuperSelect.screenReaderAnnouncement', { defaultMessage: @@ -303,41 +296,6 @@ export class I18nService { defaultMessage: 'Select an option: {selectedValue}, is selected', values: { selectedValue }, }), - 'euiSuperUpdateButton.cannotUpdateTooltip': i18n.translate( - 'core.euiSuperUpdateButton.cannotUpdateTooltip', - { - defaultMessage: 'Cannot update', - description: "Displayed in a tooltip when updates can't happen", - } - ), - 'euiSuperUpdateButton.clickToApplyTooltip': i18n.translate( - 'core.euiSuperUpdateButton.clickToApplyTooltip', - { - defaultMessage: 'Click to apply', - description: "Displayed in a tooltip when there are changes that haven't been applied", - } - ), - 'euiSuperUpdateButton.refreshButtonLabel': i18n.translate( - 'core.euiSuperUpdateButton.refreshButtonLabel', - { - defaultMessage: 'Refresh', - description: 'Displayed in a button that refreshes based on date picked', - } - ), - 'euiSuperUpdateButton.updatingButtonLabel': i18n.translate( - 'core.euiSuperUpdateButton.updatingButtonLabel', - { - defaultMessage: 'Updating', - description: 'Displayed in a button that refreshes when updates are happening', - } - ), - 'euiSuperUpdateButton.updateButtonLabel': i18n.translate( - 'core.euiSuperUpdateButton.updateButtonLabel', - { - defaultMessage: 'Uodate', - description: 'Displayed in a button that updates based on date picked', - } - ), 'euiTablePagination.rowsPerPage': i18n.translate('core.euiTablePagination.rowsPerPage', { defaultMessage: 'Rows per page', description: 'Displayed in a button that toggles a table pagination menu', From d16927fac92f28377f5a755dedeba6af3cb8d22b Mon Sep 17 00:00:00 2001 From: Bill McConaghy Date: Thu, 8 Aug 2019 09:22:13 -0400 Subject: [PATCH 5/7] Revert "fixing typo" This reverts commit d25d689ebc319a60f4921a3c54e4684a0da5f2fa. --- src/core/public/i18n/i18n_service.tsx | 44 ++++++++++++++++++++++++++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/src/core/public/i18n/i18n_service.tsx b/src/core/public/i18n/i18n_service.tsx index 78411a7a418d79..dea6960b87a1ec 100644 --- a/src/core/public/i18n/i18n_service.tsx +++ b/src/core/public/i18n/i18n_service.tsx @@ -50,7 +50,7 @@ export class I18nService { defaultMessage: 'Select this row', description: 'ARIA and displayed label on a checkbox to select a single table row', }), - 'euiBasicTable.tableDescription': ({ itemCount }: EuiValues) => + '˜': ({ itemCount }: EuiValues) => i18n.translate('core.euiBasicTable.tableDescription', { defaultMessage: 'Below is a table of {itemCount} items.', values: { itemCount }, @@ -285,6 +285,13 @@ export class I18nService { description: 'Used as the title attribute on an image or svg icon to indicate a given process step is complete', }), + 'euiSuperDatePicker.showDatesButtonLabel': i18n.translate( + 'core.euiSuperDatePicker.showDatesButtonLabel', + { + defaultMessage: 'Show dates', + description: 'Displayed in a button that shows date picker', + } + ), 'euiSuperSelect.screenReaderAnnouncement': ({ optionsCount }: EuiValues) => i18n.translate('core.euiSuperSelect.screenReaderAnnouncement', { defaultMessage: @@ -296,6 +303,41 @@ export class I18nService { defaultMessage: 'Select an option: {selectedValue}, is selected', values: { selectedValue }, }), + 'euiSuperUpdateButton.cannotUpdateTooltip': i18n.translate( + 'core.euiSuperUpdateButton.cannotUpdateTooltip', + { + defaultMessage: 'Cannot update', + description: "Displayed in a tooltip when updates can't happen", + } + ), + 'euiSuperUpdateButton.clickToApplyTooltip': i18n.translate( + 'core.euiSuperUpdateButton.clickToApplyTooltip', + { + defaultMessage: 'Click to apply', + description: "Displayed in a tooltip when there are changes that haven't been applied", + } + ), + 'euiSuperUpdateButton.refreshButtonLabel': i18n.translate( + 'core.euiSuperUpdateButton.refreshButtonLabel', + { + defaultMessage: 'Refresh', + description: 'Displayed in a button that refreshes based on date picked', + } + ), + 'euiSuperUpdateButton.updatingButtonLabel': i18n.translate( + 'core.euiSuperUpdateButton.updatingButtonLabel', + { + defaultMessage: 'Updating', + description: 'Displayed in a button that refreshes when updates are happening', + } + ), + 'euiSuperUpdateButton.updateButtonLabel': i18n.translate( + 'core.euiSuperUpdateButton.updateButtonLabel', + { + defaultMessage: 'Uodate', + description: 'Displayed in a button that updates based on date picked', + } + ), 'euiTablePagination.rowsPerPage': i18n.translate('core.euiTablePagination.rowsPerPage', { defaultMessage: 'Rows per page', description: 'Displayed in a button that toggles a table pagination menu', From 86c63f1e84a67930bc898a18ba0ab5abfc5abc52 Mon Sep 17 00:00:00 2001 From: Bill McConaghy Date: Thu, 8 Aug 2019 09:23:45 -0400 Subject: [PATCH 6/7] fixing typo and test --- src/core/public/i18n/__snapshots__/i18n_service.test.tsx.snap | 2 +- src/core/public/i18n/i18n_service.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/public/i18n/__snapshots__/i18n_service.test.tsx.snap b/src/core/public/i18n/__snapshots__/i18n_service.test.tsx.snap index 728260f41c86b2..e6fd864bcedd9d 100644 --- a/src/core/public/i18n/__snapshots__/i18n_service.test.tsx.snap +++ b/src/core/public/i18n/__snapshots__/i18n_service.test.tsx.snap @@ -8,6 +8,7 @@ exports[`#start() returns \`Context\` component 1`] = ` "mapping": Object { "euiBasicTable.selectAllRows": "Select all rows", "euiBasicTable.selectThisRow": "Select this row", + "euiBasicTable.tableDescription": [Function], "euiBottomBar.screenReaderAnnouncement": "There is a new menu opening with page level controls at the end of the document.", "euiCardSelect.select": "Select", "euiCardSelect.selected": "Selected", @@ -67,7 +68,6 @@ exports[`#start() returns \`Context\` component 1`] = ` "euiToast.dismissToast": "Dismiss toast", "euiToast.newNotification": "A new notification appears", "euiToast.notification": "Notification", - "˜": [Function], }, } } diff --git a/src/core/public/i18n/i18n_service.tsx b/src/core/public/i18n/i18n_service.tsx index dea6960b87a1ec..66c24a6557ca04 100644 --- a/src/core/public/i18n/i18n_service.tsx +++ b/src/core/public/i18n/i18n_service.tsx @@ -50,7 +50,7 @@ export class I18nService { defaultMessage: 'Select this row', description: 'ARIA and displayed label on a checkbox to select a single table row', }), - '˜': ({ itemCount }: EuiValues) => + 'euiBasicTable.tableDescription': ({ itemCount }: EuiValues) => i18n.translate('core.euiBasicTable.tableDescription', { defaultMessage: 'Below is a table of {itemCount} items.', values: { itemCount }, From a6afbeef4af3dceb7f49d85818d439dc7684fa87 Mon Sep 17 00:00:00 2001 From: spalger Date: Tue, 20 Aug 2019 11:13:36 -0700 Subject: [PATCH 7/7] disable test until we can fix the way that plugins are included in the tests --- .../test_suites/custom_visualizations/self_changing_vis.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/plugin_functional/test_suites/custom_visualizations/self_changing_vis.js b/test/plugin_functional/test_suites/custom_visualizations/self_changing_vis.js index cca6ba4339747e..73f3ffef63135c 100644 --- a/test/plugin_functional/test_suites/custom_visualizations/self_changing_vis.js +++ b/test/plugin_functional/test_suites/custom_visualizations/self_changing_vis.js @@ -32,7 +32,7 @@ export default function ({ getService, getPageObjects }) { return await testSubjects.getAttribute('counterEditor', 'value'); } - describe('self changing vis', function describeIndexTests() { + describe.skip('self changing vis', function describeIndexTests() { before(async () => { await PageObjects.visualize.navigateToNewVisualization();