-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/bump chromium webgl+kerberos #42751
Merged
joelgriffith
merged 32 commits into
elastic:master
from
joelgriffith:chore/bump-chromium-webgl-kerberos
Aug 27, 2019
Merged
Changes from 29 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
7866be2
WIP: Adding libs for webgl
83a9d4d
WIP Adding swiftshader libs to chromium
3e68905
WIP: Adding missing binaries for webgl in chromium
87d1528
Use pipes for communication with chrome to avoid networking snafus
0951604
Merge remote-tracking branch 'upstream/master'
b35b6ff
Merge remote-tracking branch 'upstream/master'
02b5257
Merge remote-tracking branch 'upstream/master'
b4995c5
Merge remote-tracking branch 'upstream/master'
33f2a0b
Bumps puppeteer in prep for new chromium build + types and better @ty…
ac9088a
Remove ignore
26deffa
Removing of final @ts-ignore now that we have types
48c3134
README updates
e580990
Merge branch 'chore/roll-chromium-webgl' into chore/bump-chromium-web…
6810a47
Merge remote-tracking branch 'upstream/master' into chore/bump-chromi…
491be4e
Merge remote-tracking branch 'upstream/master'
680e0a5
Merge remote-tracking branch 'upstream/master'
91458db
Fixing binding issues
530d485
Merge remote-tracking branch 'upstream/master'
69a9b13
Merge branch 'master' into chore/bump-chromium-webgl-kerberos
42e4306
Merge remote-tracking branch 'upstream/master' into chore/bump-chromi…
7761486
Fixing maps integration wrt reporting + conditional pipes for puppeteer
96f0f41
Merge remote-tracking branch 'upstream/master' into chore/bump-chromi…
8ffbbfc
Adding new deps to the windows build
199b5cc
New s3 builds
f80ba30
Merge remote-tracking branch 'upstream/master' into chore/bump-chromi…
d184029
Merge remote-tracking branch 'upstream/master' into chore/bump-chromi…
bbf0e8f
Checksums for updated linux build
10e0648
Merge remote-tracking branch 'upstream/master' into chore/bump-chromi…
c929c59
Moving types out of puppeteer file and into core puppeteer module
aefc12f
launch => puppeteerLaunch
a0a13b3
Maps comment about render loading in reporting
59fd444
Clarify how reporting uses hooks and events for viz
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
x-pack/legacy/plugins/reporting/server/browsers/chromium/puppeteer.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
joelgriffith marked this conversation as resolved.
Show resolved
Hide resolved
|
||
import puppeteer from 'puppeteer'; | ||
// @ts-ignore lacking typedefs which this module fixes | ||
import puppeteerCore from 'puppeteer-core'; | ||
|
||
export const launch: ( | ||
opts?: puppeteer.LaunchOptions | ||
) => Promise<puppeteer.Browser> = puppeteerCore.launch.bind(puppeteerCore); | ||
joelgriffith marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is existing, but stands out a little, and I'm wondering why we have it in the Darwin build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have to look again. The binary fails to start wo it, however I'm not sure as to why