[ML] Kibana management jobs list #42570

alvarezmelissa87 · 2019-08-05T03:32:27Z

Summary

In preparation for space-aware jobs, provides a place where users can view all jobs.

Adds ML section and Jobs list subsection to Kibana management page.
Displays all jobs in table.
job id in table links to job management in ML
all functionality present in ML's job management tab is also in this table including filtering, search, pagination, list refresh, and expanded rows with job stats.

Expanded row

View if required permissions are not met:

To be added in follow-up PRs

disable the links to the Jobs list (inside ML) and the results views if ML is not enabled in the space
Hide actions column in management table if ML not enabled in the space

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~- [ ] Documentation was added for features that require explanation or tutorials~~
~~- [ ] Unit or functional tests were updated or added to match the most common scenarios~~
This was checked for keyboard-only and screenreader accessibility

For maintainers

~~- [ ] This was checked for breaking API changes and was labeled appropriately~~
~~- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

elasticmachine · 2019-08-05T03:32:41Z

Pinging @elastic/ml-ui

elasticmachine · 2019-08-05T04:33:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-05T21:06:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-05T22:13:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-06T16:33:24Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

walterra

Overall LGTM, great job! Just added a few comments/questions.

x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/job_details/job_details.js

x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/job_group/job_group.js

x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/jobs_list/jobs_list.js

x-pack/legacy/plugins/ml/public/management/jobs_list/index.ts

x-pack/legacy/plugins/ml/public/index.scss

elasticmachine · 2019-08-07T23:57:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-08T17:09:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

… to be true

jgowdyelastic · 2019-08-08T20:59:11Z

x-pack/legacy/plugins/ml/public/privilege/check_privilege.ts

+      privileges = capabilities;
+      // Loop through all privilages to ensure they are all set to true.
+      const isManageML = Object.keys(privileges).every(
+        privilegeType => privileges[privilegeType as PrivilageKey] === true


this is a nice typescripty solution to get round the strictness of looping over interface keys, but it could be avoided by using Object.values

const isManageML = Object.values(privileges).every(p => p === true);

Updated in 9d707f9

elasticmachine · 2019-08-08T21:40:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

jgowdyelastic · 2019-08-09T09:49:18Z

x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/job_details/job_details.js

      ];

-      if (mlAnnotationsEnabled) {
+      if (fullDetails) {


nit, it's not immediately clear what fullDetails is, especially when used in a truthy check like this.
perhaps showFullDetails would be clearer.

isManagementTable is used later on, perhaps it should also be used here?

Updated to showFullDetails - 9d707f9

x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/job_filter_bar/job_filter_bar.js

jgowdyelastic · 2019-08-09T10:42:00Z

x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/jobs_list/jobs_list.js

+    // Adding 'width' props to columns for use in the Kibana management jobs list table
+    // The version of the table used in ML > Job Managment depends on many EUI class overrides that set the width explicitly.
+    // The ML > Job Managment table won't change as the overwritten class styles take precedence, though these values may need to
+    // be updated if we move to always using props for width.


css overrides where originally used because it wasn't possible to add widths to the column objects.
it would be good to remove the css overrides and have all widths here.
This could be done in a follow up PR

jgowdyelastic · 2019-08-09T10:44:53Z

x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/utils.js

+    jobId
+  };
+  const encoded = rison.encode(settings);
+  const url = `?mlManagement=${encoded}`;


is mlManagement needed in the URL?
the jobId may be enough.

I wanted it to be explicit and it gets removed from the url as soon as the filter is cleared.

peteharverson · 2019-08-09T11:39:52Z

x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/jobs_list/jobs_list.js

@@ -75,6 +79,14 @@ class JobsListUI extends Component {
    this.props.toggleRow(item.id);
  };

+  getJobIdLink(id) {


Is it possible to disable the links to the Jobs list (inside ML) and the results views if ML is not enabled in the space? Currently in that situation you just get the page with the {"statusCode":404,"error":"Not Found","message":"Not Found"} error message

Added as TODO in a follow-up 👍

peteharverson · 2019-08-09T12:31:52Z

x-pack/legacy/plugins/ml/public/management/jobs_list/components/access_denied_page.tsx

+  EuiTitle,
+} from '@elastic/eui';
+
+export const AccessDeniedPage = () => (


This page shows up if the user is on a basic license. Just checking if the ML management menu should be hidden altogether?

from the discussions we had, the expected behaviour was that if the licence and feature checks fail, the ML section would be disabled altogether.
this is checked using features.ml.showLinks

Good catch - updated in 9d707f9

peteharverson · 2019-08-09T12:34:28Z

x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/jobs_list/jobs_list.js

      }, {
+        name: intl.formatMessage({


As above, is it possible to hide this column if ML is not enabled in the space?

Added as a TODO in a follow-up 👍

peteharverson · 2019-08-09T12:36:44Z

x-pack/legacy/plugins/ml/public/jobs/jobs_list/components/utils.js

@@ -7,6 +7,8 @@
 import { each } from 'lodash';
 import { toastNotifications } from 'ui/notify';
 import { mlMessageBarService } from 'plugins/ml/components/messagebar/messagebar_service';
+import rison from 'rison-node';
+import chrome from 'ui/chrome'; // TODO: get from context once walter's PR is merged


Can you use the new use_ui_chrome_context custom hook here?

peteharverson · 2019-08-09T12:50:33Z

x-pack/legacy/plugins/ml/public/management/index.js

+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { management } from 'ui/management';


Could this new file be TypeScript?

Updated in 9d707f9

jgowdyelastic

LGTM

elasticmachine · 2019-08-09T17:36:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…p-metrics-selectall * 'master' of github.com:elastic/kibana: (22 commits) [Code]: downgrade the log level of error message from subprocess (elastic#42925) [Code] Cancel clone/update job in the middle if disk space over the watermark (elastic#42890) Add Kibana App specific URL to the help menu (elastic#34739) (elastic#42580) [Maps] refactor createShapeFilterWithMeta to support more than just polygons (elastic#43042) Skip flaky es_ui_shared/request tests. Pass uiSettings to all data plugin services (elastic#42159) [SIEM] Upgrades react-redux and utilize React.memo for performance gains (elastic#43029) [skip-ci][Maps] add maki icon sheet to docs (elastic#43063) Adding "style-src 'unsafe-inline' 'self'" to default CSP rules (elastic#41305) Update dependency commander to v3 (elastic#43041) Update dependency @percy/agent to ^0.10.0 (elastic#40517) [Maps] only show top hits checkbox if index has date fields (elastic#43056) run chained_controls on Firefox to catch regression (elastic#43044) fixing issue with dashboard csv download (elastic#42964) Expose task manager as plugin instead of server argument (elastic#42966) Expose createRouter from HttpService, prepare handlers for context introduction (elastic#42686) [Code] disk watermark supports percentage and absolute modes (elastic#42987) [apps/dashboard] skip part of filtering tests on FF (elastic#43047) [ML] Kibana management jobs list (elastic#42570) [ML] Fix check for watcher being enabled (elastic#43025) ...

alvarezmelissa87 requested review from a team as code owners August 5, 2019 03:32

alvarezmelissa87 added the :ml label Aug 5, 2019

alvarezmelissa87 added release_note:enhancement v7.4.0 labels Aug 5, 2019

alvarezmelissa87 force-pushed the ml-job-list-kibana-management branch from f8fc074 to 0d1cf35 Compare August 5, 2019 03:35

alvarezmelissa87 self-assigned this Aug 5, 2019

alvarezmelissa87 changed the title ~~WIP [ML] Kibana management jobs list~~ [ML] Kibana management jobs list Aug 6, 2019

alvarezmelissa87 requested review from peteharverson, jgowdyelastic and walterra August 6, 2019 15:31

walterra approved these changes Aug 7, 2019

View reviewed changes

alvarezmelissa87 added 11 commits August 8, 2019 16:15

Add Ml link section to management page

79c9fa7

Use job management table in kibana management

b2f3116

add tabs and breadcrumbs

70942ea

link to filtered job manangement table

aeb879c

Reduce expanded row tabs shown in management table

d532c9d

add KM job list section styles

cb358b3

Only anomaly detection jobs tab for now

fb5e70b

wip: adds access denied page

3f7805b

fix types

966559e

update mlManagement permission check to check license

995a0eb

update permissions check for manage_ml

9b1e564

alvarezmelissa87 added 2 commits August 8, 2019 16:20

Update permission check to manage_ml

56c8167

update privileges key type

7b1d091

alvarezmelissa87 force-pushed the ml-job-list-kibana-management branch from 672dc02 to 7b1d091 Compare August 8, 2019 20:22

if spaces is disabled or ignoreSpace is true force isMlEnabledInSpace…

4366eb0

… to be true

jgowdyelastic reviewed Aug 8, 2019

View reviewed changes

jgowdyelastic reviewed Aug 9, 2019

View reviewed changes

peteharverson reviewed Aug 9, 2019

View reviewed changes

alvarezmelissa87 requested a review from lukeelmers August 9, 2019 15:47

remove id from filter on clear

9d707f9

jgowdyelastic approved these changes Aug 9, 2019

View reviewed changes

alvarezmelissa87 merged commit acabe3d into elastic:master Aug 9, 2019

alvarezmelissa87 mentioned this pull request Aug 9, 2019

[7.x] [ML] Kibana management jobs list (#42570) #43049

Merged

alvarezmelissa87 deleted the ml-job-list-kibana-management branch August 9, 2019 20:02

alvarezmelissa87 mentioned this pull request Aug 12, 2019

[ML] Adds DF Transform Analytics list to Kibana management #43151

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Kibana management jobs list #42570

[ML] Kibana management jobs list #42570

alvarezmelissa87 commented Aug 5, 2019 •

edited

Loading

elasticmachine commented Aug 5, 2019

elasticmachine commented Aug 5, 2019

elasticmachine commented Aug 5, 2019

elasticmachine commented Aug 5, 2019

elasticmachine commented Aug 6, 2019

walterra left a comment

elasticmachine commented Aug 7, 2019

elasticmachine commented Aug 8, 2019

jgowdyelastic Aug 8, 2019

alvarezmelissa87 Aug 9, 2019

elasticmachine commented Aug 8, 2019

jgowdyelastic Aug 9, 2019

jgowdyelastic Aug 9, 2019

alvarezmelissa87 Aug 9, 2019

jgowdyelastic Aug 9, 2019

jgowdyelastic Aug 9, 2019

alvarezmelissa87 Aug 9, 2019

peteharverson Aug 9, 2019

alvarezmelissa87 Aug 9, 2019

peteharverson Aug 9, 2019

jgowdyelastic Aug 9, 2019 •

edited

Loading

alvarezmelissa87 Aug 9, 2019

peteharverson Aug 9, 2019

alvarezmelissa87 Aug 9, 2019

peteharverson Aug 9, 2019

peteharverson Aug 9, 2019

alvarezmelissa87 Aug 9, 2019

jgowdyelastic left a comment

elasticmachine commented Aug 9, 2019

[ML] Kibana management jobs list #42570

[ML] Kibana management jobs list #42570

Conversation

alvarezmelissa87 commented Aug 5, 2019 • edited Loading

Summary

To be added in follow-up PRs

Checklist

For maintainers

elasticmachine commented Aug 5, 2019

elasticmachine commented Aug 5, 2019

💚 Build Succeeded

elasticmachine commented Aug 5, 2019

💔 Build Failed

elasticmachine commented Aug 5, 2019

💚 Build Succeeded

elasticmachine commented Aug 6, 2019

💔 Build Failed

walterra left a comment

Choose a reason for hiding this comment

elasticmachine commented Aug 7, 2019

💚 Build Succeeded

elasticmachine commented Aug 8, 2019

💔 Build Failed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Aug 8, 2019

💚 Build Succeeded

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jgowdyelastic Aug 9, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jgowdyelastic left a comment

Choose a reason for hiding this comment

elasticmachine commented Aug 9, 2019

💚 Build Succeeded

alvarezmelissa87 commented Aug 5, 2019 •

edited

Loading

jgowdyelastic Aug 9, 2019 •

edited

Loading