Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML] Use NavigationMenu without angularjs wrapper. (#41343) #41764

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

walterra
Copy link
Contributor

Backports the following commits to 7.x:

Follow up to elastic#40830 and elastic#41054 in preparation for single metric viewer migration.
The previous PR introduced the navigation menu as a React component. This PR moves dependencies down from the angularjs wrapper directive directly to the React component so the component can also be used stand-alone without the angularjs wrapper.
For simple angularjs based HTML templates this stand-alone usage is also part of this PR. Unfortunately the PR turned out to be quite big due to: Most page react components had to be wrapped in another <Fragment> to allow the addition of <NavigationMenu> thus leading to large diffs for the components. All component code inside the <Fragment> was not touched though.
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@walterra walterra self-assigned this Jul 23, 2019
@walterra walterra added the :ml label Jul 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@walterra walterra merged commit b609354 into elastic:7.x Jul 23, 2019
@walterra walterra deleted the backport/7.x/pr-41343 branch July 23, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants