Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Fix draggables to work with escapeId for the ML severity column #41621

Merged
merged 2 commits into from
Jul 20, 2019
Merged

[SIEM] Fix draggables to work with escapeId for the ML severity column #41621

merged 2 commits into from
Jul 20, 2019

Conversation

FrankHassanabad
Copy link
Contributor

@FrankHassanabad FrankHassanabad commented Jul 19, 2019 •
edited
Loading

Summary

Blocker bug where you could not drag and drop to the timeline.
drag-n-drop-issue-with-severity

Fix for host:
drag-and-dop-host

Fix for network:
network-drag-and-drop

One line fix for it so you can drag and drop to the timeline

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

- [ ] Documentation was added for features that require explanation or tutorials

- [ ] Unit or functional tests were updated or added to match the most common scenarios

- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately

- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@FrankHassanabad FrankHassanabad changed the title Fix draggables to work with escapeId for the ML severity column [SIEM] Fix draggables to work with escapeId for the ML severity column Jul 19, 2019
andrew-goldstein
andrew-goldstein reviewed Jul 19, 2019
View reviewed changes
x-pack/legacy/plugins/siem/public/components/load_more_table/index.tsx
@@ -110,7 +110,7 @@ export interface Columns<T, U = T> {
sortable?: boolean | Func<T>;
truncateText?: boolean;
hideForMobile?: boolean;
render?: (item: T, node: U) => void;
render?: (item: T, node: U) => React.ReactNode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this type

@FrankHassanabad FrankHassanabad self-assigned this Jul 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/secops

@FrankHassanabad FrankHassanabad added the loe:small Small Level of Effort label Jul 19, 2019
@spong spong added the release_note:skip Skip the PR/issue when compiling release notes label Jul 19, 2019
andrew-goldstein
andrew-goldstein approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spong
spong approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this quick-fix!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@FrankHassanabad FrankHassanabad merged commit 5a06491 into elastic:master Jul 20, 2019
@FrankHassanabad FrankHassanabad deleted the fix-severity-draggable branch July 20, 2019 00:23
@FrankHassanabad FrankHassanabad mentioned this pull request Jul 20, 2019
Merged
FrankHassanabad added a commit to FrankHassanabad/kibana that referenced this pull request Jul 20, 2019
@FrankHassanabad
[SIEM] Fix draggables to work with escapeId for the ML severity column (
1093062 
elastic#41621)

## Summary

Blocker bug where you could not drag and drop to the timeline.
![drag-n-drop-issue-with-severity](https://user-images.githubusercontent.com/1151048/61570279-cf12e500-aa48-11e9-967f-8ef0e6c8750b.gif)

Fix for host:
![drag-and-dop-host](https://user-images.githubusercontent.com/1151048/61570380-6aa45580-aa49-11e9-80e6-2a9e7fa7f650.gif)

Fix for network:
![network-drag-and-drop](https://user-images.githubusercontent.com/1151048/61570386-7132cd00-aa49-11e9-8342-1524aeb5093f.gif)


One line fix for it so you can drag and drop to the timeline 

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~

~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~

~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~

~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~

~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
@FrankHassanabad FrankHassanabad mentioned this pull request Jul 20, 2019
Merged
FrankHassanabad added a commit to FrankHassanabad/kibana that referenced this pull request Jul 20, 2019
@FrankHassanabad
[SIEM] Fix draggables to work with escapeId for the ML severity column (
0341935 
elastic#41621)

## Summary

Blocker bug where you could not drag and drop to the timeline.
![drag-n-drop-issue-with-severity](https://user-images.githubusercontent.com/1151048/61570279-cf12e500-aa48-11e9-967f-8ef0e6c8750b.gif)

Fix for host:
![drag-and-dop-host](https://user-images.githubusercontent.com/1151048/61570380-6aa45580-aa49-11e9-80e6-2a9e7fa7f650.gif)

Fix for network:
![network-drag-and-drop](https://user-images.githubusercontent.com/1151048/61570386-7132cd00-aa49-11e9-8342-1524aeb5093f.gif)


One line fix for it so you can drag and drop to the timeline 

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~

~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~

~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~

~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~

~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
FrankHassanabad added a commit that referenced this pull request Jul 20, 2019
@FrankHassanabad
[SIEM] Fix draggables to work with escapeId for the ML severity column (
aa3f00e 
#41621) (#41626)

## Summary

Blocker bug where you could not drag and drop to the timeline.
![drag-n-drop-issue-with-severity](https://user-images.githubusercontent.com/1151048/61570279-cf12e500-aa48-11e9-967f-8ef0e6c8750b.gif)

Fix for host:
![drag-and-dop-host](https://user-images.githubusercontent.com/1151048/61570380-6aa45580-aa49-11e9-80e6-2a9e7fa7f650.gif)

Fix for network:
![network-drag-and-drop](https://user-images.githubusercontent.com/1151048/61570386-7132cd00-aa49-11e9-8342-1524aeb5093f.gif)


One line fix for it so you can drag and drop to the timeline 

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~

~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~

~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~

~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~

~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
FrankHassanabad added a commit that referenced this pull request Jul 20, 2019
@FrankHassanabad
[SIEM] Fix draggables to work with escapeId for the ML severity column (
479634d 
#41621) (#41627)

## Summary

Blocker bug where you could not drag and drop to the timeline.
![drag-n-drop-issue-with-severity](https://user-images.githubusercontent.com/1151048/61570279-cf12e500-aa48-11e9-967f-8ef0e6c8750b.gif)

Fix for host:
![drag-and-dop-host](https://user-images.githubusercontent.com/1151048/61570380-6aa45580-aa49-11e9-80e6-2a9e7fa7f650.gif)

Fix for network:
![network-drag-and-drop](https://user-images.githubusercontent.com/1151048/61570386-7132cd00-aa49-11e9-8342-1524aeb5093f.gif)


One line fix for it so you can drag and drop to the timeline 

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~

~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~

~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~

~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~

~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 22, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fix/rollup-jo…
4aeb768 
…b-panel-for-stopping-jobs

* 'master' of github.com:elastic/kibana: (58 commits)
  [DOCS] Timelion cleanup (elastic#41381)
  [Docs] Add simple phrase highlighting to Logs UI (elastic#41610)
  [Maps] Rename modules for clarity (elastic#41608)
  [Monitoring] Metricbeat migration net new user experience (elastic#39832)
  [Maps] Only color legend icon with dynamic color when dynamic config is complete (elastic#41607)
  [TSVB] [Markdown] markdown section do not render after change data parameter (elastic#41576)
  [Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega (elastic#41565)
  update dark mode tsvb test (elastic#41618)
  [i18n] .i18nrc file as the source of truth and enhance tooling (elastic#39774)
  Reactify Top Nav Menu (kbn_top_nav) (elastic#40262)
  fix(code/frontend): should update search results if search options change (elastic#41232)
  Use kibana-ci-proxy-cache for chrome and gecko drivers (elastic#41581)
  [SIEM] Fix draggables to work with escapeId for the ML severity column (elastic#41621)
  [Canvas] Updates esdocs default count to 1000 (elastic#41604)
  [Uptime] Fix duration chart for Safari (elastic#41619)
  [Canvas] Restores "Today" as a quick time range in time filter (elastic#41528)
  docs: lowercase app (elastic#41612)
  [Code] Update git repository update frequency (elastic#41541)
  Remove language=json on code blocks due to performance hit (elastic#41540)
  [DOCS] Update anchors and links for Elasticserach API relocation. (elastic#41372)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees

@FrankHassanabad FrankHassanabad

Labels
loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.3.0 v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FrankHassanabad @elasticmachine @spong @andrew-goldstein