Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] [Markdown] markdown section do not render after change data parameter #41576

Merged
merged 3 commits into from
Jul 22, 2019

Conversation

alexwizp
Copy link
Contributor

Closes: #41466

Summary

Markdown section does not render after the set variable name. As a result, you can see that issue(see screen below)

Regression of #37185

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💔 Build Failed

@alexwizp alexwizp marked this pull request as ready for review July 19, 2019 15:36
@alexwizp alexwizp requested a review from a team July 19, 2019 15:36
@alexwizp alexwizp added regression v7.4.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 19, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes labels Jul 19, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally

@@ -37,8 +37,7 @@ export default function({ getPageObjects }: FtrProviderContext) {
});
}

// FAILING: https://github.com/elastic/kibana/issues/41452
describe.skip('visual builder', function describeIndexTests() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@alexwizp alexwizp merged commit 1061f69 into elastic:master Jul 22, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jul 22, 2019
…rameter (elastic#41576)

* [TSVB] [Markdown] markdown section do not render after change data parameter

* fix grammar
alexwizp added a commit that referenced this pull request Jul 22, 2019
…rameter (#41576) (#41661)

* [TSVB] [Markdown] markdown section do not render after change data parameter

* fix grammar
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Jul 22, 2019
…rameter (elastic#41576) (elastic#41661)

* [TSVB] [Markdown] markdown section do not render after change data parameter

* fix grammar
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 22, 2019
…b-panel-for-stopping-jobs

* 'master' of github.com:elastic/kibana: (58 commits)
  [DOCS] Timelion cleanup (elastic#41381)
  [Docs] Add simple phrase highlighting to Logs UI (elastic#41610)
  [Maps] Rename modules for clarity (elastic#41608)
  [Monitoring] Metricbeat migration net new user experience (elastic#39832)
  [Maps] Only color legend icon with dynamic color when dynamic config is complete (elastic#41607)
  [TSVB] [Markdown] markdown section do not render after change data parameter (elastic#41576)
  [Vega] (Step 2) Shim new platform - renaming vega -> vis_type_vega (elastic#41565)
  update dark mode tsvb test (elastic#41618)
  [i18n] .i18nrc file as the source of truth and enhance tooling (elastic#39774)
  Reactify Top Nav Menu (kbn_top_nav) (elastic#40262)
  fix(code/frontend): should update search results if search options change (elastic#41232)
  Use kibana-ci-proxy-cache for chrome and gecko drivers (elastic#41581)
  [SIEM] Fix draggables to work with escapeId for the ML severity column (elastic#41621)
  [Canvas] Updates esdocs default count to 1000 (elastic#41604)
  [Uptime] Fix duration chart for Safari (elastic#41619)
  [Canvas] Restores "Today" as a quick time range in time filter (elastic#41528)
  docs: lowercase app (elastic#41612)
  [Code] Update git repository update frequency (elastic#41541)
  Remove language=json on code blocks due to performance hit (elastic#41540)
  [DOCS] Update anchors and links for Elasticserach API relocation. (elastic#41372)
  ...
@alexwizp alexwizp deleted the 41466 branch January 4, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) regression release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TSVB] [Markdown] markdown section do not render after change data parameter
4 participants