-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra UI] Add UI to customize Metrics Explorer chart style #41022
Merged
simianhacker
merged 12 commits into
elastic:master
from
simianhacker:metrics-explorer-chart-options
Jul 22, 2019
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2528c4a
Add UI to customize Metrics Explorer chart style
simianhacker c7c2bae
Re-order chart options form
simianhacker bf0347e
Adding chart options to TSVB link
simianhacker 1ce1d48
Rename line series to series chart
simianhacker 627cc49
Fixing chart context menu tests
simianhacker a3e621a
Adding test for calculate domain
simianhacker 47d3174
Merge branch 'master' of github.com:elastic/kibana into metrics-explo…
simianhacker a00642f
Merge branch 'master' of github.com:elastic/kibana into metrics-explo…
simianhacker 964a563
Ensure caclulateDomain returns numbers
simianhacker d527715
Merge branch 'master' of github.com:elastic/kibana into metrics-explo…
simianhacker 1e63715
Merge branch 'master' of github.com:elastic/kibana into metrics-explo…
simianhacker 49ea638
fixing typo
simianhacker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
166 changes: 166 additions & 0 deletions
166
x-pack/legacy/plugins/infra/public/components/metrics_explorer/chart_options.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,166 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import React, { useState, useCallback } from 'react'; | ||
import { InjectedIntl, injectI18n, FormattedMessage } from '@kbn/i18n/react'; | ||
import { | ||
EuiRadioGroup, | ||
EuiButtonEmpty, | ||
EuiPopover, | ||
EuiForm, | ||
EuiFormRow, | ||
EuiSwitch, | ||
} from '@elastic/eui'; | ||
import { | ||
MetricsExplorerChartOptions as ChartOptions, | ||
MetricsExplorerYAxisMode, | ||
MetricsExplorerChartType, | ||
} from '../../containers/metrics_explorer/use_metrics_explorer_options'; | ||
|
||
interface Props { | ||
chartOptions: ChartOptions; | ||
onChange: (options: ChartOptions) => void; | ||
intl: InjectedIntl; | ||
} | ||
|
||
export const MetricsExplorerChartOptions = injectI18n(({ chartOptions, onChange, intl }: Props) => { | ||
const [isPopoverOpen, setPopoverState] = useState<boolean>(false); | ||
|
||
const handleClosePopover = useCallback(() => { | ||
setPopoverState(false); | ||
}, []); | ||
|
||
const handleOpenPopover = useCallback(() => { | ||
setPopoverState(true); | ||
}, []); | ||
|
||
const button = ( | ||
<EuiButtonEmpty iconSide="left" iconType="eye" onClick={handleOpenPopover}> | ||
<FormattedMessage | ||
id="xpack.infra.metricsExplorer.customizeChartOptions" | ||
defaultMessage="Customize" | ||
/> | ||
</EuiButtonEmpty> | ||
); | ||
|
||
const yAxisRadios = [ | ||
{ | ||
id: MetricsExplorerYAxisMode.auto, | ||
label: intl.formatMessage({ | ||
id: 'xpack.infra.metricsExplorer.chartOptions.autoLabel', | ||
defaultMessage: 'Automatic (Min to Max)', | ||
}), | ||
}, | ||
{ | ||
id: MetricsExplorerYAxisMode.fromZero, | ||
label: intl.formatMessage({ | ||
id: 'xpack.infra.metricsExplorer.chartOptions.fromZeroLabel', | ||
defaultMessage: 'From Zero (0 to Max', | ||
}), | ||
}, | ||
]; | ||
|
||
const typeRadios = [ | ||
{ | ||
id: MetricsExplorerChartType.line, | ||
label: intl.formatMessage({ | ||
id: 'xpack.infra.metricsExplorer.chartOptions.lineLabel', | ||
defaultMessage: 'Line', | ||
}), | ||
}, | ||
{ | ||
id: MetricsExplorerChartType.area, | ||
label: intl.formatMessage({ | ||
id: 'xpack.infra.metricsExplorer.chartOptions.areaLabel', | ||
defaultMessage: 'Area', | ||
}), | ||
}, | ||
]; | ||
|
||
const handleYAxisChange = useCallback( | ||
(id: string) => { | ||
onChange({ | ||
...chartOptions, | ||
yAxisMode: id as MetricsExplorerYAxisMode, | ||
}); | ||
}, | ||
[chartOptions, onChange] | ||
); | ||
|
||
const handleTypeChange = useCallback( | ||
(id: string) => { | ||
onChange({ | ||
...chartOptions, | ||
type: id as MetricsExplorerChartType, | ||
}); | ||
}, | ||
[chartOptions, onChange] | ||
); | ||
|
||
const handleStackChange = useCallback( | ||
e => { | ||
onChange({ | ||
...chartOptions, | ||
stack: e.target.checked, | ||
}); | ||
}, | ||
[chartOptions, onChange] | ||
); | ||
|
||
return ( | ||
<EuiPopover | ||
id="MetricExplorerChartOptionsPopover" | ||
button={button} | ||
isOpen={isPopoverOpen} | ||
closePopover={handleClosePopover} | ||
> | ||
<EuiForm> | ||
<EuiFormRow | ||
compressed | ||
label={intl.formatMessage({ | ||
id: 'xpack.infra.metricsExplorer.chartOptions.typeLabel', | ||
defaultMessage: 'Chart Style', | ||
})} | ||
> | ||
<EuiRadioGroup | ||
options={typeRadios} | ||
idSelected={chartOptions.type} | ||
onChange={handleTypeChange} | ||
/> | ||
</EuiFormRow> | ||
<EuiFormRow | ||
compressed | ||
label={intl.formatMessage({ | ||
id: 'xpack.infra.metricsExplorer.chartOptions.stackLabel', | ||
defaultMessage: 'Stack Series', | ||
})} | ||
> | ||
<EuiSwitch | ||
label={intl.formatMessage({ | ||
id: 'xpack.infra.metricsExplorer.chartOptions.stackSwitchLabel', | ||
defaultMessage: 'Stack', | ||
})} | ||
checked={chartOptions.stack} | ||
onChange={handleStackChange} | ||
/> | ||
</EuiFormRow> | ||
<EuiFormRow | ||
compressed | ||
label={intl.formatMessage({ | ||
id: 'xpack.infra.metricsExplorer.chartOptions.yAxisDomainLabel', | ||
defaultMessage: 'Y Axis Domain', | ||
})} | ||
> | ||
<EuiRadioGroup | ||
options={yAxisRadios} | ||
idSelected={chartOptions.yAxisMode} | ||
onChange={handleYAxisChange} | ||
/> | ||
</EuiFormRow> | ||
</EuiForm> | ||
</EuiPopover> | ||
); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the final
)
bracket here.